From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Tsukasa OI <research_trasio@irq.a4lg.com>,
Kito Cheng <kito.cheng@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [RFC PATCH 0/2] RISC-V: __builtin_riscv_pause for all environment
Date: Sun, 13 Aug 2023 21:52:59 +0200 [thread overview]
Message-ID: <CAAeLtUDEYEpJpJfb=TtBaw4k6Y2eFNvb73k8mSFgCRy-Re+qCg@mail.gmail.com> (raw)
In-Reply-To: <e775ecef-4418-eabd-ecee-f0a53dda2dd8@gmail.com>
On Sat, 12 Aug 2023 at 01:31, Jeff Law via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>
>
> On 8/9/23 16:39, Tsukasa OI wrote:
> > On 2023/08/10 5:05, Jeff Law wrote:
>
> >> I'd tend to think we do not want to expose the intrinsic unless the
> >> right extensions are enabled -- even though the encoding is a no-op and
> >> we could emit it as a .insn.
> >
> > I think that makes sense. The only reason I implemented the
> > no-'Zihintpause' version is because GCC 13 implemented the built-in
> > unconditionally. If the compatibility breakage is considered minimum (I
> > don't know, though), I'm ready to submit 'Zihintpause'-only version of
> > this patch set.
> While it's a compatibility break I don't think we have a need to
> preserve this kind of compatibility. I suspect anyone using
> __builtin_riscv_pause was probably already turning on Zihintpause and if
> they weren't they should have been :-0
>
>
> I'm sure we'll kick this around in the Tuesday meeting and hopefully
> make a decision about the desired direction. You're obviously welcome
> to join if you're inclined. Let me know if you need an invite.
The original discussion (and I believe that Andrew was the decisive
voice in the end) came to the conclusion that—given that pause is a
true hint—it could always be enabled.
We had originally expected to enable it only if Zihintpause was part
of the target architecture, but viewing it as "just a name for an
already existing pure hint" also made sense.
Note that on systems that don't implement Zihintpause, the hint is
guarantueed to not have an architectural effect.
That said, I don't really have a strong leaning one way or another.
Philipp.
next prev parent reply other threads:[~2023-08-13 19:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 6:11 Tsukasa OI
2023-08-09 6:11 ` [RFC PATCH 1/2] " Tsukasa OI
2023-08-28 21:12 ` Jeff Law
2023-08-29 2:02 ` Tsukasa OI
2023-08-09 6:11 ` [RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause Tsukasa OI
2023-08-28 21:14 ` Jeff Law
2023-08-28 23:09 ` Hans-Peter Nilsson
2023-08-28 23:15 ` Jeff Law
2023-08-29 2:15 ` Tsukasa OI
2023-08-29 9:26 ` Hans-Peter Nilsson
2023-08-09 20:05 ` [RFC PATCH 0/2] RISC-V: __builtin_riscv_pause for all environment Jeff Law
2023-08-09 22:39 ` Tsukasa OI
2023-08-11 23:30 ` Jeff Law
2023-08-11 23:34 ` Palmer Dabbelt
2023-08-12 0:20 ` Tsukasa OI
2023-08-15 13:49 ` Jeff Law
2023-08-13 19:52 ` Philipp Tomsich [this message]
2023-08-13 20:17 ` Andrew Waterman
2023-08-15 13:52 ` Jeff Law
2023-08-10 2:25 ` [RFC PATCH v2 " Tsukasa OI
2023-08-10 2:25 ` [RFC PATCH v2 1/2] " Tsukasa OI
2023-08-16 1:26 ` Jeff Law
2023-08-16 8:33 ` Philipp Tomsich
2023-08-21 14:02 ` Jeff Law
2023-08-10 2:25 ` [RFC PATCH v2 2/2] RISC-V: Fix documentation of __builtin_riscv_pause Tsukasa OI
2023-08-10 2:26 ` [RFC PATCH 0/2] RISC-V: Make __builtin_riscv_pause 'Zihintpause' only Tsukasa OI
2023-08-10 2:26 ` [RFC PATCH 1/2] " Tsukasa OI
2023-08-10 2:26 ` [RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause Tsukasa OI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeLtUDEYEpJpJfb=TtBaw4k6Y2eFNvb73k8mSFgCRy-Re+qCg@mail.gmail.com' \
--to=philipp.tomsich@vrull.eu \
--cc=andrew@sifive.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=palmer@dabbelt.com \
--cc=research_trasio@irq.a4lg.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).