From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id A19123858D28 for ; Tue, 1 Aug 2023 23:06:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A19123858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-52256241c66so674947a12.1 for ; Tue, 01 Aug 2023 16:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1690931206; x=1691536006; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1qBWfo4/1Mb5lCZbidwtqj6VapimK9KWVVLrcFLvsT4=; b=LBsY2vslPg9tXsmqVxW4DCvpwJiXjBb+oKYOJEHP9Fx4iSlhZMe65Tt2GUK0lc4Tsn 4NC7cknpLuvN2Edv7a+shRNV7DSKe9oJH9URqRHvIeotNkrFoAyzp72J0pzmsM+h712I 6dbU78E4/sCmu+x9YYas2MqLWvU8HMschMgXLx5bpKa76s2fwtq2cayYiHwLsUthAlpb xmvGDQ92vH/M9Kq9ahlVcgoSF2H9BYtJGdO7C1X4EdHGM/avwzv4/St64XU/ak1Md0B2 BBin5/Y0N2ase7bh+5DiQ208I1qYID1tvVKpXtRqW9d/H3EdY6RIj2Nk/XKDejo1Hzlf O5qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690931206; x=1691536006; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1qBWfo4/1Mb5lCZbidwtqj6VapimK9KWVVLrcFLvsT4=; b=RupTSROsZ82n+yp4uMpsbN+awqeBA5em8FMC+IaD8JdebkAwr+WvusPtAYakgjiRyB wb3SIygFrq2rXD8v7uSrONRFMtcPls2iwh/lbOkPCUV/F8qKGlfZJHwhyBpAtfYO3ok1 L+74oCM7aNaeMJUbNzqoLPbvNUaWffAxbdtJvXkxlcYjG/5/R099XR10uE1XYFM7W8sh ReQ5WfLwDbEjvnuTES+Z7cb+O3REjd8oEqH8D5UDBtnxuQLIn/NWoHiBEE3GR0F6Vd0i Ph/2rZ/bI0fjvlaN5HciksRHqjZrkuNvXhz4rfqKEF1uD2D/QbJGkT1udrTvSFnkrbJm xAaQ== X-Gm-Message-State: ABy/qLYKxWjx1znJ/LyAte2i9Z7xxq+xsYlV9eXKAFVulfOmPgIEAbwg yy4AgHpWT5xuR7dT3szpeoLuBv9WitcfSaE+8AtWuw== X-Google-Smtp-Source: APBJJlFEb2RnVjQaslLRSgoO3I1QEg36Q0jGa37GCvKYSQZp23jCHWmHT8YpG98LOiCUmcA/rdkXKduANxBMcmT4Zms= X-Received: by 2002:a05:6402:134c:b0:522:abaf:1b0b with SMTP id y12-20020a056402134c00b00522abaf1b0bmr5263035edw.18.1690931206082; Tue, 01 Aug 2023 16:06:46 -0700 (PDT) MIME-Version: 1.0 References: <3c1f0f8a-34ed-abb2-8a49-3083a2cc55d2@gmail.com> <61c9b9c2-f52e-2b4e-6d02-62c991603c39@gmail.com> <64233838-fe5e-458d-1eaf-3025b5448d85@rivosinc.com> <91c12503-c288-5b81-8941-cc62bab2ee98@gmail.com> <73dc8b97-7a7b-d9a0-2e8e-b4a5aaa3ee93@rivosinc.com> In-Reply-To: <73dc8b97-7a7b-d9a0-2e8e-b4a5aaa3ee93@rivosinc.com> From: Philipp Tomsich Date: Wed, 2 Aug 2023 01:06:35 +0200 Message-ID: Subject: Re: RISC-V: Folding memory for FP + constant case To: Vineet Gupta Cc: Jeff Law , Manolis Tsamis , Jivan Hakobyan , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Very helpful! Looks as if regprop for stack_pointer is now either too conservative =E2=80=94 or one of our patches is missing in everyone's test setup; we'll take a closer look. On Wed, 2 Aug 2023 at 01:03, Vineet Gupta wrote: > > > > On 8/1/23 15:07, Philipp Tomsich wrote: > > +Manolis Tsamis > > > > On Tue, 1 Aug 2023 at 23:56, Jeff Law via Gcc-patches > > wrote: > >> > >> > >> On 8/1/23 13:14, Vineet Gupta wrote: > >> > >>> I have some numbers for f-m-o v3 vs this. Attached here (vs. inline t= o > >>> avoid the Thunderbird mangling the test formatting) > >> Thanks. Of particular importance is the leela change. My recollectio= n > >> was that the f-m-o work also picked up that case. But if my memory is > >> faulty (always a possibility), then that shows a clear case where > >> Jivan's work picks up a case not handled by Manolis's work. > > f-m-o originally targeted (and benefited) the leela-case. I wonder if > > other optimizations/changes over the last year interfere with this and > > what needs to be changed to accomodate this... looks like we need to > > revisit against trunk. > > > > Philipp. > > > >> And on the other direction we can see that deepsjeng isn't helped by > >> Jivan's work, but is helped by Manolis's new pass. > >> > >> I'd always hoped/expected we'd have cases where one patch clearly help= ed > >> over the other. While the .25% to .37% improvements for the three mos= t > >> impacted benchmarks doesn't move the needle much across the whole suit= e > >> they do add up over time. > >> > >> Jeff > > I took a quick look at Leela, the significant difference is from > additional insns with SP not getting propagated. > > e.g. > > 231b6: mv a4,sp > 231b8: sh2add a5,a5,a4 > > vs. > > 1e824: sh2add a5,a5,sp > > There are 5 such instances which more or less make up for the delta. > > -Vineet >