From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: Christoph Muellner <christoph.muellner@vrull.eu>
Cc: gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>,
Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCH] riscv: bitmanip: Remove duplicate zero_extendhi<GPR:mode>2 pattern
Date: Fri, 8 Sep 2023 11:28:49 +0200 [thread overview]
Message-ID: <CAAeLtUDY3a61MFN_xfyRcy9q7TZS2UVB_AzGd=3U3G6zFnceKw@mail.gmail.com> (raw)
In-Reply-To: <20230908065330.2367271-1-christoph.muellner@vrull.eu>
[-- Attachment #1: Type: text/plain, Size: 2292 bytes --]
Committed as 'obvious' to master. Thanks!
Philipp.
On Fri, 8 Sept 2023 at 08:53, Christoph Muellner <
christoph.muellner@vrull.eu> wrote:
> From: Christoph Müllner <christoph.muellner@vrull.eu>
>
> We currently have two identical zero_extendhi<GPR:mode>2 patterns:
> * '*zero_extendhi<GPR:mode>2_zbb'
> * '*zero_extendhi<GPR:mode>2_bitmanip'
>
> This patch removes the *_zbb pattern and ensures that all sign- and
> zero-extensions use the postfix '_bitmanip'.
>
> Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
>
> gcc/ChangeLog:
>
> * config/riscv/bitmanip.md
> (*extend<SHORT:mode><SUPERQI:mode>2_zbb):
> Rename postfix to _bitmanip.
> (*extend<SHORT:mode><SUPERQI:mode>2_bitmanip): Renamed pattern.
> (*zero_extendhi<GPR:mode>2_zbb): Remove duplicated pattern.
> ---
> gcc/config/riscv/bitmanip.md | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/gcc/config/riscv/bitmanip.md b/gcc/config/riscv/bitmanip.md
> index 1544ef4e125..431b3292213 100644
> --- a/gcc/config/riscv/bitmanip.md
> +++ b/gcc/config/riscv/bitmanip.md
> @@ -283,7 +283,7 @@ (define_insn "*zero_extendhi<GPR:mode>2_bitmanip"
> [(set_attr "type" "bitmanip,load")
> (set_attr "mode" "<GPR:MODE>")])
>
> -(define_insn "*extend<SHORT:mode><SUPERQI:mode>2_zbb"
> +(define_insn "*extend<SHORT:mode><SUPERQI:mode>2_bitmanip"
> [(set (match_operand:SUPERQI 0 "register_operand" "=r,r")
> (sign_extend:SUPERQI
> (match_operand:SHORT 1 "nonimmediate_operand" " r,m")))]
> @@ -294,17 +294,6 @@ (define_insn "*extend<SHORT:mode><SUPERQI:mode>2_zbb"
> [(set_attr "type" "bitmanip,load")
> (set_attr "mode" "<SUPERQI:MODE>")])
>
> -(define_insn "*zero_extendhi<GPR:mode>2_zbb"
> - [(set (match_operand:GPR 0 "register_operand" "=r,r")
> - (zero_extend:GPR
> - (match_operand:HI 1 "nonimmediate_operand" " r,m")))]
> - "TARGET_ZBB"
> - "@
> - zext.h\t%0,%1
> - lhu\t%0,%1"
> - [(set_attr "type" "bitmanip,load")
> - (set_attr "mode" "HI")])
> -
> (define_expand "rotrdi3"
> [(set (match_operand:DI 0 "register_operand")
> (rotatert:DI (match_operand:DI 1 "register_operand")
> --
> 2.41.0
>
>
prev parent reply other threads:[~2023-09-08 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 6:53 Christoph Muellner
2023-09-08 9:28 ` Philipp Tomsich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeLtUDY3a61MFN_xfyRcy9q7TZS2UVB_AzGd=3U3G6zFnceKw@mail.gmail.com' \
--to=philipp.tomsich@vrull.eu \
--cc=andrew@sifive.com \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).