From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id A44913858289 for ; Sun, 13 Nov 2022 15:48:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A44913858289 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-lf1-x131.google.com with SMTP id b3so15549556lfv.2 for ; Sun, 13 Nov 2022 07:48:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jcwV7EIWqAnJ2j1c50bAZ0Os29GhEwl25WlIYrMK72M=; b=JcGyeB/RI6QKpT2HBWS/EuzHGzk18VUBZG5MQBXNm2ZPKIsNcn88wT5c44xEXbkKc/ 4niTXXwuzET4jdNpFDm24JOAgaAou60KXV8Zr6RGPkt8EEXnCnT5tjhHrIcBnk7XMVPa jUiPgUHI8Ul3a6wspb3l9HQ3G4HzhZ52IXSuz32cv02NTU4qnjPnIoCMO6Yn4BnXk6ut a+2q3rUs6bEm9dX8FSoMAdDdGqM27UMNCUmR2XCKZXJrQeaGqJeG2W/6hpdizaptr6Ah QE6gNx+Mz6LcgxtK66Z4VCBoDwAzvrjd+vMWEMZpdmXBE6+EKWY4Q3XMHu7xGtM192J4 e+Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jcwV7EIWqAnJ2j1c50bAZ0Os29GhEwl25WlIYrMK72M=; b=38M6oOqUQ7R4AvNOigr5W5h677ytZ2msP56jsH0MviK1vU1fttgTw4de0+KzsjnCTE aEjVIGoe9I9Z4KpujFwNPM6g9wAekO5sxYQ+qVwFtuUPWD2JaRca442NofYA4kAmCW/A ZV2gY5W29t3C922L4sAf3MbBP6CN2Im2QGRaF44ulYIq4oQzhgvWCVZ1v4Uc82t5XswU Ymaj9aZNj+32bx/+MLtxlWbP3otE2kVxcCNcg20/pav1Ylg+gP1PvM1BThxZX2iBug5h VTe3EcwFKRfHNT7Y8fDIfPZ70puDs13JWy3orPqh83oKMofdmKXg85QHFpe32HEzQz3P 1sfA== X-Gm-Message-State: ANoB5pkdP4nSMF7nlo/cIwvKqSs0V+sp9So0acjNY/zViWLtSKWLJWLC +TAfmRrx/VtjhIHT53cg8d3a0E2FrUCYa6Yx2WStpw== X-Google-Smtp-Source: AA0mqf6+K9P+X63OwkdQ3ElavRCUKEXvA38kyCQoFcpfK2vQoQM51/gEP7/6hE5yuTMvu6JAS+jlsBXeb3Z1ctj4tgI= X-Received: by 2002:a05:6512:3589:b0:4a9:2ca6:c14b with SMTP id m9-20020a056512358900b004a92ca6c14bmr3519751lfr.163.1668354510118; Sun, 13 Nov 2022 07:48:30 -0800 (PST) MIME-Version: 1.0 References: <20221108195456.2701279-1-philipp.tomsich@vrull.eu> <2b5a37c6-e7bc-6f65-eb40-326dba810253@gmail.com> In-Reply-To: <2b5a37c6-e7bc-6f65-eb40-326dba810253@gmail.com> From: Philipp Tomsich Date: Sun, 13 Nov 2022 16:48:18 +0100 Message-ID: Subject: Re: [PATCH] RISC-V: optimize '(a >= 0) ? b : 0' to srai + andn, if compiling for Zbb To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Jeff Law , Palmer Dabbelt , Kito Cheng , Vineet Gupta , Christoph Muellner Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Applied to master. Thanks! --Philipp. On Sun, 13 Nov 2022 at 01:24, Jeff Law wrote: > > > On 11/8/22 12:54, Philipp Tomsich wrote: > > If-conversion is turning '(a >= 0) ? b : 0' into a branchless sequence > > not a5,a0 > > srai a5,a5,63 > > and a0,a1,a5 > > missing the opportunity to combine the NOT and AND into an ANDN. > > > > This adds a define_split to help the combiner reassociate the NOT with > > the AND. > > > > > > gcc/ChangeLog: > > > > * config/riscv/bitmanip.md: New define_split. > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/zbb-srai-andn.c: New test. > > OK. > > > FWIW, combine can be pretty sneaky in manipulating the result of a scc > style insn. I've seen a port with pages and pages of special patterns > to match what simplify_if_then_else would do. > > > Jeff >