From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Christoph Muellner <christoph.muellner@vrull.eu>,
gcc-patches@gcc.gnu.org, Kito Cheng <kito.cheng@sifive.com>,
Jim Wilson <jim.wilson.gcc@gmail.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Andrew Waterman <andrew@sifive.com>
Subject: Re: [PATCH] riscv: xtheadcondmov: Don't run tests with -Oz
Date: Tue, 5 Sep 2023 10:59:06 +0200 [thread overview]
Message-ID: <CAAeLtUDs0JM9BUEa6gMxhK_uMhypDeDepnFtaYij30wmLD9PaQ@mail.gmail.com> (raw)
In-Reply-To: <ccc0d332-25d1-4e1a-9748-386a5a6b05f3@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2034 bytes --]
Applied to master. Thanks!
Philipp.
On Tue, 5 Sept 2023 at 08:22, Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
> On 9/1/23 04:20, Christoph Muellner wrote:
> > From: Christoph Müllner <christoph.muellner@vrull.eu>
> >
> > Recently, these xtheadcondmov tests regressed with -Oz:
> > * FAIL: gcc.target/riscv/xtheadcondmov-mveqz-imm-eqz.c
> > * FAIL: gcc.target/riscv/xtheadcondmov-mveqz-imm-not.c
> > * FAIL: gcc.target/riscv/xtheadcondmov-mvnez-imm-cond.c
> > * FAIL: gcc.target/riscv/xtheadcondmov-mvnez-imm-nez.c
> >
> > As -Oz stands for "Optimize aggressively for size rather than speed.",
> > we need to inspect the generated code, which looks like this:
> >
> > -Oz
> > 0000000000000000 <not_int_int>:
> > 0: e199 bnez a1,6 <.L2>
> > 2: 40100513 li a0,1025
> > 0000000000000006 <.L2>:
> > 6: 8082 ret
> >
> > -O2:
> > 0000000000000000 <not_int_int>:
> > 0: 40100793 li a5,1025
> > 4: 40b7950b th.mveqz a0,a5,a1
> > 8: 8082 ret
> >
> > As the generated code with -Oz consumes less size, there is nothing
> > wrong in the code generation. Instead, let's not run the xtheadcondmov
> > tests with -Oz.
> >
> > Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
> >
> > gcc/testsuite/ChangeLog:
> >
> > * gcc.target/riscv/xtheadcondmov-mveqz-imm-eqz.c: Disable for -Oz.
> > * gcc.target/riscv/xtheadcondmov-mveqz-imm-not.c: Likewise.
> > * gcc.target/riscv/xtheadcondmov-mveqz-reg-eqz.c: Likewise.
> > * gcc.target/riscv/xtheadcondmov-mveqz-reg-not.c: Likewise.
> > * gcc.target/riscv/xtheadcondmov-mvnez-imm-cond.c: Likewise.
> > * gcc.target/riscv/xtheadcondmov-mvnez-imm-nez.c: Likewise.
> > * gcc.target/riscv/xtheadcondmov-mvnez-reg-cond.c: Likewise.
> > * gcc.target/riscv/xtheadcondmov-mvnez-reg-nez.c: Likewise.
> OK
> jeff
>
prev parent reply other threads:[~2023-09-05 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 10:20 Christoph Muellner
2023-09-05 6:22 ` Jeff Law
2023-09-05 8:59 ` Philipp Tomsich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeLtUDs0JM9BUEa6gMxhK_uMhypDeDepnFtaYij30wmLD9PaQ@mail.gmail.com \
--to=philipp.tomsich@vrull.eu \
--cc=andrew@sifive.com \
--cc=christoph.muellner@vrull.eu \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=jim.wilson.gcc@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).