From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id A9A543858D32 for ; Tue, 5 Sep 2023 08:59:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9A543858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-523100882f2so3076495a12.2 for ; Tue, 05 Sep 2023 01:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1693904358; x=1694509158; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d2d8glnhIW3zxN8qisRQfa/31g9ipf/cHjMZCpFzHYY=; b=lZNNZUrZVey100m4w4vahcsjVv8BjR8/PC32njV6Gr4yjrkGD0yiOFoNqevdJYlQAa 1O62GiYcoSO0WTFu9v/ALL+voSxvTwhsay/sU2X0VO5lEPBX4F/mm4pw9L1tIFrK+LjF IkDghnwJMvl1Ch9r+4Ykeb/hH5XZChTvNVzMlgkJ7DCBjJRtXzW+TusffMvt82RZ0iMJ g2oR6unC7JFGCJKBGnVDQQgHnMUBySb+CdMTtJh4Cr3z80FQr9oLc+5eiBA16X0c6h4r fJgoTTdmsRMinzGijAVF767c4kPi0Gh3yMDvuaDlBDKAXk61bYnrVQXBCaFJIrD5uExU jJAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693904358; x=1694509158; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d2d8glnhIW3zxN8qisRQfa/31g9ipf/cHjMZCpFzHYY=; b=jLg9BtVsiEYIje/PNGrh53nVF0TOW9v4mHEXHFCarRLZF1rb+z23WsUDHIjkyoifLr 4GfXfI1b/HwW6Ed/SO+t4e0PIUhyZTXhN5usM3RsPP724OTKBItWPyKcFse57j1nbhzh hciO0ynDFtFZdR0pJEOjO2ZXB/Z8VDDRumiBv7SrGyi9aVXOMGaMtolHqOgmD1k7JWJK otfHtFQe0260vzGD9mXEsw8O93d6M+vRWvPFGTVKZ53QXyj3uxOzjSbZlNZPPB9XX2jB TJbVz2EGpIqzDksFHaV3UgGGpFd2jAPKk5LuTzJX3v7k1KHHzYOZHoQ0ks/vzTbnMwxJ 9C3Q== X-Gm-Message-State: AOJu0YxveflViypKWrE+fpm1mR2JrzgThhHoAEt92xQnukul2VrhjtVw 7HtSdHbvtMcnmMdbgMxGTYUkSKhWTanB5Zck8C8ODA== X-Google-Smtp-Source: AGHT+IH5mdFm11ox5GJOEwXRGqe0E4EMRG2UiAj1ygkH2qoDIYmtqIA743zN0Kj5OavN7nr4pdZWF156XgEn/N/GVYo= X-Received: by 2002:a05:6402:124b:b0:523:100b:462b with SMTP id l11-20020a056402124b00b00523100b462bmr9577673edw.5.1693904358082; Tue, 05 Sep 2023 01:59:18 -0700 (PDT) MIME-Version: 1.0 References: <20230901102006.511665-1-christoph.muellner@vrull.eu> In-Reply-To: From: Philipp Tomsich Date: Tue, 5 Sep 2023 10:59:06 +0200 Message-ID: Subject: Re: [PATCH] riscv: xtheadcondmov: Don't run tests with -Oz To: Jeff Law Cc: Christoph Muellner , gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman Content-Type: multipart/alternative; boundary="0000000000008c1fb8060498d796" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,JMQ_SPF_NEUTRAL,KAM_SHORT,LIKELY_SPAM_BODY,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000008c1fb8060498d796 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Applied to master. Thanks! Philipp. On Tue, 5 Sept 2023 at 08:22, Jeff Law wrote: > > > On 9/1/23 04:20, Christoph Muellner wrote: > > From: Christoph M=C3=BCllner > > > > Recently, these xtheadcondmov tests regressed with -Oz: > > * FAIL: gcc.target/riscv/xtheadcondmov-mveqz-imm-eqz.c > > * FAIL: gcc.target/riscv/xtheadcondmov-mveqz-imm-not.c > > * FAIL: gcc.target/riscv/xtheadcondmov-mvnez-imm-cond.c > > * FAIL: gcc.target/riscv/xtheadcondmov-mvnez-imm-nez.c > > > > As -Oz stands for "Optimize aggressively for size rather than speed.", > > we need to inspect the generated code, which looks like this: > > > > -Oz > > 0000000000000000 : > > 0: e199 bnez a1,6 <.L2> > > 2: 40100513 li a0,1025 > > 0000000000000006 <.L2>: > > 6: 8082 ret > > > > -O2: > > 0000000000000000 : > > 0: 40100793 li a5,1025 > > 4: 40b7950b th.mveqz a0,a5,a1 > > 8: 8082 ret > > > > As the generated code with -Oz consumes less size, there is nothing > > wrong in the code generation. Instead, let's not run the xtheadcondmov > > tests with -Oz. > > > > Signed-off-by: Christoph M=C3=BCllner > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/riscv/xtheadcondmov-mveqz-imm-eqz.c: Disable for -Oz. > > * gcc.target/riscv/xtheadcondmov-mveqz-imm-not.c: Likewise. > > * gcc.target/riscv/xtheadcondmov-mveqz-reg-eqz.c: Likewise. > > * gcc.target/riscv/xtheadcondmov-mveqz-reg-not.c: Likewise. > > * gcc.target/riscv/xtheadcondmov-mvnez-imm-cond.c: Likewise. > > * gcc.target/riscv/xtheadcondmov-mvnez-imm-nez.c: Likewise. > > * gcc.target/riscv/xtheadcondmov-mvnez-reg-cond.c: Likewise. > > * gcc.target/riscv/xtheadcondmov-mvnez-reg-nez.c: Likewise. > OK > jeff > --0000000000008c1fb8060498d796--