From: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
To: Christophe Lyon <christophe.lyon@arm.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@arm.com>
Subject: Re: vec_perm_const hook -- Fix build failure in ARM backend
Date: Mon, 30 May 2022 13:29:54 +0530 [thread overview]
Message-ID: <CAAgBjM=1W+ybponVfAWfQviKKh3hcqZ_f2Tc59AGL45B4qtD_w@mail.gmail.com> (raw)
In-Reply-To: <56c6f883-d307-78e8-a430-93759d02e6f3@arm.com>
On Mon, 30 May 2022 at 13:04, Christophe Lyon <christophe.lyon@arm.com> wrote:
>
> Hi Prathamesh,
>
>
> On 5/27/22 09:11, Prathamesh Kulkarni via Gcc-patches wrote:
> > Hi,
> > I forgot to adjust prototype for arm_vectorize_vec_perm_const, which,
> > resulted in following
> > build error:
> >
> > # 00:05:33 make[3]: [Makefile:1787:
> > armv8l-unknown-linux-gnueabihf/bits/largefile-config.h] Error 1
> > (ignored)
> > # 00:10:53 /home/tcwg-buildslave/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/config/arm/arm.cc:299:13:
> > error: ‘bool arm_vectorize_vec_perm_const(machine_mode, rtx, rtx, rtx,
> > const vec_perm_indices&)’ declared ‘static’ but never defined
> > [-Werror=unused-function]
> > # 00:12:22 make[3]: *** [Makefile:2418: arm.o] Error 1
> > # 00:23:34 make[2]: *** [Makefile:5005: all-stage2-gcc] Error 2
> > # 00:23:34 make[1]: *** [Makefile:25739: stage2-bubble] Error 2
> > # 00:23:34 make: *** [Makefile:1072: all] Error 2
> >
> > https://gcc.gnu.org/pipermail/gcc-regression/2022-May/076645.html
> >
> > The attached patch fixes it.
> > OK to commit ?
> >
>
> Doesn't this count as "obvious" ?
OK, pushed.
Thanks,
Prathamesh
>
> Thanks,
>
> Christophe
>
> > Thanks,
> > Prathamesh
prev parent reply other threads:[~2022-05-30 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 7:11 Prathamesh Kulkarni
2022-05-30 7:34 ` Christophe Lyon
2022-05-30 7:59 ` Prathamesh Kulkarni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAgBjM=1W+ybponVfAWfQviKKh3hcqZ_f2Tc59AGL45B4qtD_w@mail.gmail.com' \
--to=prathamesh.kulkarni@linaro.org \
--cc=christophe.lyon@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).