From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 0A8D13858D20 for ; Wed, 13 Sep 2023 14:50:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0A8D13858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-307d58b3efbso6329800f8f.0 for ; Wed, 13 Sep 2023 07:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694616645; x=1695221445; darn=gcc.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=bGgqQTbimB/HA5VqPwataw1rMpLoxWPJQHjkq00CKnc=; b=vdvTcbUggk0CcHdRZqPPk4zv/WafmMnfIURfUXdvQUgi12bA7fLPr/m54qKzBVUwPV 2qP2aGcRJNJa/Gp9MfQHpoa1uFWZxP8uG2hhSAaFelmvjfZsCn/ZTEyNone8o3AHcZOH 2pPcSwviJWK+d6zqY+IkfviuKx6TW+XIWkm/N6pd0uXL1vLlle+SStH6G03rNsdlB0XN 9mnNFK7V688jj0qIyXKwLkO6k7hDw12BSjE+DLKZWtDIV47/f0XYEo4yLCmGLiEJjXHv LbAfxBPapW0EB+AZ9jEUyQXdf3dMNoGjoDNChP0FTZLiXpE8iafYp69C2xmvnETw7xUe VOLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694616645; x=1695221445; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bGgqQTbimB/HA5VqPwataw1rMpLoxWPJQHjkq00CKnc=; b=gaAvK6JVFtwRyOkom7QiFEItYcnTGKbmdM3LCvIiZZHiUV15k5yvqbTc/TBB1yhdRG TVPGquwcJTST8LEelJRIod1wxz/5NUDdDN4u3BPfq6lZm+1Q98yfq1dZOj3Rupm5tYIk 2f2iqqgMdo8wW6sk4UGtiZIZR2rIJii5Vmn1IxL9Bi4b+bGAljw2Wdya9V+WDFF5qp16 s+naaYOnBJqG7VNXDDxL1fVZEGg/OhU5KwePCNfrhTDQxWJHxroRlWAooWRfmuFjChCc SACrgxyCI6cI5gSOgzDhFROw4ZKR4ydRULpngTMlrKiXn4ssZOZl+i8TwLXfkOSNElGK y2PQ== X-Gm-Message-State: AOJu0Yz6X9ov6ZxTS8RaAqy4yexFzfgWyFf42wWoxsr4YUrbLfUpsvHl IkUPLW1yoL7CZf2TsfrWh1St4E4txiVsb108EmbGvQ== X-Google-Smtp-Source: AGHT+IFN0uQS10x8W/gmqgW/U8WgN4sWfjZ3ptR9FOiqEeo7HA9nj1ipmloI5/qrEHO6LCgbbeODlmuExIsKEw+LDgI= X-Received: by 2002:a5d:538f:0:b0:319:67da:ed68 with SMTP id d15-20020a5d538f000000b0031967daed68mr2235776wrv.7.1694616645338; Wed, 13 Sep 2023 07:50:45 -0700 (PDT) MIME-Version: 1.0 From: Prathamesh Kulkarni Date: Wed, 13 Sep 2023 20:20:08 +0530 Message-ID: Subject: [AArch64][testsuite] Adjust vect_copy_lane_1.c for new code-gen To: Richard Sandiford , Adhemerval Zanella , gcc Patches Content-Type: multipart/mixed; boundary="0000000000002d3eb706053eaf28" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000002d3eb706053eaf28 Content-Type: text/plain; charset="UTF-8" Hi, After 27de9aa152141e7f3ee66372647d0f2cd94c4b90, there's a following regression: FAIL: gcc.target/aarch64/vect_copy_lane_1.c scan-assembler-times ins\\tv0.s\\[1\\], v1.s\\[0\\] 3 This happens because for the following function from vect_copy_lane_1.c: float32x2_t __attribute__((noinline, noclone)) test_copy_lane_f32 (float32x2_t a, float32x2_t b) { return vcopy_lane_f32 (a, 1, b, 0); } Before 27de9aa152141e7f3ee66372647d0f2cd94c4b90, it got lowered to following sequence in .optimized dump: [local count: 1073741824]: _4 = BIT_FIELD_REF ; __a_5 = BIT_INSERT_EXPR ; return __a_5; The above commit simplifies BIT_FIELD_REF + BIT_INSERT_EXPR to vector permutation and now thus gets lowered to: [local count: 1073741824]: __a_4 = VEC_PERM_EXPR ; return __a_4; Since we give higher priority to aarch64_evpc_zip over aarch64_evpc_ins in aarch64_expand_vec_perm_const_1, it now generates: test_copy_lane_f32: zip1 v0.2s, v0.2s, v1.2s ret Similarly for test_copy_lane_[us]32. The attached patch adjusts the tests to reflect the change in code-gen and the tests pass. OK to commit ? Thanks, Prathamesh --0000000000002d3eb706053eaf28 Content-Type: text/plain; charset="US-ASCII"; name="gnu-890-1.txt" Content-Disposition: attachment; filename="gnu-890-1.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lmhs80w00 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hYXJjaDY0L3ZlY3RfY29weV9s YW5lXzEuYyBiL2djYy90ZXN0c3VpdGUvZ2NjLnRhcmdldC9hYXJjaDY0L3ZlY3RfY29weV9sYW5l XzEuYwppbmRleCAyODQ4YmU1NjRkNS4uODExZGM2NzhiOTIgMTAwNjQ0Ci0tLSBhL2djYy90ZXN0 c3VpdGUvZ2NjLnRhcmdldC9hYXJjaDY0L3ZlY3RfY29weV9sYW5lXzEuYworKysgYi9nY2MvdGVz dHN1aXRlL2djYy50YXJnZXQvYWFyY2g2NC92ZWN0X2NvcHlfbGFuZV8xLmMKQEAgLTIyLDcgKzIy LDcgQEAgQlVJTERfVEVTVCAodWludDE2eDRfdCwgdWludDE2eDRfdCwgLCAsIHUxNiwgMywgMikK IEJVSUxEX1RFU1QgKGZsb2F0MzJ4Ml90LCBmbG9hdDMyeDJfdCwgLCAsIGYzMiwgMSwgMCkKIEJV SUxEX1RFU1QgKGludDMyeDJfdCwgICBpbnQzMngyX3QsICAgLCAsIHMzMiwgMSwgMCkKIEJVSUxE X1RFU1QgKHVpbnQzMngyX3QsICB1aW50MzJ4Ml90LCAgLCAsIHUzMiwgMSwgMCkKLS8qIHsgZGct ZmluYWwgeyBzY2FuLWFzc2VtYmxlci10aW1lcyAiaW5zXFx0djAuc1xcXFsxXFxcXSwgdjEuc1xc XFswXFxcXSIgMyB9IH0gKi8KKy8qIHsgZGctZmluYWwgeyBzY2FuLWFzc2VtYmxlci10aW1lcyAi emlwMVxcdHYwLjJzLCB2MC4ycywgdjEuMnMiIDMgfSB9ICovCiBCVUlMRF9URVNUIChpbnQ2NHgx X3QsICAgaW50NjR4MV90LCAgICwgLCBzNjQsIDAsIDApCiBCVUlMRF9URVNUICh1aW50NjR4MV90 LCAgdWludDY0eDFfdCwgICwgLCB1NjQsIDAsIDApCiBCVUlMRF9URVNUIChmbG9hdDY0eDFfdCwg ZmxvYXQ2NHgxX3QsICwgLCBmNjQsIDAsIDApCg== --0000000000002d3eb706053eaf28--