From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 170423858D20 for ; Fri, 23 Jun 2023 09:09:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 170423858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-31129591288so397304f8f.1 for ; Fri, 23 Jun 2023 02:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687511384; x=1690103384; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=A95qsZsuFS3f1Vb7m8KecQO+ohOnsNXWaS3pe6ILnC0=; b=AIbulO9dSMHgMa4ui/Zc71YCRyFzN/ltgJAgvsYgkQ+JKVzywG2N9Lzcs61Pnb34g5 OfhSGz28YQZsG/Ss1fUwMa3UBZxsjpzm6ovrUCC8o2hzKJTbVR2VAwfN82viC14oxCQH 7lXrv6oYrK+ORyJ/uAOrbuwg2FPJnN7iLTfzCU75vofpOWlFzG4v4TOmTK94bYCXpEbf 5CZ603t/ICceCFeXaZB7pNccw3LoZfUSrsZzV0QMcu7qIgJWuO7A7eHbjN0FPZwAdyDi QuLlKn4OB+MIvb7lzTJW3/xv3Mi6QTEifNfNWIlVZfqtP3FaFpiH2S4HY/+NEU016erM zn/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687511384; x=1690103384; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A95qsZsuFS3f1Vb7m8KecQO+ohOnsNXWaS3pe6ILnC0=; b=TRRKtyKQLncjPl2rOGXnKkZvMRc5DhfDq6K6JEIL3rMYIR0gObwIjgof8jY5ERie1b KljOq4gW/AgsnVyPcnZGti4i1BdbYVXNVcN/JspT+mpPY/vxqoVcF4KJIuYOV8NxEI6+ SYnUO90ELInV4+XceZyna1qJnxKHl122m2AksnIs2xyKFotUx2Wsor6Nm03nUgrT5n4E WqMlKFQ/Me6FGviqfUpAa+QnbJIwGaPEuVqJye4yqfDGUa+aCcLtKiZ4N0duo0TDfc11 JJJU1jwGrw0B7UdKozvJ2ykrpvVdfz/NFriiOxgA+mIDcG+SIFEp9NE61GJrGIHDtx8p za3g== X-Gm-Message-State: AC+VfDw2swYXuyTqmlHlJ5cfOMRtsYUUNkj2uH8YH21y9wFMMchn5APX eejxIa+Xsqm6gvTdk3MESom0ESZi+c8b5Ym/WxO2Tg== X-Google-Smtp-Source: ACHHUZ7H8uB83bGQc0/IdzHwccjEhnGfuen2exWaQXU2LMvN4bqZv+jKgqGE9I6aII9WvjYrhaXRZjmyleY48Eg2QO4= X-Received: by 2002:a5d:568a:0:b0:311:101f:6c17 with SMTP id f10-20020a5d568a000000b00311101f6c17mr14791350wrv.2.1687511384158; Fri, 23 Jun 2023 02:09:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Prathamesh Kulkarni Date: Fri, 23 Jun 2023 14:39:08 +0530 Message-ID: Subject: Re: [SVE][match.pd] Fix ICE observed in PR110280 To: Richard Biener Cc: gcc Patches , Richard Sandiford Content-Type: multipart/mixed; boundary="0000000000009b99d205fec85ca6" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000009b99d205fec85ca6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 22 Jun 2023 at 18:06, Richard Biener w= rote: > > On Thu, Jun 22, 2023 at 11:08=E2=80=AFAM Prathamesh Kulkarni > wrote: > > > > On Tue, 20 Jun 2023 at 16:47, Richard Biener wrote: > > > > > > On Tue, Jun 20, 2023 at 11:56=E2=80=AFAM Prathamesh Kulkarni via Gcc-= patches > > > wrote: > > > > > > > > Hi Richard, > > > > For the following reduced test-case taken from PR: > > > > > > > > #include "arm_sve.h" > > > > svuint32_t l() { > > > > alignas(16) const unsigned int lanes[4] =3D {0, 0, 0, 0}; > > > > return svld1rq_u32(svptrue_b8(), lanes); > > > > } > > > > > > > > compiling with -O3 -mcpu=3Dgeneric+sve results in following ICE: > > > > during GIMPLE pass: fre > > > > pr110280.c: In function 'l': > > > > pr110280.c:5:1: internal compiler error: in eliminate_stmt, at > > > > tree-ssa-sccvn.cc:6890 > > > > 5 | } > > > > | ^ > > > > 0x865fb1 eliminate_dom_walker::eliminate_stmt(basic_block_def*, > > > > gimple_stmt_iterator*) > > > > ../../gcc/gcc/tree-ssa-sccvn.cc:6890 > > > > 0x120bf4d eliminate_dom_walker::before_dom_children(basic_block_def= *) > > > > ../../gcc/gcc/tree-ssa-sccvn.cc:7324 > > > > 0x120bf4d eliminate_dom_walker::before_dom_children(basic_block_def= *) > > > > ../../gcc/gcc/tree-ssa-sccvn.cc:7257 > > > > 0x1aeec77 dom_walker::walk(basic_block_def*) > > > > ../../gcc/gcc/domwalk.cc:311 > > > > 0x11fd924 eliminate_with_rpo_vn(bitmap_head*) > > > > ../../gcc/gcc/tree-ssa-sccvn.cc:7504 > > > > 0x1214664 do_rpo_vn_1 > > > > ../../gcc/gcc/tree-ssa-sccvn.cc:8616 > > > > 0x1215ba5 execute > > > > ../../gcc/gcc/tree-ssa-sccvn.cc:8702 > > > > > > > > cc1 simplifies: > > > > lanes[0] =3D 0; > > > > lanes[1] =3D 0; > > > > lanes[2] =3D 0; > > > > lanes[3] =3D 0; > > > > _1 =3D { -1, ... }; > > > > _7 =3D svld1rq_u32 (_1, &lanes); > > > > > > > > to: > > > > _9 =3D MEM [(unsigned int * {ref-all})&l= anes]; > > > > _7 =3D VEC_PERM_EXPR <_9, _9, { 0, 1, 2, 3, ... }>; > > > > > > > > and then fre1 dump shows: > > > > Applying pattern match.pd:8675, generic-match-5.cc:9025 > > > > Match-and-simplified VEC_PERM_EXPR <_9, _9, { 0, 1, 2, 3, ... }> to= { > > > > 0, 0, 0, 0 } > > > > RHS VEC_PERM_EXPR <_9, _9, { 0, 1, 2, 3, ... }> simplified to { 0, = 0, 0, 0 } > > > > > > > > The issue seems to be with the following pattern: > > > > (simplify > > > > (vec_perm vec_same_elem_p@0 @0 @1) > > > > @0) > > > > > > > > which simplifies above VEC_PERM_EXPR to: > > > > _7 =3D {0, 0, 0, 0} > > > > which is incorrect since _9 and mask have different vector lengths. > > > > > > > > The attached patch amends the pattern to simplify above VEC_PERM_EX= PR > > > > only if operand and mask have same number of elements, which seems = to fix > > > > the issue, and we're left with the following in .optimized dump: > > > > [local count: 1073741824]: > > > > _2 =3D VEC_PERM_EXPR <{ 0, 0, 0, 0 }, { 0, 0, 0, 0 }, { 0, 1, 2, = 3, ... }>; > > > > > > it would be nice to have this optimized. > > > > > > - > > > (simplify > > > (vec_perm vec_same_elem_p@0 @0 @1) > > > - @0) > > > + (if (known_eq (TYPE_VECTOR_SUBPARTS (TREE_TYPE (@0)), > > > + TYPE_VECTOR_SUBPARTS (TREE_TYPE (@1)))) > > > + @0)) > > > > > > that looks good I think. Maybe even better use 'type' instead of TRE= E_TYPE (@1) > > > since that's more obviously the return type in which case > > > > > > (if (types_match (type, TREE_TYPE (@0)) > > > > > > would be more to the point. > > > > > > But can't you to simplify this in the !known_eq case do a simple > > > > > > { build_vector_from_val (type, the-element); } > > > > > > ? The 'vec_same_elem_p' predicate doesn't get you at the element, > > > > > > (with { tree el =3D uniform_vector_p (@0); } > > > (if (el) > > > { build_vector_from_val (type, el); }))) > > > > > > would be the cheapest workaround. > > Hi Richard, > > Thanks for the suggestions. Using build_vector_from_val simplifies it t= o: > > [local count: 1073741824]: > > return { 0, ... }; > > > > Patch is bootstrapped+tested on aarch64-linux-gnu, in progress on > > x86_64-linux-gnu. > > OK to commit ? > > Can you retain the case of matching type? Like > > (if (types_match (type, TREE_TYPE (@0)) > @0 > (with > { > tree elem =3D uniform_vector_p (@0); > } > (if (elem) > { build_vector_from_val (type, elem); })))) > > ? Because uniform_vector_p is strictly less powerful than (vec_same_elem= _p ...) > > OK with that change. Thanks, does the attached patch look OK ? Bootstrapped+tested on aarch64-linux-gnu and x86_64-linux-gnu. Thanks, Prathamesh > > Richard. > > > > > > Thanks, > > Prathamesh > > > > > > > return _2; > > > > > > > > code-gen: > > > > l: > > > > mov z0.b, #0 > > > > ret > > > > > > > > Patch is bootstrapped+tested on aarch64-linux-gnu. > > > > OK to commit ? > > > > > > > > Thanks, > > > > Prathamesh --0000000000009b99d205fec85ca6 Content-Type: text/plain; charset="US-ASCII"; name="pr110280-3.txt" Content-Disposition: attachment; filename="pr110280-3.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lj8cmt400 W2FhcmNoNjQvbWF0Y2gucGRdIEZpeCBJQ0Ugb2JzZXJ2ZWQgaW4gUFIxMTAyODAuCgpnY2MvQ2hh bmdlTG9nOgoJUFIgdHJlZS1vcHRpbWl6YXRpb24vMTEwMjgwCgkqIG1hdGNoLnBkICh2ZWNfcGVy bV9leHByKHYsIHYsIG1hc2spIC0+IHYpOiBFeHBsaWNpdGx5IGJ1aWxkIHZlY3RvcgoJdXNpbmcg YnVpbGRfdmVjdG9yX2Zyb21fdmFsIHdpdGggdGhlIGVsZW1lbnQgb2YgaW5wdXQgb3BlcmFuZCwg YW5kCgltYXNrJ3MgdHlwZSBpZiBvcGVyYW5kIGFuZCBtYXNrJ3MgdHlwZXMgZG9uJ3QgbWF0Y2gu CgpnY2MvdGVzdHN1aXRlL0NoYW5nZUxvZzoKCSogZ2NjLnRhcmdldC9hYXJjaDY0L3N2ZS9wcjEx MDI4MC5jOiBOZXcgdGVzdC4KCmRpZmYgLS1naXQgYS9nY2MvbWF0Y2gucGQgYi9nY2MvbWF0Y2gu cGQKaW5kZXggMmRkMjM4MjYwMzQuLjVjYmY3NGM5YTA2IDEwMDY0NAotLS0gYS9nY2MvbWF0Y2gu cGQKKysrIGIvZ2NjL21hdGNoLnBkCkBAIC04NjcyLDcgKzg2NzIsMTQgQEAgYW5kLAogCiAoc2lt cGxpZnkKICAodmVjX3Blcm0gdmVjX3NhbWVfZWxlbV9wQDAgQDAgQDEpCi0gQDApCisgKGlmICh0 eXBlc19tYXRjaCAodHlwZSwgVFJFRV9UWVBFIChAMCkpKQorICBAMAorICAod2l0aAorICAgewor ICAgICB0cmVlIGVsZW0gPSB1bmlmb3JtX3ZlY3Rvcl9wIChAMCk7CisgICB9CisgICAoaWYgKGVs ZW0pCisgICAgeyBidWlsZF92ZWN0b3JfZnJvbV92YWwgKHR5cGUsIGVsZW0pOyB9KSkpKQogCiAv KiBQdXNoIFZFQ19QRVJNIGVhcmxpZXIgaWYgdGhhdCBtYXkgaGVscCBGTUEgcGVyY2VwdGlvbiAo UFIxMDE4OTUpLiAgKi8KIChzaW1wbGlmeQpkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nY2Mu dGFyZ2V0L2FhcmNoNjQvc3ZlL3ByMTEwMjgwLmMgYi9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQv YWFyY2g2NC9zdmUvcHIxMTAyODAuYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMC4uZDMyNzlmMzgzNjIKLS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy50 YXJnZXQvYWFyY2g2NC9zdmUvcHIxMTAyODAuYwpAQCAtMCwwICsxLDEyIEBACisvKiB7IGRnLWRv IGNvbXBpbGUgfSAqLworLyogeyBkZy1vcHRpb25zICItTzMgLWZkdW1wLXRyZWUtb3B0aW1pemVk IiB9ICovCisKKyNpbmNsdWRlICJhcm1fc3ZlLmgiCisKK3N2dWludDMyX3QgbCgpCit7CisgIF9B bGlnbmFzKDE2KSBjb25zdCB1bnNpZ25lZCBpbnQgbGFuZXNbNF0gPSB7MCwgMCwgMCwgMH07Cisg IHJldHVybiBzdmxkMXJxX3UzMihzdnB0cnVlX2I4KCksIGxhbmVzKTsKK30KKworLyogeyBkZy1m aW5hbCB7IHNjYW4tdHJlZS1kdW1wLW5vdCAiVkVDX1BFUk1fRVhQUiIgIm9wdGltaXplZCIgfSB9 ICovCg== --0000000000009b99d205fec85ca6--