From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id B77D33858D1E for ; Mon, 24 Apr 2023 19:54:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B77D33858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-2eed43bfa4bso4408803f8f.2 for ; Mon, 24 Apr 2023 12:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682366050; x=1684958050; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=YiEFUKgHaN68gENIMwIRshUsHduByFoXzsYug6JtydE=; b=eIuRUt9sYJW1hX5TOqKJvH8NNX/Gd3sk184jYML/AmN6pn3/KMaxu5fmAf4iXL2uI7 IzpPQoPb9LPWxfx/9PePnbzoKKI6rQEdj7mzpXsRX3BkN3nVkdcz/A6KKN/tA5wJn0CD nasBwnSqhYCmX9P/hscCPiMvTiv6nxwe3itELwE0Rs3yIg6/UQcMLeRjTLIuX90AMNz8 L/24XF7wsVX85X6d7kThNjf1TRvQC8eYWQSbXvDIQXV3mIrXYh5VwzLEettmxS5cO2G3 1F40vRm4gitwzfxnJC1phLjQQ1kwMitALiOI5k86dvLMbU/fg/2Fnfs8b/Tpev0tJ/V+ d0jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682366050; x=1684958050; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YiEFUKgHaN68gENIMwIRshUsHduByFoXzsYug6JtydE=; b=Js0GvGzGaQ1JXXbZWfIP0T8JjOce9bYID0S7lDoLIIyrNIaeve/HSAbLY1wbMVcBMK /TjRcpJhmRvZ0WudrJIDLokrNGRnxpjBO4OLbAeAmbVUGdj3/jLLjZu3BYcyDjyKLEQv 9s/bqSnPVvaFJRA+r2MaqgLh1du5MC4UAUQBsSOX6QA7qSIMUZCtNDAwZ3ubtfVkYOwR KjA8P4ycBUDPX/E5YynZRpbLzTs987QNYZZEC/D2FVrXchC6PrEih+ky2iKNklh1oio9 yPY+2nJAaPG+ksmqiT4ZvNSiCWnANlts9BboQwzmplFyT32T7Kif/hiFhZyDdS2IUFAN IlJw== X-Gm-Message-State: AAQBX9e8mpCREE8YQ24oLz+ldpFs0WtLBf9BfTjaDxnaftqV1uqgBTvC yAeecpRsPvh+UHYIfoTP3NvF7kyzTBTGmL8cG4bX1g== X-Google-Smtp-Source: AKy350YAPRSzN1qKJVaNn8PgSpjRR+gexZOwuyZ/c/jsyozQVfI/WptXxyVmQu2rb9vydqqEnW2rKJ+Aq4VU+dWl5gU= X-Received: by 2002:adf:f5c7:0:b0:2f7:af3a:72fc with SMTP id k7-20020adff5c7000000b002f7af3a72fcmr11464925wrp.27.1682366050402; Mon, 24 Apr 2023 12:54:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Prathamesh Kulkarni Date: Tue, 25 Apr 2023 01:23:34 +0530 Message-ID: Subject: Re: [match.pd] [SVE] Add pattern to transform svrev(svrev(v)) --> v To: Prathamesh Kulkarni , Richard Biener , gcc Patches , richard.sandiford@arm.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 24 Apr 2023 at 15:02, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > gcc/ChangeLog: > > * tree-ssa-forwprop.cc (is_combined_permutation_identity): Try to > > simplify two successive VEC_PERM_EXPRs with single operand and same > > mask, where mask chooses elements in reverse order. > > > > gcc/testesuite/ChangeLog: > > * gcc.target/aarch64/sve/acle/general/rev-1.c: New test. > > > > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/acle/general/rev-1.c b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/rev-1.c > > new file mode 100644 > > index 00000000000..e57ee67d716 > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/aarch64/sve/acle/general/rev-1.c > > @@ -0,0 +1,12 @@ > > +/* { dg-do compile } */ > > +/* { dg-options "-O3 -fdump-tree-optimized" } */ > > + > > +#include > > + > > +svint32_t f(svint32_t v) > > +{ > > + return svrev_s32 (svrev_s32 (v)); > > +} > > + > > +/* { dg-final { scan-tree-dump "return v_1\\(D\\)" "optimized" } } */ > > +/* { dg-final { scan-tree-dump-not "VEC_PERM_EXPR" "optimized" } } */ > > diff --git a/gcc/tree-ssa-forwprop.cc b/gcc/tree-ssa-forwprop.cc > > index 9b567440ba4..61df7efe82c 100644 > > --- a/gcc/tree-ssa-forwprop.cc > > +++ b/gcc/tree-ssa-forwprop.cc > > @@ -2541,6 +2541,27 @@ is_combined_permutation_identity (tree mask1, tree mask2) > > > > gcc_checking_assert (TREE_CODE (mask1) == VECTOR_CST > > && TREE_CODE (mask2) == VECTOR_CST); > > + > > + /* For VLA masks, check for the following pattern: > > + v1 = VEC_PERM_EXPR (v0, v0, mask1) > > + v2 = VEC_PERM_EXPR (v1, v1, mask2) > > Maybe blank out the second operands using "...": > > v1 = VEC_PERM_EXPR (v0, ..., mask1) > v2 = VEC_PERM_EXPR (v1, ..., mask2) > > to make it clear that they don't matter. > > OK with that change, thanks. Thanks, committed in: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=f0eabc52c9a2d3da0bfc201da7a5c1658b76e9a4 Thanks, Prathamesh > > Richard > > > + --> > > + v2 = v0 > > + if mask1 == mask2 == {nelts - 1, nelts - 2, ...}. */ > > + > > + if (operand_equal_p (mask1, mask2, 0) > > + && !VECTOR_CST_NELTS (mask1).is_constant ()) > > + { > > + vec_perm_builder builder; > > + if (tree_to_vec_perm_builder (&builder, mask1)) > > + { > > + poly_uint64 nelts = TYPE_VECTOR_SUBPARTS (TREE_TYPE (mask1)); > > + vec_perm_indices sel (builder, 1, nelts); > > + if (sel.series_p (0, 1, nelts - 1, -1)) > > + return 1; > > + } > > + } > > + > > mask = fold_ternary (VEC_PERM_EXPR, TREE_TYPE (mask1), mask1, mask1, mask2); > > if (mask == NULL_TREE || TREE_CODE (mask) != VECTOR_CST) > > return 0;