* add check for aarch64 in check_effective_target_section_anchors()
@ 2016-02-11 17:33 Prathamesh Kulkarni
2016-02-15 13:54 ` James Greenhalgh
0 siblings, 1 reply; 3+ messages in thread
From: Prathamesh Kulkarni @ 2016-02-11 17:33 UTC (permalink / raw)
To: gcc Patches
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
Hi,
aarch64 supports section anchors but it appears
check_effective_target_section_anchors() doesn't contain entry for it.
This patch adds for entry for aarch64.
OK for trunk ?
Thanks,
Prathamesh
[-- Attachment #2: target-supports.diff --]
[-- Type: text/plain, Size: 540 bytes --]
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 645981a..66fb1ea 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -5467,7 +5467,8 @@ proc check_effective_target_section_anchors { } {
} else {
set et_section_anchors_saved 0
if { [istarget powerpc*-*-*]
- || [istarget arm*-*-*] } {
+ || [istarget arm*-*-*]
+ || [istarget aarch64*-*-*] } {
set et_section_anchors_saved 1
}
}
[-- Attachment #3: ChangeLog --]
[-- Type: application/octet-stream, Size: 176 bytes --]
2016-02-12 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
testsuite/
* lib/target-supports.exp (check_effective_target_section_anchors): Add
check for aarch64*-*-*.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: add check for aarch64 in check_effective_target_section_anchors()
2016-02-11 17:33 add check for aarch64 in check_effective_target_section_anchors() Prathamesh Kulkarni
@ 2016-02-15 13:54 ` James Greenhalgh
2016-02-15 17:32 ` Prathamesh Kulkarni
0 siblings, 1 reply; 3+ messages in thread
From: James Greenhalgh @ 2016-02-15 13:54 UTC (permalink / raw)
To: Prathamesh Kulkarni; +Cc: gcc Patches
On Thu, Feb 11, 2016 at 11:03:23PM +0530, Prathamesh Kulkarni wrote:
> Hi,
> aarch64 supports section anchors but it appears
> check_effective_target_section_anchors() doesn't contain entry for it.
> This patch adds for entry for aarch64.
> OK for trunk ?
OK. I presume you tested this, and the testcases this enables PASS without
issue?
Thanks,
James
> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
> index 645981a..66fb1ea 100644
> --- a/gcc/testsuite/lib/target-supports.exp
> +++ b/gcc/testsuite/lib/target-supports.exp
> @@ -5467,7 +5467,8 @@ proc check_effective_target_section_anchors { } {
> } else {
> set et_section_anchors_saved 0
> if { [istarget powerpc*-*-*]
> - || [istarget arm*-*-*] } {
> + || [istarget arm*-*-*]
> + || [istarget aarch64*-*-*] } {
> set et_section_anchors_saved 1
> }
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: add check for aarch64 in check_effective_target_section_anchors()
2016-02-15 13:54 ` James Greenhalgh
@ 2016-02-15 17:32 ` Prathamesh Kulkarni
0 siblings, 0 replies; 3+ messages in thread
From: Prathamesh Kulkarni @ 2016-02-15 17:32 UTC (permalink / raw)
To: James Greenhalgh; +Cc: gcc Patches
On 15 February 2016 at 19:24, James Greenhalgh <james.greenhalgh@arm.com> wrote:
> On Thu, Feb 11, 2016 at 11:03:23PM +0530, Prathamesh Kulkarni wrote:
>> Hi,
>> aarch64 supports section anchors but it appears
>> check_effective_target_section_anchors() doesn't contain entry for it.
>> This patch adds for entry for aarch64.
>> OK for trunk ?
>
> OK. I presume you tested this, and the testcases this enables PASS without
> issue?
Yes, the unsupported test-cases for section anchors pass.
http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/233425-target-supports/aarch64-none-linux-gnu/diff-gcc-rh60-aarch64-none-linux-gnu-default-default-default.txt
Tested with aarch64-none-linux-gnu, aarch64-none-elf, and aarch64_be-none-elf.
Committed as r233426.
Thanks,
Prathamesh
>
> Thanks,
> James
>
>> diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
>> index 645981a..66fb1ea 100644
>> --- a/gcc/testsuite/lib/target-supports.exp
>> +++ b/gcc/testsuite/lib/target-supports.exp
>> @@ -5467,7 +5467,8 @@ proc check_effective_target_section_anchors { } {
>> } else {
>> set et_section_anchors_saved 0
>> if { [istarget powerpc*-*-*]
>> - || [istarget arm*-*-*] } {
>> + || [istarget arm*-*-*]
>> + || [istarget aarch64*-*-*] } {
>> set et_section_anchors_saved 1
>> }
>> }
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-15 17:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-11 17:33 add check for aarch64 in check_effective_target_section_anchors() Prathamesh Kulkarni
2016-02-15 13:54 ` James Greenhalgh
2016-02-15 17:32 ` Prathamesh Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).