From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 6EBFC3858D39 for ; Wed, 19 Apr 2023 12:20:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6EBFC3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-2f55ffdbaedso2033141f8f.2 for ; Wed, 19 Apr 2023 05:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681906855; x=1684498855; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dGLrOs83lik7lh8Mt0c1VpBEaD4dCOy6OXAcoCCabuk=; b=uXh6bUfoV8dVsrLLOESyDwDGT7kaqPrbG/jDFLxhw2/fJGUW+nGDE8y0Ed/PA7DISS ySXJDVLKF1Zk8zX0awWFxSRhX4gtzsYGMmFmYdlit7CsQXsGY5EZ658D6SiMFzAqz483 RxO4v1R9uH7ldFRMNWUgvFuluNMUiiM7BoyUGUmkH6BxeGxxVBeg2vbk38oH+YjsbF3q 83VTKhcrLcEZQugrSn4CuFCgxczoH+SQ9XN0KorFbDp7OUT9NmAA0zWS/gAU754wClbB 8rPFKel7+pJ51mk8Ut+0Y/q/XsDtH18Nk1bo1TIp/PK75tN4GlKsqi8SQa3hb1GWf0fc kWQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681906855; x=1684498855; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dGLrOs83lik7lh8Mt0c1VpBEaD4dCOy6OXAcoCCabuk=; b=jFmhMt9YPO+ZnOLccWh3PLvolNTeX2t5gaMh46DZeN/Wkc4kWNKsuxni/8mIbPr7Fn PduGSdK+QmXfe04A3bdSEWOrDcJH7u6FvZgD/OiPGLTjWC6GY1dFz6Wwu2yGyZK9IE8t ZgsgOULm6Wj5Cz7poubU1dP03h3mWEVJvIQ3h1E0/sCByAtc9FVuoJOhiLtprssVPNsY rdsLGDL3zloGLhudP7eR4byyZZB4in3Jm1LF3WMV+foo1oqjksqLc0fZRpBAHC/ce0h3 kBSxA2Qj+vq3DZkpFxMV3Qfh02NiB2szDNUGmxMGt5OLk+73BhHqLmEzq2LMs9/KoQiX w6Pw== X-Gm-Message-State: AAQBX9eVZydsRV9QOIffeKIMzQXS9cSLfBVyLBDCZiYloinEXl6wT+Wa VqEpT67IX8eHyFXKfns55xeinMsAHzAPl+Ujodhatw== X-Google-Smtp-Source: AKy350bT7jy1lS9Ue5GSV0gQmXvoFyMm4IDBoH2dYDr98qSitCNLcDa7Pc81LqXDZYUaJ00GCIq7RrG129uzb+hn2is= X-Received: by 2002:a5d:640a:0:b0:2dc:c0da:409 with SMTP id z10-20020a5d640a000000b002dcc0da0409mr4669005wru.27.1681906855177; Wed, 19 Apr 2023 05:20:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Prathamesh Kulkarni Date: Wed, 19 Apr 2023 17:50:18 +0530 Message-ID: Subject: Re: [match.pd] [SVE] Add pattern to transform svrev(svrev(v)) --> v To: Richard Biener Cc: gcc Patches , Richard Sandiford Content-Type: multipart/mixed; boundary="000000000000a6246105f9af7439" X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000a6246105f9af7439 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 19 Apr 2023 at 16:17, Richard Biener w= rote: > > On Wed, Apr 19, 2023 at 11:21=E2=80=AFAM Prathamesh Kulkarni > wrote: > > > > On Tue, 11 Apr 2023 at 19:36, Prathamesh Kulkarni > > wrote: > > > > > > On Tue, 11 Apr 2023 at 14:17, Richard Biener wrote: > > > > > > > > On Wed, Apr 5, 2023 at 10:39=E2=80=AFAM Prathamesh Kulkarni via Gcc= -patches > > > > wrote: > > > > > > > > > > Hi, > > > > > For the following test: > > > > > > > > > > svint32_t f(svint32_t v) > > > > > { > > > > > return svrev_s32 (svrev_s32 (v)); > > > > > } > > > > > > > > > > We generate 2 rev instructions instead of nop: > > > > > f: > > > > > rev z0.s, z0.s > > > > > rev z0.s, z0.s > > > > > ret > > > > > > > > > > The attached patch tries to fix that by trying to recognize the f= ollowing > > > > > pattern in match.pd: > > > > > v1 =3D VEC_PERM_EXPR (v0, v0, mask) > > > > > v2 =3D VEC_PERM_EXPR (v1, v1, mask) > > > > > --> > > > > > v2 =3D v0 > > > > > if mask is { nelts - 1, nelts - 2, nelts - 3, ... } > > > > > > > > > > Code-gen with patch: > > > > > f: > > > > > ret > > > > > > > > > > Bootstrap+test passes on aarch64-linux-gnu, and SVE bootstrap in = progress. > > > > > Does it look OK for stage-1 ? > > > > > > > > I didn't look at the patch but tree-ssa-forwprop.cc:simplify_permut= ation should > > > > handle two consecutive permutes with the is_combined_permutation_id= entity > > > > which might need tweaking for VLA vectors > > > Hi Richard, > > > Thanks for the suggestions. The attached patch modifies > > > is_combined_permutation_identity > > > to recognize the above pattern. > > > Does it look OK ? > > > Bootstrap+test in progress on aarch64-linux-gnu and x86_64-linux-gnu. > > Hi, > > ping https://gcc.gnu.org/pipermail/gcc-patches/2023-April/615502.html > > Can you instead of def_stmt pass in a bool whether rhs1 is equal to rhs2 > and amend the function comment accordingly, say, > > tem =3D VEC_PERM ; > res =3D VEC_PERM ; > > SAME_P specifies whether op0 and op1 compare equal. */ > > + if (def_stmt) > + gcc_checking_assert (is_gimple_assign (def_stmt) > + && gimple_assign_rhs_code (def_stmt) =3D=3D VEC_= PERM_EXPR); > this is then unnecessary > > mask =3D fold_ternary (VEC_PERM_EXPR, TREE_TYPE (mask1), mask1, mask1,= mask2); > + > + /* For VLA masks, check for the following pattern: > + v1 =3D VEC_PERM_EXPR (v0, v0, mask) > + v2 =3D VEC_PERM_EXPR (v1, v1, mask) > + --> > + v2 =3D v0 > > you are not using 'mask' so please defer fold_ternary until after your > special-case. > > + if (operand_equal_p (mask1, mask2, 0) > + && !VECTOR_CST_NELTS (mask1).is_constant () > + && def_stmt > + && operand_equal_p (gimple_assign_rhs1 (def_stmt), > + gimple_assign_rhs2 (def_stmt), 0)) > + { > + vec_perm_builder builder; > + if (tree_to_vec_perm_builder (&builder, mask1)) > + { > + poly_uint64 nelts =3D TYPE_VECTOR_SUBPARTS (TREE_TYPE (mask1)); > + vec_perm_indices sel (builder, 1, nelts); > + if (sel.series_p (0, 1, nelts - 1, -1)) > + return 1; > + } > + return 0; > > I'm defering to Richard whether this is the correct way to check for a ve= ctor > reversing mask (I wonder how constructing such mask is even possible) Hi Richard, Thanks for the suggestions, I have updated the patch accordingly. The following hunk from svrev_impl::fold() constructs mask in reverse: /* Permute as { nelts - 1, nelts - 2, nelts - 3, ... }. */ poly_int64 nelts =3D TYPE_VECTOR_SUBPARTS (TREE_TYPE (f.lhs)); vec_perm_builder builder (nelts, 1, 3); for (int i =3D 0; i < 3; ++i) builder.quick_push (nelts - i - 1); return fold_permute (f, builder); To see if mask chooses elements in reverse, I borrowed it from function com= ment for series_p in vec-perm-indices.cc: /* Return true if index OUT_BASE + I * OUT_STEP selects input element IN_BASE + I * IN_STEP. For example, the call to test whether a permute reverses a vector of N elements would be: series_p (0, 1, N - 1, -1) which would return true for { N - 1, N - 2, N - 3, ... }. */ Thanks, Prathamesh > > Richard. > > > Thanks, > > Prathamesh > > > > > > Thanks, > > > Prathamesh > > > > > > > > Richard. > > > > > > > > > > > > > > Thanks, > > > > > Prathamesh --000000000000a6246105f9af7439 Content-Type: text/plain; charset="US-ASCII"; name="gnu-830-4.txt" Content-Disposition: attachment; filename="gnu-830-4.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lgnnp97n0 Z2NjL0NoYW5nZUxvZzoKCSogdHJlZS1zc2EtZm9yd3Byb3AuY2MgKGlzX2NvbWJpbmVkX3Blcm11 dGF0aW9uX2lkZW50aXR5KToKCU5ldyBwYXJhbWV0ZXIgc2FtZV9wLgoJVHJ5IHRvIHNpbXBsaWZ5 IHR3byBzdWNjZXNzaXZlIFZFQ19QRVJNX0VYUFJzIHdpdGggc2luZ2xlIG9wZXJhbmQKCWFuZCBz YW1lIG1hc2ssIHdoZXJlIG1hc2sgY2hvb3NlcyBlbGVtZW50cyBpbiByZXZlcnNlIG9yZGVyLgoK Z2NjL3Rlc3Rlc3VpdGUvQ2hhbmdlTG9nOgoJKiBnY2MudGFyZ2V0L2FhcmNoNjQvc3ZlL2FjbGUv Z2VuZXJhbC9yZXYtMS5jOiBOZXcgdGVzdC4KCmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2dj Yy50YXJnZXQvYWFyY2g2NC9zdmUvYWNsZS9nZW5lcmFsL3Jldi0xLmMgYi9nY2MvdGVzdHN1aXRl L2djYy50YXJnZXQvYWFyY2g2NC9zdmUvYWNsZS9nZW5lcmFsL3Jldi0xLmMKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmU1N2VlNjdkNzE2Ci0tLSAvZGV2L251bGwKKysr IGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FhcmNoNjQvc3ZlL2FjbGUvZ2VuZXJhbC9yZXYt MS5jCkBAIC0wLDAgKzEsMTIgQEAKKy8qIHsgZGctZG8gY29tcGlsZSB9ICovCisvKiB7IGRnLW9w dGlvbnMgIi1PMyAtZmR1bXAtdHJlZS1vcHRpbWl6ZWQiIH0gKi8KKworI2luY2x1ZGUgPGFybV9z dmUuaD4KKworc3ZpbnQzMl90IGYoc3ZpbnQzMl90IHYpCit7CisgIHJldHVybiBzdnJldl9zMzIg KHN2cmV2X3MzMiAodikpOworfQorCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi10cmVlLWR1bXAgInJl dHVybiB2XzFcXChEXFwpIiAib3B0aW1pemVkIiB9IH0gKi8KKy8qIHsgZGctZmluYWwgeyBzY2Fu LXRyZWUtZHVtcC1ub3QgIlZFQ19QRVJNX0VYUFIiICJvcHRpbWl6ZWQiIH0gfSAqLwpkaWZmIC0t Z2l0IGEvZ2NjL3RyZWUtc3NhLWZvcndwcm9wLmNjIGIvZ2NjL3RyZWUtc3NhLWZvcndwcm9wLmNj CmluZGV4IDliNTY3NDQwYmE0Li5lYmQ0YTM2OGFlOSAxMDA2NDQKLS0tIGEvZ2NjL3RyZWUtc3Nh LWZvcndwcm9wLmNjCisrKyBiL2djYy90cmVlLXNzYS1mb3J3cHJvcC5jYwpAQCAtMjUyOCwxMSAr MjUyOCwxNiBAQCBzaW1wbGlmeV9iaXRmaWVsZF9yZWYgKGdpbXBsZV9zdG10X2l0ZXJhdG9yICpn c2kpCiAgIHJldHVybiB0cnVlOwogfQogCi0vKiBEZXRlcm1pbmUgd2hldGhlciBhcHBseWluZyB0 aGUgMiBwZXJtdXRhdGlvbnMgKG1hc2sxIHRoZW4gbWFzazIpCi0gICBnaXZlcyBiYWNrIG9uZSBv ZiB0aGUgaW5wdXQuICAqLworLyogRm9yIHRoZSBmb2xsb3dpbmcgc2VxdWVuY2U6CisgICB0ZW0g PSBWRUNfUEVSTV9FWFBSIDxvcDAsIG9wMSwgbWFzazE+CisgICByZXMgPSBWRUNfUEVSTV9FWFBS IDx0ZW0sIHRlbSwgbWFzazI+CisKKyAgIERldGVybWluZSB3aGV0aGVyIGFwcGx5aW5nIHRoZSAy IHBlcm11dGF0aW9ucyAobWFzazEgdGhlbiBtYXNrMikKKyAgIGdpdmVzIGJhY2sgb25lIG9mIHRo ZSBpbnB1dC4gU0FNRV9QIHNwZWNpZmllcyB3aGV0aGVyIG9wMAorICAgYW5kIG9wMSBjb21wYXJl IGVxdWFsLiAgKi8KIAogc3RhdGljIGludAotaXNfY29tYmluZWRfcGVybXV0YXRpb25faWRlbnRp dHkgKHRyZWUgbWFzazEsIHRyZWUgbWFzazIpCitpc19jb21iaW5lZF9wZXJtdXRhdGlvbl9pZGVu dGl0eSAodHJlZSBtYXNrMSwgdHJlZSBtYXNrMiwgYm9vbCBzYW1lX3ApCiB7CiAgIHRyZWUgbWFz azsKICAgdW5zaWduZWQgSE9TVF9XSURFX0lOVCBuZWx0cywgaSwgajsKQEAgLTI1NDEsNiArMjU0 NiwyOSBAQCBpc19jb21iaW5lZF9wZXJtdXRhdGlvbl9pZGVudGl0eSAodHJlZSBtYXNrMSwgdHJl ZSBtYXNrMikKIAogICBnY2NfY2hlY2tpbmdfYXNzZXJ0IChUUkVFX0NPREUgKG1hc2sxKSA9PSBW RUNUT1JfQ1NUCiAJCSAgICAgICAmJiBUUkVFX0NPREUgKG1hc2syKSA9PSBWRUNUT1JfQ1NUKTsK KworICAvKiBGb3IgVkxBIG1hc2tzLCBjaGVjayBmb3IgdGhlIGZvbGxvd2luZyBwYXR0ZXJuOgor ICAgICB2MSA9IFZFQ19QRVJNX0VYUFIgKHYwLCB2MCwgbWFzazEpCisgICAgIHYyID0gVkVDX1BF Uk1fRVhQUiAodjEsIHYxLCBtYXNrMikKKyAgICAgLS0+CisgICAgIHYyID0gdjAKKyAgICAgaWYg bWFzazEgPT0gbWFzazIgPT0ge25lbHRzIC0gMSwgbmVsdHMgLSAyLCAuLi59LiAgKi8KKworICBp ZiAob3BlcmFuZF9lcXVhbF9wIChtYXNrMSwgbWFzazIsIDApCisgICAgICAmJiAhVkVDVE9SX0NT VF9ORUxUUyAobWFzazEpLmlzX2NvbnN0YW50ICgpCisgICAgICAmJiBzYW1lX3ApCisgICAgewor ICAgICAgdmVjX3Blcm1fYnVpbGRlciBidWlsZGVyOworICAgICAgaWYgKHRyZWVfdG9fdmVjX3Bl cm1fYnVpbGRlciAoJmJ1aWxkZXIsIG1hc2sxKSkKKwl7CisJICBwb2x5X3VpbnQ2NCBuZWx0cyA9 IFRZUEVfVkVDVE9SX1NVQlBBUlRTIChUUkVFX1RZUEUgKG1hc2sxKSk7CisJICB2ZWNfcGVybV9p bmRpY2VzIHNlbCAoYnVpbGRlciwgMSwgbmVsdHMpOworCSAgaWYgKHNlbC5zZXJpZXNfcCAoMCwg MSwgbmVsdHMgLSAxLCAtMSkpCisJICAgIHJldHVybiAxOworCX0KKyAgICAgIHJldHVybiAwOwor ICAgIH0KKwogICBtYXNrID0gZm9sZF90ZXJuYXJ5IChWRUNfUEVSTV9FWFBSLCBUUkVFX1RZUEUg KG1hc2sxKSwgbWFzazEsIG1hc2sxLCBtYXNrMik7CiAgIGlmIChtYXNrID09IE5VTExfVFJFRSB8 fCBUUkVFX0NPREUgKG1hc2spICE9IFZFQ1RPUl9DU1QpCiAgICAgcmV0dXJuIDA7CkBAIC0yNjI5 LDcgKzI2NTcsOSBAQCBzaW1wbGlmeV9wZXJtdXRhdGlvbiAoZ2ltcGxlX3N0bXRfaXRlcmF0b3Ig KmdzaSkKICAgICAgIG9wMyA9IGdpbXBsZV9hc3NpZ25fcmhzMyAoZGVmX3N0bXQpOwogICAgICAg aWYgKFRSRUVfQ09ERSAob3AzKSAhPSBWRUNUT1JfQ1NUKQogCXJldHVybiAwOwotICAgICAgaWRl bnQgPSBpc19jb21iaW5lZF9wZXJtdXRhdGlvbl9pZGVudGl0eSAob3AzLCBvcDIpOworICAgICAg Ym9vbCBzYW1lX3AgPSBvcGVyYW5kX2VxdWFsX3AgKGdpbXBsZV9hc3NpZ25fcmhzMSAoZGVmX3N0 bXQpLAorCQkJCSAgICAgZ2ltcGxlX2Fzc2lnbl9yaHMyIChkZWZfc3RtdCksIDApOworICAgICAg aWRlbnQgPSBpc19jb21iaW5lZF9wZXJtdXRhdGlvbl9pZGVudGl0eSAob3AzLCBvcDIsIHNhbWVf cCk7CiAgICAgICBpZiAoIWlkZW50KQogCXJldHVybiAwOwogICAgICAgb3JpZyA9IChpZGVudCA9 PSAxKSA/IGdpbXBsZV9hc3NpZ25fcmhzMSAoZGVmX3N0bXQpCg== --000000000000a6246105f9af7439--