From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 6F36A3858D35 for ; Thu, 22 Jun 2023 09:08:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6F36A3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-3f8fe9dc27aso54459585e9.3 for ; Thu, 22 Jun 2023 02:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687424888; x=1690016888; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AEN0jlw1gcSaiA+ylJfsxzdt6gifLmt2iWV/wBreXZk=; b=aqOmBoBIzzsBMULWaHHmW0WQinnaSncV0yn1Sw5vRcus8zIWKjKkagY0VYp/S7CRze 3ASbdLxM4rDL4efMj6mVFBBDaF4l/zGN44UDEdtEoA5iax5t9MCndHtO1MyUkDRH5u4O ITLIlT9L64+/wuGqq6OJecMAylbz3p2Jv8R/rv6iOHmv2EuGElD1Gf61JLkOTit3Lp1v 6pZ6DBVc9pRkCfb1ZsxIjR8bRhPa+0H2y+JUzwKsON+MDvOm65u6u+cn6q5ItJoNr08O c+Z89P3vxc1AdHTePU4KAIqpekR1J/UWU1ikCf7fG0WKL/ID8YaR+75MR61ebr7Azrmb Ez5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687424888; x=1690016888; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AEN0jlw1gcSaiA+ylJfsxzdt6gifLmt2iWV/wBreXZk=; b=Ssp/xWb19t5QGZ246cNxPoHmoKmwwgX7qu8xXlyVay/5Lztkll+Fop+3RWsylytJBg 4euGNUXKteyq2e6b2eRa/VcPrEpDbeLEBJW6wFCJIGb5qFXYApy9l/AxktAqVIz0Ok9p EEBV/8tEGGViU8i/uBW5X1GBoRdLZelufIf02+t1pHRzetEwAjrKsVi15ADesVoV7Xx3 Sld3aDWTZiM5mRuLjTbHthmRYw44YSm0luIPY6hQ/Nnu3CCympWizndPH1MC2doFfUNi OgKNtIo/f+6jXMpJUPclAnrRoFR/V8zTnTjBTIRHT4a03+JwbDbXWNf8OKM3UC43knnS mdqw== X-Gm-Message-State: AC+VfDzel3/3LE+k9NFwk+dmcAIgWiDUMW+XG8Smx7VHO8MJAzkSPU9e ken0KD65OOxgkHiqGm/w9shhVsTsHxYGyPOI6YLezg== X-Google-Smtp-Source: ACHHUZ4I4kp88r7DvF3jk2R3U0wC8BSdE7PEmg82iv86HV7B14Y2U/aKHHPWfjDijD3oPEiZxRg7zgJgtLakfgawYQs= X-Received: by 2002:a05:600c:2050:b0:3f9:b773:f8fc with SMTP id p16-20020a05600c205000b003f9b773f8fcmr5475789wmg.26.1687424887927; Thu, 22 Jun 2023 02:08:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Prathamesh Kulkarni Date: Thu, 22 Jun 2023 14:37:34 +0530 Message-ID: Subject: Re: [SVE][match.pd] Fix ICE observed in PR110280 To: Richard Biener Cc: gcc Patches , Richard Sandiford Content-Type: multipart/mixed; boundary="00000000000008058b05feb43904" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000008058b05feb43904 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 20 Jun 2023 at 16:47, Richard Biener w= rote: > > On Tue, Jun 20, 2023 at 11:56=E2=80=AFAM Prathamesh Kulkarni via Gcc-patc= hes > wrote: > > > > Hi Richard, > > For the following reduced test-case taken from PR: > > > > #include "arm_sve.h" > > svuint32_t l() { > > alignas(16) const unsigned int lanes[4] =3D {0, 0, 0, 0}; > > return svld1rq_u32(svptrue_b8(), lanes); > > } > > > > compiling with -O3 -mcpu=3Dgeneric+sve results in following ICE: > > during GIMPLE pass: fre > > pr110280.c: In function 'l': > > pr110280.c:5:1: internal compiler error: in eliminate_stmt, at > > tree-ssa-sccvn.cc:6890 > > 5 | } > > | ^ > > 0x865fb1 eliminate_dom_walker::eliminate_stmt(basic_block_def*, > > gimple_stmt_iterator*) > > ../../gcc/gcc/tree-ssa-sccvn.cc:6890 > > 0x120bf4d eliminate_dom_walker::before_dom_children(basic_block_def*) > > ../../gcc/gcc/tree-ssa-sccvn.cc:7324 > > 0x120bf4d eliminate_dom_walker::before_dom_children(basic_block_def*) > > ../../gcc/gcc/tree-ssa-sccvn.cc:7257 > > 0x1aeec77 dom_walker::walk(basic_block_def*) > > ../../gcc/gcc/domwalk.cc:311 > > 0x11fd924 eliminate_with_rpo_vn(bitmap_head*) > > ../../gcc/gcc/tree-ssa-sccvn.cc:7504 > > 0x1214664 do_rpo_vn_1 > > ../../gcc/gcc/tree-ssa-sccvn.cc:8616 > > 0x1215ba5 execute > > ../../gcc/gcc/tree-ssa-sccvn.cc:8702 > > > > cc1 simplifies: > > lanes[0] =3D 0; > > lanes[1] =3D 0; > > lanes[2] =3D 0; > > lanes[3] =3D 0; > > _1 =3D { -1, ... }; > > _7 =3D svld1rq_u32 (_1, &lanes); > > > > to: > > _9 =3D MEM [(unsigned int * {ref-all})&lanes= ]; > > _7 =3D VEC_PERM_EXPR <_9, _9, { 0, 1, 2, 3, ... }>; > > > > and then fre1 dump shows: > > Applying pattern match.pd:8675, generic-match-5.cc:9025 > > Match-and-simplified VEC_PERM_EXPR <_9, _9, { 0, 1, 2, 3, ... }> to { > > 0, 0, 0, 0 } > > RHS VEC_PERM_EXPR <_9, _9, { 0, 1, 2, 3, ... }> simplified to { 0, 0, 0= , 0 } > > > > The issue seems to be with the following pattern: > > (simplify > > (vec_perm vec_same_elem_p@0 @0 @1) > > @0) > > > > which simplifies above VEC_PERM_EXPR to: > > _7 =3D {0, 0, 0, 0} > > which is incorrect since _9 and mask have different vector lengths. > > > > The attached patch amends the pattern to simplify above VEC_PERM_EXPR > > only if operand and mask have same number of elements, which seems to f= ix > > the issue, and we're left with the following in .optimized dump: > > [local count: 1073741824]: > > _2 =3D VEC_PERM_EXPR <{ 0, 0, 0, 0 }, { 0, 0, 0, 0 }, { 0, 1, 2, 3, .= .. }>; > > it would be nice to have this optimized. > > - > (simplify > (vec_perm vec_same_elem_p@0 @0 @1) > - @0) > + (if (known_eq (TYPE_VECTOR_SUBPARTS (TREE_TYPE (@0)), > + TYPE_VECTOR_SUBPARTS (TREE_TYPE (@1)))) > + @0)) > > that looks good I think. Maybe even better use 'type' instead of TREE_TY= PE (@1) > since that's more obviously the return type in which case > > (if (types_match (type, TREE_TYPE (@0)) > > would be more to the point. > > But can't you to simplify this in the !known_eq case do a simple > > { build_vector_from_val (type, the-element); } > > ? The 'vec_same_elem_p' predicate doesn't get you at the element, > > (with { tree el =3D uniform_vector_p (@0); } > (if (el) > { build_vector_from_val (type, el); }))) > > would be the cheapest workaround. Hi Richard, Thanks for the suggestions. Using build_vector_from_val simplifies it to: [local count: 1073741824]: return { 0, ... }; Patch is bootstrapped+tested on aarch64-linux-gnu, in progress on x86_64-linux-gnu. OK to commit ? Thanks, Prathamesh > > > return _2; > > > > code-gen: > > l: > > mov z0.b, #0 > > ret > > > > Patch is bootstrapped+tested on aarch64-linux-gnu. > > OK to commit ? > > > > Thanks, > > Prathamesh --00000000000008058b05feb43904 Content-Type: text/plain; charset="US-ASCII"; name="pr110280-2.txt" Content-Disposition: attachment; filename="pr110280-2.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lj6x5ad40 W2FhcmNoNjQvbWF0Y2gucGRdIEZpeCBJQ0Ugb2JzZXJ2ZWQgaW4gUFIxMTAyODAuCgpnY2MvQ2hh bmdlTG9nOgoJUFIgdHJlZS1vcHRpbWl6YXRpb24vMTEwMjgwCgkqIG1hdGNoLnBkICh2ZWNfcGVy bV9leHByKHYsIHYsIG1hc2spIC0+IHYpOiBFeHBsaWNpdGx5IGJ1aWxkIHZlY3RvcgoJdXNpbmcg YnVpbGRfdmVjdG9yX2Zyb21fdmFsIHdpdGggdGhlIGVsZW1lbnQgb2YgaW5wdXQgb3BlcmFuZCwg YW5kCgltYXNrJ3MgdHlwZS4KCmdjYy90ZXN0c3VpdGUvQ2hhbmdlTG9nOgoJKiBnY2MudGFyZ2V0 L2FhcmNoNjQvc3ZlL3ByMTEwMjgwLmM6IE5ldyB0ZXN0LgoKZGlmZiAtLWdpdCBhL2djYy9tYXRj aC5wZCBiL2djYy9tYXRjaC5wZAppbmRleCAyZGQyMzgyNjAzNC4uNzZhMzcyOTdkM2MgMTAwNjQ0 Ci0tLSBhL2djYy9tYXRjaC5wZAorKysgYi9nY2MvbWF0Y2gucGQKQEAgLTg2NzIsNyArODY3Miwx MiBAQCBhbmQsCiAKIChzaW1wbGlmeQogICh2ZWNfcGVybSB2ZWNfc2FtZV9lbGVtX3BAMCBAMCBA MSkKLSBAMCkKKyAod2l0aAorICB7CisgICAgdHJlZSBlbGVtID0gdW5pZm9ybV92ZWN0b3JfcCAo QDApOworICB9CisgIChpZiAoZWxlbSkKKyAgIHsgYnVpbGRfdmVjdG9yX2Zyb21fdmFsICh0eXBl LCBlbGVtKTsgfSkpKQogCiAvKiBQdXNoIFZFQ19QRVJNIGVhcmxpZXIgaWYgdGhhdCBtYXkgaGVs cCBGTUEgcGVyY2VwdGlvbiAoUFIxMDE4OTUpLiAgKi8KIChzaW1wbGlmeQpkaWZmIC0tZ2l0IGEv Z2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FhcmNoNjQvc3ZlL3ByMTEwMjgwLmMgYi9nY2MvdGVz dHN1aXRlL2djYy50YXJnZXQvYWFyY2g2NC9zdmUvcHIxMTAyODAuYwpuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMC4uZDMyNzlmMzgzNjIKLS0tIC9kZXYvbnVsbAorKysgYi9n Y2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYWFyY2g2NC9zdmUvcHIxMTAyODAuYwpAQCAtMCwwICsx LDEyIEBACisvKiB7IGRnLWRvIGNvbXBpbGUgfSAqLworLyogeyBkZy1vcHRpb25zICItTzMgLWZk dW1wLXRyZWUtb3B0aW1pemVkIiB9ICovCisKKyNpbmNsdWRlICJhcm1fc3ZlLmgiCisKK3N2dWlu dDMyX3QgbCgpCit7CisgIF9BbGlnbmFzKDE2KSBjb25zdCB1bnNpZ25lZCBpbnQgbGFuZXNbNF0g PSB7MCwgMCwgMCwgMH07CisgIHJldHVybiBzdmxkMXJxX3UzMihzdnB0cnVlX2I4KCksIGxhbmVz KTsKK30KKworLyogeyBkZy1maW5hbCB7IHNjYW4tdHJlZS1kdW1wLW5vdCAiVkVDX1BFUk1fRVhQ UiIgIm9wdGltaXplZCIgfSB9ICovCg== --00000000000008058b05feb43904--