From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id BFDB33858436 for ; Mon, 27 Dec 2021 10:25:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFDB33858436 Received: by mail-ed1-x52e.google.com with SMTP id j6so59885551edw.12 for ; Mon, 27 Dec 2021 02:25:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=yNKBNbjVEelyVTigbcSsSOQaKpcEtRKBsFfNQzZevZE=; b=54eQGpXYc/2GTXXDP2CfQaA6roP1o9lhlgYxALYN/tzVWzW+H4gFIeWYP49PMKWxu0 VXKgyxVtknQEzJ8qE9xvZQtHsjnFs8O5yrvrd52KbevKeJfPjCXW8X9Kkt8PahZFXLSL wY0x+UMMfo9ICsS2lVgqh18pBA24iC6rMvOWROW0buHd+Woy4qE2G2YKyrHFAaHgon5l SVtDhYxmrzm4vICzSMiysVwmupTP/M2AwIVPbP07itzqkpTRKO7XzebvxvAfe35/r6qa 7JHfsOQuWvsltf8k7R5uDFKgqmWjaRJfruWEzxAPFPUovYl/zM0r0yoll6qoPMx8p+yg SOLg== X-Gm-Message-State: AOAM531/3RqvQhPrwn443M4xD9UvysLkKb62jFkEkvFRQEPIRuRej4i5 1nVfDnq/jpTwZ60JLXq5k1EKfpDrKi4gEQkcpVOX15B84W4= X-Google-Smtp-Source: ABdhPJyMHCoYIxpPsGPqwH+9i0XY8zLXmkMu3iSRi2wDB7SGCvEd5lcTLsn78rZmrEZ6IbZJu1R8Zo6lo4VF5UkF7Hs= X-Received: by 2002:a17:907:97ca:: with SMTP id js10mr13220881ejc.640.1640600735698; Mon, 27 Dec 2021 02:25:35 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Prathamesh Kulkarni Date: Mon, 27 Dec 2021 15:55:02 +0530 Message-ID: Subject: Re: [2/2] PR96463 -- changes to type checking vec_perm_expr in middle end To: Prathamesh Kulkarni , gcc Patches , Richard Biener , richard.sandiford@arm.com Content-Type: multipart/mixed; boundary="00000000000012126405d41e209a" X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Dec 2021 10:25:38 -0000 --00000000000012126405d41e209a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 17 Dec 2021 at 16:37, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch rearranges order of type-check for vec_perm_expr > > and relaxes type checking for > > lhs =3D vec_perm_expr > > > > when: > > rhs1 =3D=3D rhs2, > > lhs is variable length vector, > > rhs1 is fixed length vector, > > TREE_TYPE (lhs) =3D=3D TREE_TYPE (rhs1) > > > > I am not sure tho if this check is correct ? My intent was to capture > > case when vec_perm_expr is used to "extend" fixed length vector to > > it's VLA equivalent. > > VLAness isn't really the issue. We want the same thing to work for > -msve-vector-bits=3D256, -msve-vector-bits=3D512, etc., even though the > vectors are fixed-length in that case. > > The principle is that for: > > A =3D VEC_PERM_EXPR ; > > the requirements are: > > - A, B, C and D must be vectors > - A, B and C must have the same element type > - D must have an integer element type > - A and D must have the same number of elements (NA) > - B and C must have the same number of elements (NB) > > The semantics are that we create a joined vector BC (all elements of B > followed by all element of C) and that: > > A[i] =3D BC[D[i] % (NB+NB)] > > for 0 =E2=89=A4 i < NA. > > This operation makes sense even if NA !=3D NB. Thanks for the suggestions, I tried to modify the patch accordingly. Does it look OK ? Passes bootstrap+test on aarch64-linux-gnu. Thanks, Prathamesh > > Thanks, > Richard > > > > > Thanks, > > Prathamesh > > > > diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c > > index 672e384ef09..9f91878c468 100644 > > --- a/gcc/tree-cfg.c > > +++ b/gcc/tree-cfg.c > > @@ -4325,10 +4325,11 @@ verify_gimple_assign_ternary (gassign *stmt) > > break; > > > > case VEC_PERM_EXPR: > > - if (!useless_type_conversion_p (lhs_type, rhs1_type) > > - || !useless_type_conversion_p (lhs_type, rhs2_type)) > > + if (TREE_CODE (rhs1_type) !=3D VECTOR_TYPE > > + || TREE_CODE (rhs2_type) !=3D VECTOR_TYPE > > + || TREE_CODE (rhs3_type) !=3D VECTOR_TYPE) > > { > > - error ("type mismatch in %qs", code_name); > > + error ("vector types expected in %qs", code_name); > > debug_generic_expr (lhs_type); > > debug_generic_expr (rhs1_type); > > debug_generic_expr (rhs2_type); > > @@ -4336,11 +4337,14 @@ verify_gimple_assign_ternary (gassign *stmt) > > return true; > > } > > > > - if (TREE_CODE (rhs1_type) !=3D VECTOR_TYPE > > - || TREE_CODE (rhs2_type) !=3D VECTOR_TYPE > > - || TREE_CODE (rhs3_type) !=3D VECTOR_TYPE) > > + if (TREE_CODE (TREE_TYPE (rhs3_type)) !=3D INTEGER_TYPE > > + || (TREE_CODE (rhs3) !=3D VECTOR_CST > > + && (GET_MODE_BITSIZE (SCALAR_INT_TYPE_MODE > > + (TREE_TYPE (rhs3_type))) > > + !=3D GET_MODE_BITSIZE (SCALAR_TYPE_MODE > > + (TREE_TYPE (rhs1_type)))))) > > { > > - error ("vector types expected in %qs", code_name); > > + error ("invalid mask type in %qs", code_name); > > debug_generic_expr (lhs_type); > > debug_generic_expr (rhs1_type); > > debug_generic_expr (rhs2_type); > > @@ -4348,15 +4352,18 @@ verify_gimple_assign_ternary (gassign *stmt) > > return true; > > } > > > > - if (maybe_ne (TYPE_VECTOR_SUBPARTS (rhs1_type), > > - TYPE_VECTOR_SUBPARTS (rhs2_type)) > > - || maybe_ne (TYPE_VECTOR_SUBPARTS (rhs2_type), > > - TYPE_VECTOR_SUBPARTS (rhs3_type)) > > - || maybe_ne (TYPE_VECTOR_SUBPARTS (rhs3_type), > > - TYPE_VECTOR_SUBPARTS (lhs_type))) > > + /* Accept lhs =3D vec_perm_expr if lhs is vector len= gth agnostic, > > + and has same element type as v. */ > > + if (!TYPE_VECTOR_SUBPARTS (lhs_type).is_constant () > > + && operand_equal_p (rhs1, rhs2, 0) > > + && TYPE_VECTOR_SUBPARTS (rhs1_type).is_constant () > > + && TREE_TYPE (lhs_type) =3D=3D TREE_TYPE (rhs1_type)) > > + return false; > > + > > + if (!useless_type_conversion_p (lhs_type, rhs1_type) > > + || !useless_type_conversion_p (lhs_type, rhs2_type)) > > { > > - error ("vectors with different element number found in %qs", > > - code_name); > > + error ("type mismatch in %qs", code_name); > > debug_generic_expr (lhs_type); > > debug_generic_expr (rhs1_type); > > debug_generic_expr (rhs2_type); > > @@ -4364,21 +4371,21 @@ verify_gimple_assign_ternary (gassign *stmt) > > return true; > > } > > > > - if (TREE_CODE (TREE_TYPE (rhs3_type)) !=3D INTEGER_TYPE > > - || (TREE_CODE (rhs3) !=3D VECTOR_CST > > - && (GET_MODE_BITSIZE (SCALAR_INT_TYPE_MODE > > - (TREE_TYPE (rhs3_type))) > > - !=3D GET_MODE_BITSIZE (SCALAR_TYPE_MODE > > - (TREE_TYPE (rhs1_type)))))) > > + if (maybe_ne (TYPE_VECTOR_SUBPARTS (rhs1_type), > > + TYPE_VECTOR_SUBPARTS (rhs2_type)) > > + || maybe_ne (TYPE_VECTOR_SUBPARTS (rhs2_type), > > + TYPE_VECTOR_SUBPARTS (rhs3_type)) > > + || maybe_ne (TYPE_VECTOR_SUBPARTS (rhs3_type), > > + TYPE_VECTOR_SUBPARTS (lhs_type))) > > { > > - error ("invalid mask type in %qs", code_name); > > + error ("vectors with different element number found in %qs", > > + code_name); > > debug_generic_expr (lhs_type); > > debug_generic_expr (rhs1_type); > > debug_generic_expr (rhs2_type); > > debug_generic_expr (rhs3_type); > > return true; > > } > > - > > return false; > > > > case SAD_EXPR: --00000000000012126405d41e209a Content-Type: text/plain; charset="US-ASCII"; name="pr96463-4-midend.txt" Content-Disposition: attachment; filename="pr96463-4-midend.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kxoj7zac0 ZGlmZiAtLWdpdCBhL2djYy90cmVlLWNmZy5jIGIvZ2NjL3RyZWUtY2ZnLmMKaW5kZXggNjcyZTM4 NGVmMDkuLmFjYzgzNWM3N2NjIDEwMDY0NAotLS0gYS9nY2MvdHJlZS1jZmcuYworKysgYi9nY2Mv dHJlZS1jZmcuYwpAQCAtNDMyNSwxMCArNDMyNSwxMiBAQCB2ZXJpZnlfZ2ltcGxlX2Fzc2lnbl90 ZXJuYXJ5IChnYXNzaWduICpzdG10KQogICAgICAgYnJlYWs7CiAKICAgICBjYXNlIFZFQ19QRVJN X0VYUFI6Ci0gICAgICBpZiAoIXVzZWxlc3NfdHlwZV9jb252ZXJzaW9uX3AgKGxoc190eXBlLCBy aHMxX3R5cGUpCi0JICB8fCAhdXNlbGVzc190eXBlX2NvbnZlcnNpb25fcCAobGhzX3R5cGUsIHJo czJfdHlwZSkpCisgICAgICBpZiAoVFJFRV9DT0RFIChsaHNfdHlwZSkgIT0gVkVDVE9SX1RZUEUK KwkgIHx8IFRSRUVfQ09ERSAocmhzMV90eXBlKSAhPSBWRUNUT1JfVFlQRQorCSAgfHwgVFJFRV9D T0RFIChyaHMyX3R5cGUpICE9IFZFQ1RPUl9UWVBFCisJICB8fCBUUkVFX0NPREUgKHJoczNfdHlw ZSkgIT0gVkVDVE9SX1RZUEUpCiAJewotCSAgZXJyb3IgKCJ0eXBlIG1pc21hdGNoIGluICVxcyIs IGNvZGVfbmFtZSk7CisJICBlcnJvciAoInZlY3RvciB0eXBlcyBleHBlY3RlZCBpbiAlcXMiLCBj b2RlX25hbWUpOwogCSAgZGVidWdfZ2VuZXJpY19leHByIChsaHNfdHlwZSk7CiAJICBkZWJ1Z19n ZW5lcmljX2V4cHIgKHJoczFfdHlwZSk7CiAJICBkZWJ1Z19nZW5lcmljX2V4cHIgKHJoczJfdHlw ZSk7CkBAIC00MzM2LDExICs0MzM4LDE0IEBAIHZlcmlmeV9naW1wbGVfYXNzaWduX3Rlcm5hcnkg KGdhc3NpZ24gKnN0bXQpCiAJICByZXR1cm4gdHJ1ZTsKIAl9CiAKLSAgICAgIGlmIChUUkVFX0NP REUgKHJoczFfdHlwZSkgIT0gVkVDVE9SX1RZUEUKLQkgIHx8IFRSRUVfQ09ERSAocmhzMl90eXBl KSAhPSBWRUNUT1JfVFlQRQotCSAgfHwgVFJFRV9DT0RFIChyaHMzX3R5cGUpICE9IFZFQ1RPUl9U WVBFKQorICAgICAgaWYgKFRSRUVfQ09ERSAoVFJFRV9UWVBFIChyaHMzX3R5cGUpKSAhPSBJTlRF R0VSX1RZUEUKKwkgIHx8IChUUkVFX0NPREUgKHJoczMpICE9IFZFQ1RPUl9DU1QKKwkgICAgICAm JiAoR0VUX01PREVfQklUU0laRSAoU0NBTEFSX0lOVF9UWVBFX01PREUKKwkJCQkgICAgKFRSRUVf VFlQRSAocmhzM190eXBlKSkpCisJCSAgIT0gR0VUX01PREVfQklUU0laRSAoU0NBTEFSX1RZUEVf TU9ERQorCQkJCSAgICAgICAoVFJFRV9UWVBFIChyaHMxX3R5cGUpKSkpKSkKIAl7Ci0JICBlcnJv ciAoInZlY3RvciB0eXBlcyBleHBlY3RlZCBpbiAlcXMiLCBjb2RlX25hbWUpOworCSAgZXJyb3Ig KCJpbnZhbGlkIG1hc2sgdHlwZSBpbiAlcXMiLCBjb2RlX25hbWUpOwogCSAgZGVidWdfZ2VuZXJp Y19leHByIChsaHNfdHlwZSk7CiAJICBkZWJ1Z19nZW5lcmljX2V4cHIgKHJoczFfdHlwZSk7CiAJ ICBkZWJ1Z19nZW5lcmljX2V4cHIgKHJoczJfdHlwZSk7CkBAIC00MzQ4LDE1ICs0MzUzLDIzIEBA IHZlcmlmeV9naW1wbGVfYXNzaWduX3Rlcm5hcnkgKGdhc3NpZ24gKnN0bXQpCiAJICByZXR1cm4g dHJ1ZTsKIAl9CiAKLSAgICAgIGlmIChtYXliZV9uZSAoVFlQRV9WRUNUT1JfU1VCUEFSVFMgKHJo czFfdHlwZSksCi0JCSAgICBUWVBFX1ZFQ1RPUl9TVUJQQVJUUyAocmhzMl90eXBlKSkKLQkgIHx8 IG1heWJlX25lIChUWVBFX1ZFQ1RPUl9TVUJQQVJUUyAocmhzMl90eXBlKSwKLQkJICAgICAgIFRZ UEVfVkVDVE9SX1NVQlBBUlRTIChyaHMzX3R5cGUpKQotCSAgfHwgbWF5YmVfbmUgKFRZUEVfVkVD VE9SX1NVQlBBUlRTIChyaHMzX3R5cGUpLAotCQkgICAgICAgVFlQRV9WRUNUT1JfU1VCUEFSVFMg KGxoc190eXBlKSkpCisgICAgICAvKiBJZiBsaHMgYW5kIHJocyBoYXZlIGRpZmZlcmVudCB0eXBl cywgY2hlY2sgdGhhdDoKKyAgICAgICAgIChhKSBFbGVtZW50cyBoYXZlIHNhbWUgdHlwZS4KKwkg KGIpIGxocyBsZW5ndGggPT0gcmhzMyBsZW5ndGguCisJIChjKSByaHMxIGxlbmd0aCA9PSByaHMy IGxlbmd0aC4gICovCisKKyAgICAgIGlmICghKHR5cGVzX2NvbXBhdGlibGVfcCAobGhzX3R5cGUs IHJoczFfdHlwZSkKKwkgICAgJiYgdHlwZXNfY29tcGF0aWJsZV9wIChsaHNfdHlwZSwgcmhzMl90 eXBlKSkKKwkgICYmIFRSRUVfVFlQRSAobGhzX3R5cGUpID09IFRSRUVfVFlQRSAocmhzMV90eXBl KQorCSAgJiYgVFJFRV9UWVBFIChsaHNfdHlwZSkgPT0gVFJFRV9UWVBFIChyaHMyX3R5cGUpCisJ ICAmJiBrbm93bl9lcSAoVFlQRV9WRUNUT1JfU1VCUEFSVFMgKGxoc190eXBlKSwgVFlQRV9WRUNU T1JfU1VCUEFSVFMgKHJoczNfdHlwZSkpCisJICAmJiBrbm93bl9lcSAoVFlQRV9WRUNUT1JfU1VC UEFSVFMgKHJoczFfdHlwZSksIFRZUEVfVkVDVE9SX1NVQlBBUlRTIChyaHMyX3R5cGUpKSkKKwly ZXR1cm4gZmFsc2U7CisKKyAgICAgIGlmICghdXNlbGVzc190eXBlX2NvbnZlcnNpb25fcCAobGhz X3R5cGUsIHJoczFfdHlwZSkKKwkgIHx8ICF1c2VsZXNzX3R5cGVfY29udmVyc2lvbl9wIChsaHNf dHlwZSwgcmhzMl90eXBlKSkKIAl7Ci0JICBlcnJvciAoInZlY3RvcnMgd2l0aCBkaWZmZXJlbnQg ZWxlbWVudCBudW1iZXIgZm91bmQgaW4gJXFzIiwKLQkJIGNvZGVfbmFtZSk7CisJICBlcnJvciAo InR5cGUgbWlzbWF0Y2ggaW4gJXFzIiwgY29kZV9uYW1lKTsKIAkgIGRlYnVnX2dlbmVyaWNfZXhw ciAobGhzX3R5cGUpOwogCSAgZGVidWdfZ2VuZXJpY19leHByIChyaHMxX3R5cGUpOwogCSAgZGVi dWdfZ2VuZXJpY19leHByIChyaHMyX3R5cGUpOwpAQCAtNDM2NCwxNCArNDM3NywxNSBAQCB2ZXJp ZnlfZ2ltcGxlX2Fzc2lnbl90ZXJuYXJ5IChnYXNzaWduICpzdG10KQogCSAgcmV0dXJuIHRydWU7 CiAJfQogCi0gICAgICBpZiAoVFJFRV9DT0RFIChUUkVFX1RZUEUgKHJoczNfdHlwZSkpICE9IElO VEVHRVJfVFlQRQotCSAgfHwgKFRSRUVfQ09ERSAocmhzMykgIT0gVkVDVE9SX0NTVAotCSAgICAg ICYmIChHRVRfTU9ERV9CSVRTSVpFIChTQ0FMQVJfSU5UX1RZUEVfTU9ERQotCQkJCSAgICAoVFJF RV9UWVBFIChyaHMzX3R5cGUpKSkKLQkJICAhPSBHRVRfTU9ERV9CSVRTSVpFIChTQ0FMQVJfVFlQ RV9NT0RFCi0JCQkJICAgICAgIChUUkVFX1RZUEUgKHJoczFfdHlwZSkpKSkpKQorICAgICAgaWYg KG1heWJlX25lIChUWVBFX1ZFQ1RPUl9TVUJQQVJUUyAocmhzMV90eXBlKSwKKwkJICAgIFRZUEVf VkVDVE9SX1NVQlBBUlRTIChyaHMyX3R5cGUpKQorCSAgfHwgbWF5YmVfbmUgKFRZUEVfVkVDVE9S X1NVQlBBUlRTIChyaHMyX3R5cGUpLAorCQkgICAgICAgVFlQRV9WRUNUT1JfU1VCUEFSVFMgKHJo czNfdHlwZSkpCisJICB8fCBtYXliZV9uZSAoVFlQRV9WRUNUT1JfU1VCUEFSVFMgKHJoczNfdHlw ZSksCisJCSAgICAgICBUWVBFX1ZFQ1RPUl9TVUJQQVJUUyAobGhzX3R5cGUpKSkKIAl7Ci0JICBl cnJvciAoImludmFsaWQgbWFzayB0eXBlIGluICVxcyIsIGNvZGVfbmFtZSk7CisJICBlcnJvciAo InZlY3RvcnMgd2l0aCBkaWZmZXJlbnQgZWxlbWVudCBudW1iZXIgZm91bmQgaW4gJXFzIiwKKwkJ IGNvZGVfbmFtZSk7CiAJICBkZWJ1Z19nZW5lcmljX2V4cHIgKGxoc190eXBlKTsKIAkgIGRlYnVn X2dlbmVyaWNfZXhwciAocmhzMV90eXBlKTsKIAkgIGRlYnVnX2dlbmVyaWNfZXhwciAocmhzMl90 eXBlKTsK --00000000000012126405d41e209a--