From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 64CF63858402 for ; Mon, 18 Oct 2021 11:21:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64CF63858402 Received: by mail-ed1-x52f.google.com with SMTP id g10so69803750edj.1 for ; Mon, 18 Oct 2021 04:21:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=U88QgWT7qtKMhwpxRdDiLj+HWpjPTAell7gDs/t0qvA=; b=r2M68uW5WRWio8T+crofUVeq+aDqZMX2cNaL52uGILTHkvonltivsFlskebWWSNjL0 SpmwqCTx+cd7U7a5ObgvcCCAT1kQMJTOpz584c7ymlZlVlspeZ2fyj0E/BCaMIXeWOS/ Rti5L9/MdT51Us/mP4heLqBgNVB2jOCrpF4aFcMykTyv7t+MyhANKgDP06lPQraJOdfj 6EE9WnibjPSCMsrk3il7a9Zsse/H67GsZhh/QmzKNZ/UymYJohBc0H3xfwxuV6jqhmdu EJ+5XVhzlG6KkPX3iwVg2qMaDkg4GxEzhBvPgZA5EmFvuQ8BWiwey0hEZmp0csh3DU/J WQFQ== X-Gm-Message-State: AOAM530YejB7byHe+6GqwlpslABLlF9vrGE8FTes5uBfJdNq2AJnH5v5 KeyEoRfS2fAcATkxiVIntZX+UbbQ7mCEotT7HrCegJwaZT5g1g== X-Google-Smtp-Source: ABdhPJwSSBW75Gia0O8nNtYYzAWn0mbU7Bmz+DdaBi9RRDuOJ6CrTFMvvZBrOZUpc4g4UDjc8XY2iO8mps564Ka0ZaI= X-Received: by 2002:a17:906:a08d:: with SMTP id q13mr28490249ejy.465.1634556100129; Mon, 18 Oct 2021 04:21:40 -0700 (PDT) MIME-Version: 1.0 From: Prathamesh Kulkarni Date: Mon, 18 Oct 2021 16:51:03 +0530 Message-ID: Subject: [aarch64] PR102376 - Emit better diagnostic for arch extensions in target attr To: gcc Patches , =?UTF-8?Q?Martin_Li=C5=A1ka?= , Richard Sandiford Content-Type: multipart/mixed; boundary="000000000000b713c905ce9ebfe9" X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2021 11:21:43 -0000 --000000000000b713c905ce9ebfe9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, The attached patch emits a more verbose diagnostic for target attribute tha= t is an architecture extension needing a leading '+'. For the following test, void calculate(void) __attribute__ ((__target__ ("sve"))); With patch, the compiler now emits: 102376.c:1:1: error: arch extension =E2=80=98sve=E2=80=99 should be prepend= ed with =E2=80=98+=E2=80=99 1 | void calculate(void) __attribute__ ((__target__ ("sve"))); | ^~~~ instead of: 102376.c:1:1: error: pragma or attribute =E2=80=98target("sve")=E2=80=99 is= not valid 1 | void calculate(void) __attribute__ ((__target__ ("sve"))); | ^~~~ (This isn't specific to sve though). OK to commit after bootstrap+test ? Thanks, Prathamesh --000000000000b713c905ce9ebfe9 Content-Type: text/plain; charset="US-ASCII"; name="102376-1.txt" Content-Disposition: attachment; filename="102376-1.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kuwk2w8v0 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LmMgYi9nY2MvY29uZmlnL2Fh cmNoNjQvYWFyY2g2NC5jCmluZGV4IGE5YTE4MDBhZjUzLi45NzVmN2ZhZjk2OCAxMDA2NDQKLS0t IGEvZ2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQuYworKysgYi9nY2MvY29uZmlnL2FhcmNoNjQv YWFyY2g2NC5jCkBAIC0xNzgyMSw3ICsxNzgyMSwxNiBAQCBhYXJjaDY0X3Byb2Nlc3NfdGFyZ2V0 X2F0dHIgKHRyZWUgYXJncykKICAgICAgIG51bV9hdHRycysrOwogICAgICAgaWYgKCFhYXJjaDY0 X3Byb2Nlc3Nfb25lX3RhcmdldF9hdHRyICh0b2tlbikpCiAJewotCSAgZXJyb3IgKCJwcmFnbWEg b3IgYXR0cmlidXRlICU8dGFyZ2V0KFwiJXNcIiklPiBpcyBub3QgdmFsaWQiLCB0b2tlbik7CisJ ICAvKiBDaGVjayBpZiB0b2tlbiBpcyBwb3NzaWJseSBhbiBhcmNoIGV4dGVuc2lvbiB3aXRob3V0 CisJICAgICBsZWFkaW5nICcrJy4gICovCisJICBjaGFyICpzdHIgPSAoY2hhciAqKSB4bWFsbG9j IChzdHJsZW4gKHRva2VuKSArIDIpOworCSAgc3RyWzBdID0gJysnOworCSAgc3RyY3B5KHN0ciAr IDEsIHRva2VuKTsKKwkgIGlmIChhYXJjaDY0X2hhbmRsZV9hdHRyX2lzYV9mbGFncyAoc3RyKSkK KwkgICAgZXJyb3IoImFyY2ggZXh0ZW5zaW9uICU8JXMlPiBzaG91bGQgYmUgcHJlcGVuZGVkIHdp dGggJTwrJT4iLCB0b2tlbik7CisJICBlbHNlCisJICAgIGVycm9yICgicHJhZ21hIG9yIGF0dHJp YnV0ZSAlPHRhcmdldChcIiVzXCIpJT4gaXMgbm90IHZhbGlkIiwgdG9rZW4pOworCSAgZnJlZSAo c3RyKTsKIAkgIHJldHVybiBmYWxzZTsKIAl9CiAK --000000000000b713c905ce9ebfe9--