[Patch] Missing plugin header files

[Patch] Missing plugin header files

[Steve Ellcey]

I tried compiling an empty plugin that just included gcc-plugin.h and
plugin-version.h and found that these header files were included from
gcc-plugin.h but not in the list of header files to be copied to the
plugin include directory.

OK to checkin?

Steve Ellcey
sellcey@imgtec.com

2015-01-14  Steve Ellcey  <sellcey@mips.com>

	* Makefile.in (PLUGIN_HEADERS): Add dominance.h, cfg.h, cfgrtl.h,
	cfganal.h, cfgbuild.h, cfgcleanup.h, lcm.h, builtins.def,
	chkp-builtins.def, and pass-instances.def


diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 44a4214..abe2d0d 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -3228,7 +3228,8 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \
   tree-ssa-loop.h tree-ssa-loop-ivopts.h tree-ssa-loop-manip.h \
   tree-ssa-loop-niter.h tree-ssa-ter.h tree-ssa-threadedge.h \
   tree-ssa-threadupdate.h inchash.h wide-int.h signop.h hash-map.h \
-  hash-set.h pass-instances.def
+  hash-set.h dominance.h cfg.h cfgrtl.h cfganal.h cfgbuild.h cfgcleanup.h \
+  lcm.h builtins.def chkp-builtins.def pass-instances.def
 
 # generate the 'build fragment' b-header-vars
 s-header-vars: Makefile

Re: [Patch] Missing plugin header files

[Richard Biener]

On Wed, Jan 14, 2015 at 10:43 PM, Steve Ellcey <sellcey@imgtec.com> wrote:
> I tried compiling an empty plugin that just included gcc-plugin.h and
> plugin-version.h and found that these header files were included from
> gcc-plugin.h but not in the list of header files to be copied to the
> plugin include directory.
>
> OK to checkin?

Ok.

Thanks,
Richard.

> Steve Ellcey
> sellcey@imgtec.com
>
> 2015-01-14  Steve Ellcey  <sellcey@mips.com>
>
>         * Makefile.in (PLUGIN_HEADERS): Add dominance.h, cfg.h, cfgrtl.h,
>         cfganal.h, cfgbuild.h, cfgcleanup.h, lcm.h, builtins.def,
>         chkp-builtins.def, and pass-instances.def
>
>
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index 44a4214..abe2d0d 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -3228,7 +3228,8 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \
>    tree-ssa-loop.h tree-ssa-loop-ivopts.h tree-ssa-loop-manip.h \
>    tree-ssa-loop-niter.h tree-ssa-ter.h tree-ssa-threadedge.h \
>    tree-ssa-threadupdate.h inchash.h wide-int.h signop.h hash-map.h \
> -  hash-set.h pass-instances.def
> +  hash-set.h dominance.h cfg.h cfgrtl.h cfganal.h cfgbuild.h cfgcleanup.h \
> +  lcm.h builtins.def chkp-builtins.def pass-instances.def
>
>  # generate the 'build fragment' b-header-vars
>  s-header-vars: Makefile

Re: [Patch] Missing plugin header files

[Prathamesh Kulkarni]

On 15 January 2015 at 14:14, Richard Biener <richard.guenther@gmail.com> wrote:
> On Wed, Jan 14, 2015 at 10:43 PM, Steve Ellcey <sellcey@imgtec.com> wrote:
>> I tried compiling an empty plugin that just included gcc-plugin.h and
>> plugin-version.h and found that these header files were included from
>> gcc-plugin.h but not in the list of header files to be copied to the
>> plugin include directory.
>>
>> OK to checkin?
>
> Ok.
>
> Thanks,
> Richard.
>
>> Steve Ellcey
>> sellcey@imgtec.com
>>
>> 2015-01-14  Steve Ellcey  <sellcey@mips.com>
>>
>>         * Makefile.in (PLUGIN_HEADERS): Add dominance.h, cfg.h, cfgrtl.h,
>>         cfganal.h, cfgbuild.h, cfgcleanup.h, lcm.h, builtins.def,
>>         chkp-builtins.def, and pass-instances.def
>>
Should pass-instances.def be removed from ChangeLog since it was
already present in PLUGIN_HEADERS ?

Thanks,
Prathamesh
>>
>> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
>> index 44a4214..abe2d0d 100644
>> --- a/gcc/Makefile.in
>> +++ b/gcc/Makefile.in
>> @@ -3228,7 +3228,8 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $(SYSTEM_H) coretypes.h $(TM_H) \
>>    tree-ssa-loop.h tree-ssa-loop-ivopts.h tree-ssa-loop-manip.h \
>>    tree-ssa-loop-niter.h tree-ssa-ter.h tree-ssa-threadedge.h \
>>    tree-ssa-threadupdate.h inchash.h wide-int.h signop.h hash-map.h \
>> -  hash-set.h pass-instances.def
>> +  hash-set.h dominance.h cfg.h cfgrtl.h cfganal.h cfgbuild.h cfgcleanup.h \
>> +  lcm.h builtins.def chkp-builtins.def pass-instances.def
>>
>>  # generate the 'build fragment' b-header-vars
>>  s-header-vars: Makefile

Re: [Patch] Missing plugin header files

[Steve Ellcey]

> >>
> >> 2015-01-14  Steve Ellcey  <sellcey@mips.com>
> >>
> >>         * Makefile.in (PLUGIN_HEADERS): Add dominance.h, cfg.h, cfgrtl.h,
> >>         cfganal.h, cfgbuild.h, cfgcleanup.h, lcm.h, builtins.def,
> >>         chkp-builtins.def, and pass-instances.def
> >>
> Should pass-instances.def be removed from ChangeLog since it was
> already present in PLUGIN_HEADERS ?
> 
> Thanks,
> Prathamesh

Looks like a cut-n-paste error on my part when I copied the file names
from Makefile.in to ChangeLog.  I will fix the ChangeLog entry.

Steve Ellcey

Re: [Patch] Missing plugin header files

[Prathamesh Kulkarni]

On 16 January 2015 at 00:00, Steve Ellcey <sellcey@imgtec.com> wrote:
>
>> >>
>> >> 2015-01-14  Steve Ellcey  <sellcey@mips.com>
>> >>
>> >>         * Makefile.in (PLUGIN_HEADERS): Add dominance.h, cfg.h, cfgrtl.h,
>> >>         cfganal.h, cfgbuild.h, cfgcleanup.h, lcm.h, builtins.def,
>> >>         chkp-builtins.def, and pass-instances.def
>> >>
>> Should pass-instances.def be removed from ChangeLog since it was
>> already present in PLUGIN_HEADERS ?
>>
>> Thanks,
>> Prathamesh
>
> Looks like a cut-n-paste error on my part when I copied the file names
> from Makefile.in to ChangeLog.  I will fix the ChangeLog entry.
Thanks for the patch, I missed to put headers in PLUGIN_HEADERS
after putting includes in gcc-plugin.h. -:(

Regards,
Prathamesh
>
> Steve Ellcey
>