From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116456 invoked by alias); 14 May 2018 09:33:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 113685 invoked by uid 89); 14 May 2018 09:33:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=noreturn X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 May 2018 09:33:08 +0000 Received: by mail-wr0-f182.google.com with SMTP id o4-v6so11545941wrm.0 for ; Mon, 14 May 2018 02:33:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fh9yKFf32CsvzwDBIm+STLRqbd4LnBRK4X7waj5eyL0=; b=K5+dLieiL8CwAcCBXmoInROtAdNtO6TU1D3RKgsQ+zcJsCwM3A9p+7+a70AY/6rUeN GNBmJRadSM06oNvnwDsT+ce6s6agiQ4epQm8MnWGiIDJpVpAjUbrHW2/uN1acuRcqhbm B2ZYYOyqNGkhwK79kwtreF12vqm4kNuRpQioQ0VGEsJPh4Te3ZWEIxOR41ULSQ0WBbEy 7mWzJ0m9MUXowHe/JJBvCr0a+0b1PBUDIwL30va6WY2Opp0zPVVT1FRbF0462lklBI21 P/BMSWpr8LpehCFJ+JxzSrhafsbvx1aUe5OT5Wv9t2Hgk3sSAfzS6VRlAh7+Z4UjJHNR MSCw== X-Gm-Message-State: ALKqPwfhcKSZm8r7bByu1TH2vPUpv5+Z44dGmrZ6Cj3JoQ6qNBKmiP94 TykleAm7sdUWsE+FFxhLavhP1JxBnYfK1eU4YEHenA== X-Google-Smtp-Source: AB8JxZrWXfS2DhBu4l4T9dr8o582vgpbnxfkrPw7x8x9NsVbmUy9HsEyHfzjz72UnFBLct5Xvs+TT5hdumr9G/809k4= X-Received: by 2002:adf:af28:: with SMTP id z37-v6mr6273631wrc.72.1526290386800; Mon, 14 May 2018 02:33:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.222.16 with HTTP; Mon, 14 May 2018 02:33:06 -0700 (PDT) In-Reply-To: References: From: Prathamesh Kulkarni Date: Mon, 14 May 2018 09:36:00 -0000 Message-ID: Subject: Re: PR85734 To: Richard Biener Cc: gcc Patches , Jan Hubicka Content-Type: multipart/mixed; boundary="000000000000548b2d056c272c34" X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00597.txt.bz2 --000000000000548b2d056c272c34 Content-Type: text/plain; charset="UTF-8" Content-length: 832 On 14 May 2018 at 14:46, Richard Biener wrote: > On Mon, 14 May 2018, Prathamesh Kulkarni wrote: > >> Hi, >> The attached patch tries to fix PR85734, by gating on >> !function_always_visible_to_compiler_p. >> Bootstrap+test in progress on x86_64. >> OK to commit if passes ? > > This looks redundant - suggest_attribute does that very same check > but warn_function_malloc passes it 'false' as known_finite > (warn_function_noreturn passes it true for example). Indeed, thanks for pointing it out. > > So I suggest to simply pass true as that arg. Is the attached version OK to commit after bootstrap+test ? Thanks, Prathamesh > > Richard > >> Thanks, >> Prathamesh >> > > -- > Richard Biener > SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) --000000000000548b2d056c272c34 Content-Type: text/plain; charset="US-ASCII"; name="pr85734-3.txt" Content-Disposition: attachment; filename="pr85734-3.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jh61scw70 Content-length: 1985 MjAxOC0wNS0xNCAgUHJhdGhhbWVzaCBLdWxrYXJuaSAgPHByYXRoYW1lc2gu a3Vsa2FybmlAbGluYXJvLm9yZz4KCglQUiBpcGEvODU3MzQKCSogaXBhLXB1 cmUtY29uc3QuYyAod2Fybl9mdW5jdGlvbl9tYWxsb2MpOiBQYXNzIHZhbHVl IG9mIGtub3duX2Zpbml0ZSBwYXJhbQoJYXMgdHJ1ZSBpbiBjYWxsIHRvIHN1 Z2dlc3RfYXR0cmlidXRlLgoKdGVzdHN1aXRlLwoJKiBnY2MuZGcvaXBhL3By ODU3MzQuYzogTmV3IHRlc3QuCgpkaWZmIC0tZ2l0IGEvZ2NjL2lwYS1wdXJl LWNvbnN0LmMgYi9nY2MvaXBhLXB1cmUtY29uc3QuYwppbmRleCBhODBiNjg0 NTYzMy4uNzY2NTM1OGE5YTUgMTAwNjQ0Ci0tLSBhL2djYy9pcGEtcHVyZS1j b25zdC5jCisrKyBiL2djYy9pcGEtcHVyZS1jb25zdC5jCkBAIC0yNDksNyAr MjQ5LDcgQEAgd2Fybl9mdW5jdGlvbl9tYWxsb2MgKHRyZWUgZGVjbCkKICAg c3RhdGljIGhhc2hfc2V0PHRyZWU+ICp3YXJuZWRfYWJvdXQ7CiAgIHdhcm5l ZF9hYm91dAogICAgID0gc3VnZ2VzdF9hdHRyaWJ1dGUgKE9QVF9Xc3VnZ2Vz dF9hdHRyaWJ1dGVfbWFsbG9jLCBkZWNsLAotCQkJIGZhbHNlLCB3YXJuZWRf YWJvdXQsICJtYWxsb2MiKTsKKwkJCSB0cnVlLCB3YXJuZWRfYWJvdXQsICJt YWxsb2MiKTsKIH0KIAogLyogRW1pdCBzdWdnZXN0aW9uIGFib3V0IF9fYXR0 cmlidXRlX18oKG5vcmV0dXJuKSkgZm9yIERFQ0wuICAqLwpkaWZmIC0tZ2l0 IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvaXBhL3ByODU3MzQuYyBiL2djYy90 ZXN0c3VpdGUvZ2NjLmRnL2lwYS9wcjg1NzM0LmMKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLmU1ZmEyMWYwNTQ4Ci0tLSAvZGV2 L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvaXBhL3ByODU3MzQu YwpAQCAtMCwwICsxLDE5IEBACisvKiB7IGRnLWRvIGNvbXBpbGUgfSAqLwor LyogeyBkZy1vcHRpb25zICItTzIgLVdzdWdnZXN0LWF0dHJpYnV0ZT1tYWxs b2MiIH0gKi8KKworX19hdHRyaWJ1dGVfXygobm9pbmxpbmUpKQorc3RhdGlj IHZvaWQgKmYxKF9fU0laRV9UWVBFX18gc3opIC8qIHsgZGctYm9ndXMgImZ1 bmN0aW9uIG1pZ2h0IGJlIGNhbmRpZGF0ZSBmb3IgYXR0cmlidXRlICdtYWxs b2MnIiB9ICovCit7CisgIHJldHVybiBfX2J1aWx0aW5fbWFsbG9jIChzeik7 Cit9CisKK19fYXR0cmlidXRlX18oKG5vaW5saW5lKSkKK3N0YXRpYyB2b2lk ICpmMihfX1NJWkVfVFlQRV9fIHN6KSAvKiB7IGRnLWJvZ3VzICJmdW5jdGlv biBtaWdodCBiZSBjYW5kaWRhdGUgZm9yIGF0dHJpYnV0ZSAnbWFsbG9jJyIg fSAqLworeworICByZXR1cm4gZjEgKHN6KTsKK30KKwordm9pZCAqZjMoX19T SVpFX1RZUEVfXyBzeikgLyogeyBkZy13YXJuaW5nICJmdW5jdGlvbiBtaWdo dCBiZSBjYW5kaWRhdGUgZm9yIGF0dHJpYnV0ZSAnbWFsbG9jJyIgfSAqLwor eworICByZXR1cm4gZjIoc3opOworfQo= --000000000000548b2d056c272c34--