From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129620 invoked by alias); 9 Jun 2016 20:18:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 129611 invoked by uid 89); 9 Jun 2016 20:18:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=varpool_node, sk:SYMBOL_, Seems, a.e X-HELO: mail-io0-f172.google.com Received: from mail-io0-f172.google.com (HELO mail-io0-f172.google.com) (209.85.223.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 09 Jun 2016 20:18:26 +0000 Received: by mail-io0-f172.google.com with SMTP id m62so48392245iof.0 for ; Thu, 09 Jun 2016 13:18:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0l1E/y5bW/QJIEi2SjYrCUt+m1Njmrybf0qS7x2PS/0=; b=a6xOvgNbVxImEDAEIREGaGQx9ay3c8g6vsDyqMDZk3pacFb0AvodpYHMovYPPNyda5 bYPU2TeuVHDx/Jypl/bT9fB1ykOR/JHFw6zsRqHiLrH7ygLWLFLoqf84pxvSByh+qdTK nFH4UZuHGcLK3PH8K3CHTC711zoYCIRC/zxf1omHtaCK2XbzOjKnXFmEJRb3UGKdbnia AIadRe4e8S0J5LYs+imI5R329guQxgLEIx4h59I2l7dJTkaOrKVU3ApO7QSR/UhBIN+t aisBM9exgc8bIV4+fCLiUG0cgBJ1/dQrJyB4++B3pUs9pWI0pWXfUZTjbcqQN0vnuruw ZNOQ== X-Gm-Message-State: ALyK8tJWopxkrMLUYdEc+OIjqB146Cf/yWwDucVzRxwbgdsgSuw47mEIEPreOMx03jYUOVOnm5gH9x+dgVZvUnvn X-Received: by 10.107.130.195 with SMTP id m64mr2802989ioi.137.1465503504135; Thu, 09 Jun 2016 13:18:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.48.133 with HTTP; Thu, 9 Jun 2016 13:18:23 -0700 (PDT) In-Reply-To: <20160608150855.GB2550@atrey.karlin.mff.cuni.cz> References: <20160602150106.GA48112@kam.mff.cuni.cz> <20160603080543.GA78035@kam.mff.cuni.cz> <20160608150855.GB2550@atrey.karlin.mff.cuni.cz> From: Prathamesh Kulkarni Date: Thu, 09 Jun 2016 20:18:00 -0000 Message-ID: Subject: Re: move increase_alignment from simple to regular ipa pass To: Jan Hubicka Cc: Richard Biener , David Edelsohn , GCC Patches , "William J. Schmidt" , Segher Boessenkool Content-Type: multipart/mixed; boundary=001a113eb1d4c8b0e30534de1f59 X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00747.txt.bz2 --001a113eb1d4c8b0e30534de1f59 Content-Type: text/plain; charset=UTF-8 Content-length: 1470 On 8 June 2016 at 20:38, Jan Hubicka wrote: >> I think it would be nice to work towards transitioning >> flag_section_anchors to a flag on varpool nodes, thereby removing >> the Optimization flag from common.opt:fsection-anchors >> >> That would simplify the walk over varpool candidates. > > Makes sense to me, too. There are more candidates for sutff that should be > variable specific in common.opt (such as variable alignment, -fdata-sctions, > -fmerge-constants) and targets. We may try to do it in an easy to extend way > so incrementally we can get rid of those global flags, too. In this version I removed Optimization from fsection-anchors entry in common.opt, and gated the increase_alignment pass on flag_section_anchors != 0. Cross tested on arm*-*-*, aarch64*-*-*. Does it look OK ? > > One thing that needs to be done for LTO is sane merging, I guess in this case > it is clear that the variable should be anchored when its previaling definition > is. Um could we determine during WPA if symbol is a section anchor for merging ? Seems to me SYMBOL_REF_ANCHOR_P is defined only on DECL_RTL and not at tree level. Do we have DECL_RTL info available during WPA ? Thanks, Prathamesh > > Honza >> >> Richard. >> >> > Thanks, >> > Prathamesh >> > > >> > > Honza >> > >> >> > >> Richard. >> > >> > >> >> -- >> Richard Biener >> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg) --001a113eb1d4c8b0e30534de1f59 Content-Type: text/plain; charset=US-ASCII; name="ias2r-5.diff" Content-Disposition: attachment; filename="ias2r-5.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ip8qvys80 Content-length: 8093 ZGlmZiAtLWdpdCBhL2djYy9jb21tb24ub3B0IGIvZ2NjL2NvbW1vbi5vcHQK aW5kZXggZjBkNzE5Ni4uZjkzZjI2YyAxMDA2NDQKLS0tIGEvZ2NjL2NvbW1v bi5vcHQKKysrIGIvZ2NjL2NvbW1vbi5vcHQKQEAgLTIxMzMsNyArMjEzMyw3 IEBAIENvbW1vbiBSZXBvcnQgVmFyKGZsYWdfc2NoZWRfZGVwX2NvdW50X2hl dXJpc3RpYykgSW5pdCgxKSBPcHRpbWl6YXRpb24KIEVuYWJsZSB0aGUgZGVw ZW5kZW50IGNvdW50IGhldXJpc3RpYyBpbiB0aGUgc2NoZWR1bGVyLgogCiBm c2VjdGlvbi1hbmNob3JzCi1Db21tb24gUmVwb3J0IFZhcihmbGFnX3NlY3Rp b25fYW5jaG9ycykgT3B0aW1pemF0aW9uCitDb21tb24gUmVwb3J0IFZhcihm bGFnX3NlY3Rpb25fYW5jaG9ycykKIEFjY2VzcyBkYXRhIGluIHRoZSBzYW1l IHNlY3Rpb24gZnJvbSBzaGFyZWQgYW5jaG9yIHBvaW50cy4KIAogZnNlZQpk aWZmIC0tZ2l0IGEvZ2NjL3Bhc3Nlcy5kZWYgYi9nY2MvcGFzc2VzLmRlZgpp bmRleCAzNjQ3ZTkwLi4zYTgwNjNjIDEwMDY0NAotLS0gYS9nY2MvcGFzc2Vz LmRlZgorKysgYi9nY2MvcGFzc2VzLmRlZgpAQCAtMTM4LDEyICsxMzgsMTIg QEAgYWxvbmcgd2l0aCBHQ0M7IHNlZSB0aGUgZmlsZSBDT1BZSU5HMy4gIElm IG5vdCBzZWUKICAgUFVTSF9JTlNFUlRfUEFTU0VTX1dJVEhJTiAocGFzc19p cGFfdHJlZV9wcm9maWxlKQogICAgICAgTkVYVF9QQVNTIChwYXNzX2ZlZWRi YWNrX3NwbGl0X2Z1bmN0aW9ucyk7CiAgIFBPUF9JTlNFUlRfUEFTU0VTICgp Ci0gIE5FWFRfUEFTUyAocGFzc19pcGFfaW5jcmVhc2VfYWxpZ25tZW50KTsK ICAgTkVYVF9QQVNTIChwYXNzX2lwYV90bSk7CiAgIE5FWFRfUEFTUyAocGFz c19pcGFfbG93ZXJfZW11dGxzKTsKICAgVEVSTUlOQVRFX1BBU1NfTElTVCAo YWxsX3NtYWxsX2lwYV9wYXNzZXMpCiAKICAgSU5TRVJUX1BBU1NFU19BRlRF UiAoYWxsX3JlZ3VsYXJfaXBhX3Bhc3NlcykKKyAgTkVYVF9QQVNTIChwYXNz X2lwYV9pbmNyZWFzZV9hbGlnbm1lbnQpOwogICBORVhUX1BBU1MgKHBhc3Nf aXBhX3dob2xlX3Byb2dyYW1fdmlzaWJpbGl0eSk7CiAgIE5FWFRfUEFTUyAo cGFzc19pcGFfcHJvZmlsZSk7CiAgIE5FWFRfUEFTUyAocGFzc19pcGFfaWNm KTsKZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ZlY3QvYWxp Z25lZC1zZWN0aW9uLWFuY2hvcnMtdmVjdC03My5jIGIvZ2NjL3Rlc3RzdWl0 ZS9nY2MuZGcvdmVjdC9hbGlnbmVkLXNlY3Rpb24tYW5jaG9ycy12ZWN0LTcz LmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNzRlYWVk OAotLS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3Zl Y3QvYWxpZ25lZC1zZWN0aW9uLWFuY2hvcnMtdmVjdC03My5jCkBAIC0wLDAg KzEsMjUgQEAKKy8qIHsgZGctZG8gY29tcGlsZSB9ICovCisvKiB7IGRnLXJl cXVpcmUtZWZmZWN0aXZlLXRhcmdldCBzZWN0aW9uX2FuY2hvcnMgfSAqLwor LyogeyBkZy1yZXF1aXJlLWVmZmVjdGl2ZS10YXJnZXQgdmVjdF9pbnQgfSAq LworCisjZGVmaW5lIE4gMzIKKworLyogQ2xvbmUgb2Ygc2VjdGlvbi1hbmNo b3JzLXZlY3QtNzAuYyB3aXRoIGZvbygpIGhhdmluZyAtZm5vLXRyZWUtbG9v cC12ZWN0b3JpemUuICAqLyAKKworc3RhdGljIHN0cnVjdCBBIHsKKyAgaW50 IHAxLCBwMjsKKyAgaW50IGVbTl07Cit9IGEsIGIsIGM7CisKK19fYXR0cmli dXRlX18oKG9wdGltaXplKCItZm5vLXRyZWUtbG9vcC12ZWN0b3JpemUiKSkp CitpbnQgZm9vKHZvaWQpCit7CisgIGZvciAoaW50IGkgPSAwOyBpIDwgTjsg aSsrKQorICAgIGEuZVtpXSA9IGIuZVtpXSArIGMuZVtpXTsKKworICAgcmV0 dXJuIGEuZVswXTsKK30KKworLyogeyBkZy1maW5hbCB7IHNjYW4taXBhLWR1 bXAtdGltZXMgIkluY3JlYXNpbmcgYWxpZ25tZW50IG9mIGRlY2wiIDAgImlu Y3JlYXNlX2FsaWdubWVudCIgeyB0YXJnZXQgYWFyY2g2NCotKi0qIH0gfSB9 ICovCisvKiB7IGRnLWZpbmFsIHsgc2Nhbi1pcGEtZHVtcC10aW1lcyAiSW5j cmVhc2luZyBhbGlnbm1lbnQgb2YgZGVjbCIgMCAiaW5jcmVhc2VfYWxpZ25t ZW50IiB7IHRhcmdldCBwb3dlcnBjNjQqLSotKiB9IH0gfSAqLworLyogeyBk Zy1maW5hbCB7IHNjYW4taXBhLWR1bXAtdGltZXMgIkluY3JlYXNpbmcgYWxp Z25tZW50IG9mIGRlY2wiIDAgImluY3JlYXNlX2FsaWdubWVudCIgeyB0YXJn ZXQgYXJtKi0qLSogfSB9IH0gKi8KZGlmZiAtLWdpdCBhL2djYy90cmVlLXBh c3MuaCBiL2djYy90cmVlLXBhc3MuaAppbmRleCAzNjI5OWE2Li5kMzZhYTFk IDEwMDY0NAotLS0gYS9nY2MvdHJlZS1wYXNzLmgKKysrIGIvZ2NjL3RyZWUt cGFzcy5oCkBAIC00ODMsNyArNDgzLDcgQEAgZXh0ZXJuIHNpbXBsZV9pcGFf b3B0X3Bhc3MgKm1ha2VfcGFzc19sb2NhbF9vcHRpbWl6YXRpb25fcGFzc2Vz IChnY2M6OmNvbnRleHQgKmMKIAogZXh0ZXJuIGlwYV9vcHRfcGFzc19kICpt YWtlX3Bhc3NfaXBhX3dob2xlX3Byb2dyYW1fdmlzaWJpbGl0eSAoZ2NjOjpj b250ZXh0CiAJCQkJCQkJICAgICAgICpjdHh0KTsKLWV4dGVybiBzaW1wbGVf aXBhX29wdF9wYXNzICptYWtlX3Bhc3NfaXBhX2luY3JlYXNlX2FsaWdubWVu dCAoZ2NjOjpjb250ZXh0CitleHRlcm4gaXBhX29wdF9wYXNzX2QgKm1ha2Vf cGFzc19pcGFfaW5jcmVhc2VfYWxpZ25tZW50IChnY2M6OmNvbnRleHQKIAkJ CQkJCQkgICAgICAqY3R4dCk7CiBleHRlcm4gaXBhX29wdF9wYXNzX2QgKm1h a2VfcGFzc19pcGFfaW5saW5lIChnY2M6OmNvbnRleHQgKmN0eHQpOwogZXh0 ZXJuIHNpbXBsZV9pcGFfb3B0X3Bhc3MgKm1ha2VfcGFzc19pcGFfZnJlZV9s YW5nX2RhdGEgKGdjYzo6Y29udGV4dCAqY3R4dCk7CmRpZmYgLS1naXQgYS9n Y2MvdHJlZS12ZWN0b3JpemVyLmMgYi9nY2MvdHJlZS12ZWN0b3JpemVyLmMK aW5kZXggMjY2OTgxMy4uZDM0ZTU2MCAxMDA2NDQKLS0tIGEvZ2NjL3RyZWUt dmVjdG9yaXplci5jCisrKyBiL2djYy90cmVlLXZlY3Rvcml6ZXIuYwpAQCAt ODk5LDYgKzg5OSwzNCBAQCBnZXRfdmVjX2FsaWdubWVudF9mb3JfdHlwZSAo dHJlZSB0eXBlKQogICByZXR1cm4gKGFsaWdubWVudCA+IFRZUEVfQUxJR04g KHR5cGUpKSA/IGFsaWdubWVudCA6IDA7CiB9CiAKKy8qIFJldHVybiB0cnVl IGlmIGFsaWdubWVudCBzaG91bGQgYmUgaW5jcmVhc2VkIGZvciB0aGlzIHZu b2RlLgorICAgVGhpcyBpcyBkb25lIGlmIGV2ZXJ5IGZ1bmN0aW9uIHRoYXQg cmVmZXJlbmNlcy9yZWZlcnJpbmcgdG8gdm5vZGUKKyAgIGhhcyBmbGFnX3Ry ZWVfbG9vcF92ZWN0b3JpemUgYW5kIGZsYWdfc2VjdGlvbl9hbmNob3JzIHNl dC4gICovCisKK3N0YXRpYyBib29sCitpbmNyZWFzZV9hbGlnbm1lbnRfcCAo dmFycG9vbF9ub2RlICp2bm9kZSkKK3sKKyAgaXBhX3JlZiAqcmVmOworCisg IGZvciAoaW50IGkgPSAwOyB2bm9kZS0+aXRlcmF0ZV9yZWZlcmVuY2UgKGks IHJlZik7IGkrKykKKyAgICBpZiAoY2dyYXBoX25vZGUgKmNub2RlID0gZHlu X2Nhc3Q8Y2dyYXBoX25vZGUgKj4gKHJlZi0+cmVmZXJyZWQpKQorICAgICAg eworCXN0cnVjdCBjbF9vcHRpbWl6YXRpb24gKm9wdHMgPSBvcHRzX2Zvcl9m biAoY25vZGUtPmRlY2wpOworCWlmICghb3B0cy0+eF9mbGFnX3RyZWVfbG9v cF92ZWN0b3JpemUpCisJICByZXR1cm4gZmFsc2U7CisgICAgICB9CisKKyAg Zm9yIChpbnQgaSA9IDA7IHZub2RlLT5pdGVyYXRlX3JlZmVycmluZyAoaSwg cmVmKTsgaSsrKQorICAgIGlmIChjZ3JhcGhfbm9kZSAqY25vZGUgPSBkeW5f Y2FzdDxjZ3JhcGhfbm9kZSAqPiAocmVmLT5yZWZlcnJpbmcpKQorICAgICAg eworCXN0cnVjdCBjbF9vcHRpbWl6YXRpb24gKm9wdHMgPSBvcHRzX2Zvcl9m biAoY25vZGUtPmRlY2wpOworCWlmICghb3B0cy0+eF9mbGFnX3RyZWVfbG9v cF92ZWN0b3JpemUpCisJICByZXR1cm4gZmFsc2U7CisgICAgICB9CisKKyAg cmV0dXJuIHRydWU7Cit9CisKIC8qIEVudHJ5IHBvaW50IHRvIGluY3JlYXNl X2FsaWdubWVudCBwYXNzLiAgKi8KIHN0YXRpYyB1bnNpZ25lZCBpbnQKIGlu Y3JlYXNlX2FsaWdubWVudCAodm9pZCkKQEAgLTkxNiw3ICs5NDQsOCBAQCBp bmNyZWFzZV9hbGlnbm1lbnQgKHZvaWQpCiAKICAgICAgIGlmICgoZGVjbF9p bl9zeW10YWJfcCAoZGVjbCkKIAkgICYmICFzeW10YWJfbm9kZTo6Z2V0IChk ZWNsKS0+Y2FuX2luY3JlYXNlX2FsaWdubWVudF9wICgpKQotCSAgfHwgREVD TF9VU0VSX0FMSUdOIChkZWNsKSB8fCBERUNMX0FSVElGSUNJQUwgKGRlY2wp KQorCSAgfHwgREVDTF9VU0VSX0FMSUdOIChkZWNsKSB8fCBERUNMX0FSVElG SUNJQUwgKGRlY2wpCisJICB8fCAhaW5jcmVhc2VfYWxpZ25tZW50X3AgKHZu b2RlKSkKIAljb250aW51ZTsKIAogICAgICAgYWxpZ25tZW50ID0gZ2V0X3Zl Y19hbGlnbm1lbnRfZm9yX3R5cGUgKFRSRUVfVFlQRSAoZGVjbCkpOwpAQCAt OTM4LDcgKzk2Nyw3IEBAIG5hbWVzcGFjZSB7CiAKIGNvbnN0IHBhc3NfZGF0 YSBwYXNzX2RhdGFfaXBhX2luY3JlYXNlX2FsaWdubWVudCA9CiB7Ci0gIFNJ TVBMRV9JUEFfUEFTUywgLyogdHlwZSAqLworICBJUEFfUEFTUywgLyogdHlw ZSAqLwogICAiaW5jcmVhc2VfYWxpZ25tZW50IiwgLyogbmFtZSAqLwogICBP UFRHUk9VUF9MT09QIHwgT1BUR1JPVVBfVkVDLCAvKiBvcHRpbmZvX2ZsYWdz ICovCiAgIFRWX0lQQV9PUFQsIC8qIHR2X2lkICovCkBAIC05NDksMTcgKzk3 OCwyNiBAQCBjb25zdCBwYXNzX2RhdGEgcGFzc19kYXRhX2lwYV9pbmNyZWFz ZV9hbGlnbm1lbnQgPQogICAwLCAvKiB0b2RvX2ZsYWdzX2ZpbmlzaCAqLwog fTsKIAotY2xhc3MgcGFzc19pcGFfaW5jcmVhc2VfYWxpZ25tZW50IDogcHVi bGljIHNpbXBsZV9pcGFfb3B0X3Bhc3MKK2NsYXNzIHBhc3NfaXBhX2luY3Jl YXNlX2FsaWdubWVudCA6IHB1YmxpYyBpcGFfb3B0X3Bhc3NfZAogewogcHVi bGljOgogICBwYXNzX2lwYV9pbmNyZWFzZV9hbGlnbm1lbnQgKGdjYzo6Y29u dGV4dCAqY3R4dCkKLSAgICA6IHNpbXBsZV9pcGFfb3B0X3Bhc3MgKHBhc3Nf ZGF0YV9pcGFfaW5jcmVhc2VfYWxpZ25tZW50LCBjdHh0KQorICAgIDogaXBh X29wdF9wYXNzX2QgKHBhc3NfZGF0YV9pcGFfaW5jcmVhc2VfYWxpZ25tZW50 LCBjdHh0LAorCQkJICAgTlVMTCwgLyogZ2VuZXJhdGVfc3VtbWFyeSAgKi8K KwkJCSAgIE5VTEwsIC8qIHdyaXRlIHN1bW1hcnkgICovCisJCQkgICBOVUxM LCAvKiByZWFkIHN1bW1hcnkgICovCisJCQkgICBOVUxMLCAvKiB3cml0ZSBv cHRpbWl6YXRpb24gc3VtbWFyeSAgKi8KKwkJCSAgIE5VTEwsIC8qIHJlYWQg b3B0aW1pemF0aW9uIHN1bW1hcnkgICovCisJCQkgICBOVUxMLCAvKiBzdG10 IGZpeHVwICAqLworCQkJICAgMCwgLyogZnVuY3Rpb25fdHJhbnNmb3JtX3Rv ZG9fZmxhZ3Nfc3RhcnQgICovCisJCQkgICBOVUxMLCAvKiB0cmFuc2Zvcm0g ZnVuY3Rpb24gICovCisJCQkgICBOVUxMICkvKiB2YXJpYWJsZSB0cmFuc2Zv cm0gICovCiAgIHt9CiAKICAgLyogb3B0X3Bhc3MgbWV0aG9kczogKi8KICAg dmlydHVhbCBib29sIGdhdGUgKGZ1bmN0aW9uICopCiAgICAgewotICAgICAg cmV0dXJuIGZsYWdfc2VjdGlvbl9hbmNob3JzICYmIGZsYWdfdHJlZV9sb29w X3ZlY3Rvcml6ZTsKKyAgICAgIHJldHVybiBmbGFnX3NlY3Rpb25fYW5jaG9y cyAhPSAwOyAKICAgICB9CiAKICAgdmlydHVhbCB1bnNpZ25lZCBpbnQgZXhl Y3V0ZSAoZnVuY3Rpb24gKikgeyByZXR1cm4gaW5jcmVhc2VfYWxpZ25tZW50 ICgpOyB9CkBAIC05NjgsNyArMTAwNiw3IEBAIHB1YmxpYzoKIAogfSAvLyBh bm9uIG5hbWVzcGFjZQogCi1zaW1wbGVfaXBhX29wdF9wYXNzICoKK2lwYV9v cHRfcGFzc19kICoKIG1ha2VfcGFzc19pcGFfaW5jcmVhc2VfYWxpZ25tZW50 IChnY2M6OmNvbnRleHQgKmN0eHQpCiB7CiAgIHJldHVybiBuZXcgcGFzc19p cGFfaW5jcmVhc2VfYWxpZ25tZW50IChjdHh0KTsK --001a113eb1d4c8b0e30534de1f59--