From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5679 invoked by alias); 22 Jan 2015 20:58:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5667 invoked by uid 89); 22 Jan 2015 20:58:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f46.google.com Received: from mail-la0-f46.google.com (HELO mail-la0-f46.google.com) (209.85.215.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 22 Jan 2015 20:58:23 +0000 Received: by mail-la0-f46.google.com with SMTP id s18so3959166lam.5 for ; Thu, 22 Jan 2015 12:58:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=iGzrAMniwAiXeB0rPnOrSTSv5b8pj0xbhh8aEKjGmTI=; b=WRiJ+y21aOweS3vGp+RD1IcIeydfzrhF/yLqM0B+db6oLqj2baR4D4sonHY5+mWdo/ u2DB2E5tHMh4nW98SdoQ0aWKGNU+OLCYXC05aqMg5mi0zY1buNrXN12lYW7IgNO/gc/F 2tm2xR9vCAT/xGoFUpp79wt6xBsLi1/ynwWuuGWRtcQFk35iUdk4YGZrJ8jKq0TwDyHJ xn652QkCv3SSqvYSBcai9wyIH6FIMqda3psO/70DAODj3tCVEf+UPUfYPpg2bhhZkVSy VX5XaO3Nny9vZgx+pG1WngWZNi9Z+NGM9uqlpdrHwsz2ss0AGI2poztFqH/Ow8LcqRF7 gWyw== X-Gm-Message-State: ALoCoQke4WnMi+w6j/a3vMZXljxOjm8WpwzhGmD/h98zdb0ZYn1OR/PESyxpX51MbsxLzrJmr6yB MIME-Version: 1.0 X-Received: by 10.152.22.129 with SMTP id d1mr3954723laf.22.1421960300199; Thu, 22 Jan 2015 12:58:20 -0800 (PST) Received: by 10.25.211.16 with HTTP; Thu, 22 Jan 2015 12:58:19 -0800 (PST) In-Reply-To: <3450002.mYNjilJ0dL@polaris> References: <3450002.mYNjilJ0dL@polaris> Date: Thu, 22 Jan 2015 22:17:00 -0000 Message-ID: Subject: Re: flatten expr.h (version 2) From: Prathamesh Kulkarni To: Eric Botcazou Cc: gcc Patches , Richard Biener , Michael Collison , Andrew MacLeod Content-Type: multipart/mixed; boundary=089e0158ab6a9444d4050d43ee12 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg02056.txt.bz2 --089e0158ab6a9444d4050d43ee12 Content-Type: text/plain; charset=UTF-8 Content-length: 670 On 21 January 2015 at 23:18, Eric Botcazou wrote: >> Thanks. I had wrongly made eliminate_constant_term() static, reverted >> that change and it builds on >> all targets in config-list.mk. >> Committed as r219655 (hopefully nothing breaks!). > > Any particular reason why store_bit_field, extract_bit_field, extract_low_bits > expand_mult and expand_mult_highpart_adjust are declared in emit-rtl.h? Thanks, moved them to expmed.h. Boostrapped on x86_64-unknown-linux-gnu with languages: all, testing in progress. Build on all targets in config-list.mk in progress. Assuming it goes fine, OK to commit ? Thanks, Prathamesh > > -- > Eric Botcazou --089e0158ab6a9444d4050d43ee12 Content-Type: text/plain; charset=US-ASCII; name="Changelog.txt" Content-Disposition: attachment; filename="Changelog.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i58mf0dh0 Content-length: 354 MjAxNS0wMS0yMiAgUHJhdGhhbWVzaCBLdWxrYXJuaSAgPHByYXRoYW1lc2gu a3Vsa2FybmlAbGluYXJvLm9yZz4KCgkqIGVtaXQtcnRsLmggKHN0b3JlX2Jp dF9maWVsZCk6IE1vdmUgcHJvdG90eXBlIHRvIGV4cG1lZC5oLiAKCShleHRy YWN0X2JpdF9maWVsZCk6IExpa2V3aXNlLgoJKGV4dHJhY3RfbG93X2JpdHMp OiBMaWtld2lzZS4KCShleHBhbmRfbXVsdCk6IExpa2V3aXNlLgoJKGV4cGFu ZF9tdWx0X2hpZ2hwYXJ0X2FkanVzdCk6IExpa2V3aXNlLgo= --089e0158ab6a9444d4050d43ee12 Content-Type: text/x-patch; charset=US-ASCII; name="foo.patch" Content-Disposition: attachment; filename="foo.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i58mf0g21 Content-length: 2196 SW5kZXg6IGdjYy9lbWl0LXJ0bC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGdjYy9lbWl0LXJ0bC5oCShyZXZpc2lvbiAyMTk4ODIpCisrKyBnY2Mv ZW1pdC1ydGwuaAkod29ya2luZyBjb3B5KQpAQCAtMTg5LDE3ICsxODksNCBA QAogICAgTU9ERSBhbmQgYWRqdXN0ZWQgYnkgT0ZGU0VULiAgKi8KIGV4dGVy biBydHggd2lkZW5fbWVtb3J5X2FjY2VzcyAocnR4LCBtYWNoaW5lX21vZGUs IEhPU1RfV0lERV9JTlQpOwogCi1leHRlcm4gdm9pZCBzdG9yZV9iaXRfZmll bGQgKHJ0eCwgdW5zaWduZWQgSE9TVF9XSURFX0lOVCwKLQkJCSAgICAgdW5z aWduZWQgSE9TVF9XSURFX0lOVCwKLQkJCSAgICAgdW5zaWduZWQgSE9TVF9X SURFX0lOVCwKLQkJCSAgICAgdW5zaWduZWQgSE9TVF9XSURFX0lOVCwKLQkJ CSAgICAgbWFjaGluZV9tb2RlLCBydHgpOwotZXh0ZXJuIHJ0eCBleHRyYWN0 X2JpdF9maWVsZCAocnR4LCB1bnNpZ25lZCBIT1NUX1dJREVfSU5ULAotCQkJ ICAgICAgdW5zaWduZWQgSE9TVF9XSURFX0lOVCwgaW50LCBydHgsCi0JCQkg ICAgICBtYWNoaW5lX21vZGUsIG1hY2hpbmVfbW9kZSk7Ci1leHRlcm4gcnR4 IGV4dHJhY3RfbG93X2JpdHMgKG1hY2hpbmVfbW9kZSwgbWFjaGluZV9tb2Rl LCBydHgpOwotZXh0ZXJuIHJ0eCBleHBhbmRfbXVsdCAobWFjaGluZV9tb2Rl LCBydHgsIHJ0eCwgcnR4LCBpbnQpOwotZXh0ZXJuIHJ0eCBleHBhbmRfbXVs dF9oaWdocGFydF9hZGp1c3QgKG1hY2hpbmVfbW9kZSwgcnR4LCBydHgsIHJ0 eCwgcnR4LCBpbnQpOwotCi0KICNlbmRpZiAvKiBHQ0NfRU1JVF9SVExfSCAq LwpJbmRleDogZ2NjL2V4cG1lZC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGdjYy9leHBtZWQuaAkocmV2aXNpb24gMjE5ODgyKQorKysgZ2NjL2V4 cG1lZC5oCSh3b3JraW5nIGNvcHkpCkBAIC03MDMsNCArNzAzLDE2IEBACiAJ CQkgIHJ0eCwgaW50KTsKICNlbmRpZgogCitleHRlcm4gdm9pZCBzdG9yZV9i aXRfZmllbGQgKHJ0eCwgdW5zaWduZWQgSE9TVF9XSURFX0lOVCwKKwkJCSAg ICAgdW5zaWduZWQgSE9TVF9XSURFX0lOVCwKKwkJCSAgICAgdW5zaWduZWQg SE9TVF9XSURFX0lOVCwKKwkJCSAgICAgdW5zaWduZWQgSE9TVF9XSURFX0lO VCwKKwkJCSAgICAgbWFjaGluZV9tb2RlLCBydHgpOworZXh0ZXJuIHJ0eCBl eHRyYWN0X2JpdF9maWVsZCAocnR4LCB1bnNpZ25lZCBIT1NUX1dJREVfSU5U LAorCQkJICAgICAgdW5zaWduZWQgSE9TVF9XSURFX0lOVCwgaW50LCBydHgs CisJCQkgICAgICBtYWNoaW5lX21vZGUsIG1hY2hpbmVfbW9kZSk7CitleHRl cm4gcnR4IGV4dHJhY3RfbG93X2JpdHMgKG1hY2hpbmVfbW9kZSwgbWFjaGlu ZV9tb2RlLCBydHgpOworZXh0ZXJuIHJ0eCBleHBhbmRfbXVsdCAobWFjaGlu ZV9tb2RlLCBydHgsIHJ0eCwgcnR4LCBpbnQpOworZXh0ZXJuIHJ0eCBleHBh bmRfbXVsdF9oaWdocGFydF9hZGp1c3QgKG1hY2hpbmVfbW9kZSwgcnR4LCBy dHgsIHJ0eCwgcnR4LCBpbnQpOworCiAjZW5kaWYgIC8vIEVYUE1FRF9ICg== --089e0158ab6a9444d4050d43ee12--