From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <prathamesh.kulkarni@linaro.org>
Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com
 [IPv6:2a00:1450:4864:20::629])
 by sourceware.org (Postfix) with ESMTPS id 7AC9D3858001
 for <gcc-patches@gcc.gnu.org>; Sun, 25 Jul 2021 14:30:27 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7AC9D3858001
Received: by mail-ej1-x629.google.com with SMTP id gn26so5715419ejc.3
 for <gcc-patches@gcc.gnu.org>; Sun, 25 Jul 2021 07:30:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=fjRRhM7j5dFRHAxBgsvvMa/rToDSeAfQ6RNgz8DAMdE=;
 b=NxCd1yeT27ZJTaS6JuNP3Xnm6aF2IAmNT5pwdHXuRDxq3GnYCv21mrPIZF3crAeRO2
 Ao+04Jd/ZuwRiz7maIobc91CX4TkifuReB/scKIbVrPZqnqytiTbjjM8dTHN1KolooYf
 LKwtd4JrqFIkxoW+A4ondqwZUR518HWLFzL7wIj8IbIpRC3jxJl324qjha6blbPiaKTP
 gSC52CatgLAeKx8CP+YtY1GAhDRjXfsHwjeoWYg54O6jgO59Vh3NgqZ27HxQnQnangGd
 bc5aeLYvyMlGL/voGSVtybL4vbkP1+5kcElHhVowbrHmbyMLQVbfLXNKJyGSV5YUiULj
 3Ggw==
X-Gm-Message-State: AOAM531t3gJIOTmdjV9/4VOucFOGWqrTTKlrXHznBze56iYJ7PMjuygK
 tlCb6c6F1/k7BdlzVfhicxyiGSvKz80d98aE8x/ugQ==
X-Google-Smtp-Source: ABdhPJwVcSsso5KVs6vHpzWrK5wxSUPgMKG8MNajeVz1GzXHS2tsq1AIDUc3aqE7ssYp1cxLZHUTme9j0jLmpWnOJJs=
X-Received: by 2002:a17:906:11d4:: with SMTP id
 o20mr2526269eja.329.1627223426498; 
 Sun, 25 Jul 2021 07:30:26 -0700 (PDT)
MIME-Version: 1.0
References: <D81EF7C0-E974-406C-845A-76916096B2D1@gmail.com>
 <4ba558f63af280676178beb75c3e7294eac9d09b.camel@redhat.com>
 <6F0991BF-8155-445F-A8A9-CD4A65E60EC2@gmail.com>
In-Reply-To: <6F0991BF-8155-445F-A8A9-CD4A65E60EC2@gmail.com>
From: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Date: Sun, 25 Jul 2021 19:59:50 +0530
Message-ID: <CAAgBjMn95=j5RfH4r-Au0L_ZfYtiazGdFDqnGZxd_W2Wrt7TCg@mail.gmail.com>
Subject: Re: [PATCH] Analyzer: Refactor callstring to work with pairs of
 supernodes.
To: Ankur Saini <arsenic.secondary@gmail.com>
Cc: David Malcolm <dmalcolm@redhat.com>, gcc Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Jul 2021 14:30:28 -0000

On Sun, 25 Jul 2021 at 16:03, Ankur Saini via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
> Here is the new patch after fixing all the issues pointed out in the prev=
ious version.
Just a nitpick:

+/* call_string::element_t's inequality operator.  */
+bool
+call_string::element_t::operator!=3D (const call_string::element_t &other)=
 const
+{
+  if (m_caller !=3D other.m_caller || m_callee !=3D other.m_callee)
+    return true;
+  return false;
+}

Since you define operator=3D=3D above, perhaps just implement operator !=3D=
 as:
return !(*this =3D=3D other) ?

Thanks,
Prathamesh
>
>
>
> =E2=80=94
>
> Question :
>
> 1. The mail id I am using here to send the patch ( arsenic.secondary@gmai=
l.com ) and the mail id in the patch ( arsenic@sourceware.org ) are differe=
nt from one and other, will this affect the process in any ways ?
>
>
> Thanks
> - Ankur