From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=bYgT=BO=linaro.org=prathamesh.kulkarni@sourceware.org>
Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433])
	by sourceware.org (Postfix) with ESMTPS id 773F93858D3C
	for <gcc-patches@gcc.gnu.org>; Thu, 25 May 2023 09:57:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 773F93858D3C
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org
Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-30950eecc1eso1883621f8f.0
        for <gcc-patches@gcc.gnu.org>; Thu, 25 May 2023 02:57:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google; t=1685008652; x=1687600652;
        h=to:subject:message-id:date:from:in-reply-to:references:mime-version
         :from:to:cc:subject:date:message-id:reply-to;
        bh=tXm4/2o47TLENYuf5c9ScgLB5eQCGo5xt0Oj8CYt8wo=;
        b=wYhjskOeBBNRUErdY/vpgZOm9MYMFY6HmX43i50QCfgjsCsQBVoWYyRMB28gh2uA1N
         dgTkFoyeB69ZGK73/04TmMV3vA78HW2FsjvH/v5YjcorHfrdfRdePPKbr5DgHil4tKiu
         T0NPmj3or+5Z3X5h8GbN7h/mCn8E/LIZxTFG61CCuBsZf1vMmLrVq1JRGtDh9+yszjv6
         goNHG/CpMHwwt6/LAm8qmPKevzq1K8QNVVpRr9LPV6o6nnOH42ESDpUWo/OTiO7lygdP
         wnlmoew922jf7m5FBvYHUabC3FrFLwZZr+uaR4L7GjCHuLJcAybkrXGsVvnfO+EgbW3T
         LlYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1685008652; x=1687600652;
        h=to:subject:message-id:date:from:in-reply-to:references:mime-version
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=tXm4/2o47TLENYuf5c9ScgLB5eQCGo5xt0Oj8CYt8wo=;
        b=KpFBRhrtquHpVLsQcrc535HALohYGdnaBOL91+AhXcffLElXbvkK06gWesKDj4dlG+
         QltWUxF3NzUslOfGm3TMULH88eIxnjaqNq6SkmaWDLUdtK+AECX1CnU2JKNR2hkF+cEO
         /YJ7jVrIv5ANY3Hi4CN/njh2cQls46Khbxc34b9n9qdQZnZSHr8bRzyCaR5x3rSlIPU/
         BR8CRPuv+tz66Y92olwvvIWHq2qY1mkpwx+WIBEKlGmwMswbM8NIQoDHGFwdbfg/C2yH
         HuNwb8mYSuQpTsaxRvyfmcpDoiaWHlU8XMOJAVZDQj5XWsvatVtgucXxN9gBvdWxnopj
         1nfA==
X-Gm-Message-State: AC+VfDz721YHAMF/kktnnuC/Q6Lbux5k2LFielialevRC+B39yJVwxd+
	82z3FFvWaErfY46ZuwqNd4NZ3wMd/YHmf6A/RjdE0Q==
X-Google-Smtp-Source: ACHHUZ4dYgWO9rGQMx6rdKLUuzdH0Y33DpXKr65O+Sks3JkHPRO0jYwmuLWuWOc1+6bONyosrmmk1uJ0Qje+aT4AMvM=
X-Received: by 2002:a5d:4b51:0:b0:306:29f9:ab47 with SMTP id
 w17-20020a5d4b51000000b0030629f9ab47mr2057066wrs.49.1685008652272; Thu, 25
 May 2023 02:57:32 -0700 (PDT)
MIME-Version: 1.0
References: <CAAgBjMnwGk4fOc3PTM_agTXXFvt=767a3-AWOfSr23Xja6K81w@mail.gmail.com>
 <mpt354fw0dc.fsf@arm.com> <CAAgBjM=ryaC9h-9N_WWmPjcqE_fEA7xXPK8wye8TvFXsnMTyHg@mail.gmail.com>
 <mpto7n3ueju.fsf@arm.com> <CAAgBjMnP5Z3bsge08n5GWszBBqPgwV66KaZjr6vYOs3GUvv2qw@mail.gmail.com>
 <mpt7ctqvqsz.fsf@arm.com> <CAAgBjMn6tOT3HpOdjB3f47D_qAVC2S1jsoGVGvnJ7uk6vDcKdA@mail.gmail.com>
 <mpt3542el2f.fsf@arm.com> <CAAgBjMm9__ZPxuNvtaiwSFaS35kWqj2StsQY6atYnUPMzUYYsw@mail.gmail.com>
 <mpth6sd5slj.fsf@arm.com> <CAAgBjMnAT6keAqMqtj2+0Z6ZKyKDQ+e+jWHANgEESVFHG_WM2w@mail.gmail.com>
 <mpt353uysem.fsf@arm.com> <CAAgBjMnXfy0R8AjJhaXZ7Af7CF7n=xgPEycc4TKJ77V-Tcy5mQ@mail.gmail.com>
 <mptjzx5y4wj.fsf@arm.com> <CAAgBjMkzx9rB_WQD78jv18NiV+R+5bg9Jr3UFPonVmxTSSh+OA@mail.gmail.com>
 <mptilckpx8n.fsf@arm.com> <CAAgBjMksK3d5Wtv3bOAeL4Rjjwt8_yUV3yt47uxuLRYWPsXJog@mail.gmail.com>
 <mptwn0yjazm.fsf@arm.com> <CAAgBjMmB9WqP85xw3u7jFrk6Geq5E2LDgKorAJn0G+gkknTZMw@mail.gmail.com>
 <mptv8ghcxip.fsf@arm.com> <CAAgBjMnKnrBwOVySBVQU0q_fegzgXfFB1a0K81uaMiTxHUs6HA@mail.gmail.com>
 <mptedn4dfv1.fsf@arm.com>
In-Reply-To: <mptedn4dfv1.fsf@arm.com>
From: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
Date: Thu, 25 May 2023 15:26:56 +0530
Message-ID: <CAAgBjMnFjYh2ujS80rDY==5weuz9NtJ74mkiHBEtL4htF1qS+A@mail.gmail.com>
Subject: Re: [aarch64] Code-gen for vector initialization involving constants
To: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>, gcc Patches <gcc-patches@gcc.gnu.org>, 
	richard.sandiford@arm.com
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On Thu, 25 May 2023 at 13:04, Richard Sandiford
<richard.sandiford@arm.com> wrote:
>
> LGTM, just a couple of comment tweaks:
>
> Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org> writes:
> > diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
> > index d6fc94015fa..db7ca4c28c3 100644
> > --- a/gcc/config/aarch64/aarch64.cc
> > +++ b/gcc/config/aarch64/aarch64.cc
> > @@ -22332,6 +22332,46 @@ aarch64_unzip_vector_init (machine_mode mode, rtx vals, bool even_p)
> >    return gen_rtx_PARALLEL (new_mode, vec);
> >  }
> >
> > +/* Return true if INSN is a scalar move.  */
>
> s/INSN/SET/
>
> > +
> > +static bool
> > +scalar_move_insn_p (rtx set)
> > +{
> > +  rtx src = SET_SRC (set);
> > +  rtx dest = SET_DEST (set);
> > +  return (is_a<scalar_mode> (GET_MODE (dest))
> > +       && aarch64_mov_operand (src, GET_MODE (dest)));
> > +}
> > +
> > +/* Similar to seq_cost, but ignore cost for scalar moves.  This function
> > +   is called from aarch64_expand_vector_init.  */
>
> Probably best to drop the second sentence.
>
> OK with those changes, thanks (no need to retest).
Thanks, committed as ea9154dbc8fc86d4c617503ca5e6f02fed3a6a56.

Thanks,
Prathamesh
>
> Richard