Re: [C++ patch] PR 65858

[Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>]

On 1 May 2015 at 01:12, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Hi again,
>
> On 04/30/2015 08:45 PM, Paolo Carlini wrote:
>>
>> .. also, your patch doesn't seem to fix the case of -w instead of
That could be fixed as follows:
if (!warn_narrowing || inhibit_warnings)
  ok = true;
else
  // pedwarn
>> -Wno-narrowing. I think we want to check the return value of the pedwarn
>> instead. I'm testing something.
>
> I'm finishing testing the below: with hindsight, checking the return value
> of the pedwarn makes a lot of sense to me!
Indeed, checking return value of pedwarn is better compared to testing
on warning flags.
Thanks for pointing out -;)

Regards,
Prathamesh
>
> Paolo.
>
> ///////////////////////