From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117761 invoked by alias); 25 Oct 2019 19:58:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117753 invoked by uid 89); 25 Oct 2019 19:58:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*i:CAFiYyc2rQq, H*i:sk:43omf9Y, H*f:sk:43omf9Y, H*f:CAFiYyc2rQq X-HELO: mail-lj1-f171.google.com Received: from mail-lj1-f171.google.com (HELO mail-lj1-f171.google.com) (209.85.208.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Oct 2019 19:58:33 +0000 Received: by mail-lj1-f171.google.com with SMTP id a22so4131005ljd.0 for ; Fri, 25 Oct 2019 12:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IrUnsX/piNbk1AumdA2LsnfLrXymI0PsNwKlle0NeWs=; b=SiOFX88HWaWVzT+hxDHlDSPS6nRIOzKgKvAX1OjVfun3s97CFcshRbofUy0TpMwr7K 4mRXJG9LeXJrUfzfd/9CqDLWqegv6BMeg5ey323BBUhz57QKnqcFt2ikK4A3QzzX209w COf3nINQ5X4Wx8xtnmqUg6hhxHeafhXfyxqqp36yybFGDI5Un7B1UymHi0BKPyso8h6k JmUUlRz3yu7babv72pr/oQQagtHmR9TKBlCbVkrtcNRYdrWHjXA8bFGjPKvDhWOMEIsC JWkXYKRywZQhYGmzSxuAGaqwprwMQze6pkCHl62Hjz3loR8RoSlHOpOq9VRriIM+gbgc UHRg== MIME-Version: 1.0 References: In-Reply-To: From: Prathamesh Kulkarni Date: Fri, 25 Oct 2019 20:49:00 -0000 Message-ID: Subject: Re: PR92163 To: Richard Biener Cc: gcc Patches , Jakub Jelinek Content-Type: multipart/mixed; boundary="000000000000fee0e00595c19227" X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg01871.txt.bz2 --000000000000fee0e00595c19227 Content-Type: text/plain; charset="UTF-8" Content-length: 1026 On Fri, 25 Oct 2019 at 13:19, Richard Biener wrote: > > On Wed, Oct 23, 2019 at 11:45 PM Prathamesh Kulkarni > wrote: > > > > Hi, > > The attached patch tries to fix PR92163 by calling > > gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup. > > Does it look OK ? > > Hmm. I think it shows an issue with the return value of remove_stmt_form_eh_lp > which is true if the LP index is -1 (externally throwing). We don't > need to purge > any edges in that case. That is, if-conversion should never need to > do EH purging > since that would be wrong-code. > > As of the segfault can you please instead either pass down need_eh_cleanup > as function parameter (and NULL from ifcvt) or use the return value in DSE > to set the bit in the caller. Hi Richard, Thanks for the suggestions, does the attached patch look OK ? Bootstrap+test in progress on x86_64-unknown-linux-gnu. Thanks, Prathamesh > > Thanks, > Richard. > > > Thanks, > > Prathamesh --000000000000fee0e00595c19227 Content-Type: text/plain; charset="US-ASCII"; name="pr92163-3.txt" Content-Disposition: attachment; filename="pr92163-3.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k26k2vn80 Content-length: 4929 MjAxOS0xMC0yNSAgUHJhdGhhbWVzaCBLdWxrYXJuaSAgPHByYXRoYW1lc2gu a3Vsa2FybmlAbGluYXJvLm9yZz4KCglQUiB0cmVlLW9wdGltaXphdGlvbi85 MjE2MwoJKiB0cmVlLXNzYS1kc2UuYyAoZGVsZXRlX2RlYWRfb3JfcmVkdW5k YW50X2Fzc2lnbm1lbnQpOiBOZXcgcGFyYW0KCW5lZWRfZWhfY2xlYW51cCB3 aXRoIGRlZmF1bHQgdmFsdWUgTlVMTC4gR2F0ZSBvbiBuZWVkX2VoX2NsZWFu dXAKCWJlZm9yZSBjYWxsaW5nIGJpdG1hcF9zZXRfYml0LgoJKGRzZV9vcHRp bWl6ZV9yZWR1bmRhbnRfc3RvcmVzKTogUGFzcyBnbG9iYWwgbmVlZF9laF9j bGVhbnVwIHRvCglkZWxldGVfZGVhZF9vcl9yZWR1bmRhbnRfYXNzaWdubWVu dC4KCShkc2VfZG9tX3dhbGtlcjo6ZHNlX29wdGltaXplX3N0bXQpOiBMaWtl d2lzZS4KCSogdHJlZS1zc2EtZHNlLmggKGRlbGV0ZV9kZWFkX29yX3JlZHVu ZGFudF9hc3NpZ25tZW50KTogQWRqdXN0IHByb3RvdHlwZS4KCnRlc3RzdWl0 ZS8KCSogZ2NjLmRnL3RyZWUtc3NhL3ByOTIxNjMuYzogTmV3IHRlc3QuCgpk aWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2EvcHI5 MjE2My5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MuZGcvdHJlZS1zc2EvcHI5MjE2 My5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwLi41 OGY1NDhmZTc2YgotLS0gL2Rldi9udWxsCisrKyBiL2djYy90ZXN0c3VpdGUv Z2NjLmRnL3RyZWUtc3NhL3ByOTIxNjMuYwpAQCAtMCwwICsxLDE2IEBACisv KiB7IGRnLWRvICJjb21waWxlIiB9ICovCisvKiB7IGRnLW9wdGlvbnMgIi1P MiAtZmV4Y2VwdGlvbnMgLWZub24tY2FsbC1leGNlcHRpb25zIC1mb3BlbmFj YyIgfSAqLworCit2b2lkCit4ciAoaW50ICprNykKK3sKKyAgaW50IHFhOwor CisjcHJhZ21hIGFjYyBwYXJhbGxlbAorI3ByYWdtYSBhY2MgbG9vcCB2ZWN0 b3IKKyAgZm9yIChxYSA9IDA7IHFhIDwgMzsgKytxYSkKKyAgICBpZiAocWEg JSAyICE9IDApCisgICAgICBrN1txYV0gPSAwOworICAgIGVsc2UKKyAgICAg IGs3W3FhXSA9IDE7Cit9CmRpZmYgLS1naXQgYS9nY2MvdHJlZS1zc2EtZHNl LmMgYi9nY2MvdHJlZS1zc2EtZHNlLmMKaW5kZXggMjVjZDQ3MDliMzEuLjIx YTE1ZWVmNjkwIDEwMDY0NAotLS0gYS9nY2MvdHJlZS1zc2EtZHNlLmMKKysr IGIvZ2NjL3RyZWUtc3NhLWRzZS5jCkBAIC03Nyw3ICs3Nyw2IEBAIGFsb25n IHdpdGggR0NDOyBzZWUgdGhlIGZpbGUgQ09QWUlORzMuICBJZiBub3Qgc2Vl CiAgICBmYWN0LCB0aGV5IGFyZSB0aGUgc2FtZSB0cmFuc2Zvcm1hdGlvbiBh cHBsaWVkIHRvIGRpZmZlcmVudCB2aWV3cyBvZgogICAgdGhlIENGRy4gICov CiAKLXZvaWQgZGVsZXRlX2RlYWRfb3JfcmVkdW5kYW50X2Fzc2lnbm1lbnQg KGdpbXBsZV9zdG10X2l0ZXJhdG9yICosIGNvbnN0IGNoYXIgKik7CiBzdGF0 aWMgdm9pZCBkZWxldGVfZGVhZF9vcl9yZWR1bmRhbnRfY2FsbCAoZ2ltcGxl X3N0bXRfaXRlcmF0b3IgKiwgY29uc3QgY2hhciAqKTsKIAogLyogQml0bWFw IG9mIGJsb2NrcyB0aGF0IGhhdmUgaGFkIEVIIHN0YXRlbWVudHMgY2xlYW5l ZC4gIFdlIHNob3VsZApAQCAtNjM5LDcgKzYzOCw4IEBAIGRzZV9vcHRpbWl6 ZV9yZWR1bmRhbnRfc3RvcmVzIChnaW1wbGUgKnN0bXQpCiAJICAgIHsKIAkg ICAgICBnaW1wbGVfc3RtdF9pdGVyYXRvciBnc2kgPSBnc2lfZm9yX3N0bXQg KHVzZV9zdG10KTsKIAkgICAgICBpZiAoaXNfZ2ltcGxlX2Fzc2lnbiAodXNl X3N0bXQpKQotCQlkZWxldGVfZGVhZF9vcl9yZWR1bmRhbnRfYXNzaWdubWVu dCAoJmdzaSwgInJlZHVuZGFudCIpOworCQlkZWxldGVfZGVhZF9vcl9yZWR1 bmRhbnRfYXNzaWdubWVudCAoJmdzaSwgInJlZHVuZGFudCIsCisJCQkJCQkg ICAgIG5lZWRfZWhfY2xlYW51cCk7CiAJICAgICAgZWxzZSBpZiAoaXNfZ2lt cGxlX2NhbGwgKHVzZV9zdG10KSkKIAkJZGVsZXRlX2RlYWRfb3JfcmVkdW5k YW50X2NhbGwgKCZnc2ksICJyZWR1bmRhbnQiKTsKIAkgICAgICBlbHNlCkBA IC05MDAsNyArOTAwLDggQEAgZGVsZXRlX2RlYWRfb3JfcmVkdW5kYW50X2Nh bGwgKGdpbXBsZV9zdG10X2l0ZXJhdG9yICpnc2ksIGNvbnN0IGNoYXIgKnR5 cGUpCiAvKiBEZWxldGUgYSBkZWFkIHN0b3JlIGF0IEdTSSwgd2hpY2ggaXMg YSBnaW1wbGUgYXNzaWdubWVudC4gKi8KIAogdm9pZAotZGVsZXRlX2RlYWRf b3JfcmVkdW5kYW50X2Fzc2lnbm1lbnQgKGdpbXBsZV9zdG10X2l0ZXJhdG9y ICpnc2ksIGNvbnN0IGNoYXIgKnR5cGUpCitkZWxldGVfZGVhZF9vcl9yZWR1 bmRhbnRfYXNzaWdubWVudCAoZ2ltcGxlX3N0bXRfaXRlcmF0b3IgKmdzaSwg Y29uc3QgY2hhciAqdHlwZSwKKwkJCQkgICAgIGJpdG1hcCBuZWVkX2VoX2Ns ZWFudXApCiB7CiAgIGdpbXBsZSAqc3RtdCA9IGdzaV9zdG10ICgqZ3NpKTsK ICAgaWYgKGR1bXBfZmlsZSAmJiAoZHVtcF9mbGFncyAmIFRERl9ERVRBSUxT KSkKQEAgLTkxNSw3ICs5MTYsNyBAQCBkZWxldGVfZGVhZF9vcl9yZWR1bmRh bnRfYXNzaWdubWVudCAoZ2ltcGxlX3N0bXRfaXRlcmF0b3IgKmdzaSwgY29u c3QgY2hhciAqdHlwZQogCiAgIC8qIFJlbW92ZSB0aGUgZGVhZCBzdG9yZS4g ICovCiAgIGJhc2ljX2Jsb2NrIGJiID0gZ2ltcGxlX2JiIChzdG10KTsKLSAg aWYgKGdzaV9yZW1vdmUgKGdzaSwgdHJ1ZSkpCisgIGlmIChnc2lfcmVtb3Zl IChnc2ksIHRydWUpICYmIG5lZWRfZWhfY2xlYW51cCkKICAgICBiaXRtYXBf c2V0X2JpdCAobmVlZF9laF9jbGVhbnVwLCBiYi0+aW5kZXgpOwogCiAgIC8q IEFuZCByZWxlYXNlIGFueSBTU0FfTkFNRXMgc2V0IGluIHRoaXMgc3RhdGVt ZW50IGJhY2sgdG8gdGhlCkBAIC0xMDU5LDcgKzEwNjAsNyBAQCBkc2VfZG9t X3dhbGtlcjo6ZHNlX29wdGltaXplX3N0bXQgKGdpbXBsZV9zdG10X2l0ZXJh dG9yICpnc2kpCiAJICAmJiAhYnlfY2xvYmJlcl9wKQogCXJldHVybjsKIAot ICAgICAgZGVsZXRlX2RlYWRfb3JfcmVkdW5kYW50X2Fzc2lnbm1lbnQgKGdz aSwgImRlYWQiKTsKKyAgICAgIGRlbGV0ZV9kZWFkX29yX3JlZHVuZGFudF9h c3NpZ25tZW50IChnc2ksICJkZWFkIiwgbmVlZF9laF9jbGVhbnVwKTsKICAg ICB9CiB9CiAKZGlmZiAtLWdpdCBhL2djYy90cmVlLXNzYS1kc2UuaCBiL2dj Yy90cmVlLXNzYS1kc2UuaAppbmRleCBhNWVjY2JkNzQ2ZC4uMjY1OGY5MmIx YmIgMTAwNjQ0Ci0tLSBhL2djYy90cmVlLXNzYS1kc2UuaAorKysgYi9nY2Mv dHJlZS1zc2EtZHNlLmgKQEAgLTMxLDYgKzMxLDcgQEAgZW51bSBkc2Vfc3Rv cmVfc3RhdHVzCiBkc2Vfc3RvcmVfc3RhdHVzIGRzZV9jbGFzc2lmeV9zdG9y ZSAoYW9fcmVmICosIGdpbXBsZSAqLCBib29sLCBzYml0bWFwLAogCQkJCSAg ICAgYm9vbCAqID0gTlVMTCwgdHJlZSA9IE5VTEwpOwogCi12b2lkIGRlbGV0 ZV9kZWFkX29yX3JlZHVuZGFudF9hc3NpZ25tZW50IChnaW1wbGVfc3RtdF9p dGVyYXRvciAqLCBjb25zdCBjaGFyICopOwordm9pZCBkZWxldGVfZGVhZF9v cl9yZWR1bmRhbnRfYXNzaWdubWVudCAoZ2ltcGxlX3N0bXRfaXRlcmF0b3Ig KiwgY29uc3QgY2hhciAqLAorCQkJCQkgIGJpdG1hcCA9IE5VTEwpOwogCiAj ZW5kaWYgICAvKiBHQ0NfVFJFRV9TU0FfRFNFX0ggICovCg== --000000000000fee0e00595c19227--