From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by sourceware.org (Postfix) with ESMTPS id A43E13858D32 for ; Fri, 2 Dec 2022 07:22:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A43E13858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lj1-x233.google.com with SMTP id a7so4445682ljq.12 for ; Thu, 01 Dec 2022 23:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=qUTLqkdODCQqZRjnUH4hANppAgmux57gU7R6+VgTnfM=; b=w52NnSDCTuXQhNdCF8ezjfCGCzRA5fHskGnCbWuw1lzUG0AaQg1dBORslLUo+PCQJ9 5B6c3InnO5I9qMGvlswMznUmc6b3azKpmfYIlzxHLikFxGa6v9X6facL7h91KidRKA4t vsVCKtMdVIQXwYRm4NDVmM6SRs6dYSmUzMlAH+k1KsvtTtFaPdVTrh+YoccEyG7ZIYFI 1bzu2CWhZVubPsZJePTkZNLWSio2bPzPT60Zr1JOJtH9OImxtl7ATJl935ea0lw53tsu 4MExQh6OgMtOpCXf+JYFWMknBcjq0ZwMEoHRAZcr1Ed/jN4SudlV2BtC1G+MdW14bKoH 3y4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=qUTLqkdODCQqZRjnUH4hANppAgmux57gU7R6+VgTnfM=; b=MU7yTVd/3TLMxzQXgUFZ95K7bRUuRspl9gUFHRTzZW2LMMWhSI8ywEMyARGHw+v9Gq ucNbDbyykZJKzncrDEnm9yDvzQ74LFXzWA6Cq0DhEtrIFLLl5HrkEZEZHQlobS6HonS+ g4Dlyle2AbzCfsclYjbc7GgjsdRp4zHiUlnWhuSDtWZ3SQi/FhCgbRqSiH59FojGpV4m t3DirRQRSKFgQ+9uiVotfJx12EmKrlvhkWrUQ/6fezIPi5OZZeLSssh54b0yJEqG2tsk fr896m8zjx96Y/bUj+vRdL/MaYPKwyVk2DqIQQB0ityq7i39LMvY8LGIqIYxxBAz36W/ og+w== X-Gm-Message-State: ANoB5pmfCeucgk5muDMyu3d4dnEXNDyXuZs76VF6NafPwxhL2myA3IbN vaX9S0sa8OwbEROze2i3/WthZT6uDDJj5INdXxD6QQLU+51WSuAA X-Google-Smtp-Source: AA0mqf6T7tHfknfPkZ1/St9/N3XSg/XyQeuP/csarNvRc22dtTQFNDRO8Isk8seRyq+zhwmD/FuWvG4NN/cwnIqInJE= X-Received: by 2002:a2e:8ed8:0:b0:279:78e1:c7a4 with SMTP id e24-20020a2e8ed8000000b0027978e1c7a4mr14168355ljl.529.1669965734362; Thu, 01 Dec 2022 23:22:14 -0800 (PST) MIME-Version: 1.0 From: Prathamesh Kulkarni Date: Fri, 2 Dec 2022 12:51:37 +0530 Message-ID: Subject: [aarch64] PR107920 - Fix incorrect handling of virtual operands in svld1rq_impl::fold To: gcc Patches , Richard Sandiford Content-Type: multipart/mixed; boundary="00000000000062a5d205eed33206" X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000062a5d205eed33206 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, The following test: #include "arm_sve.h" svint8_t test_s8(int8_t *x) { return svld1rq_s8 (svptrue_b8 (), &x[0]); } ICE's with -march=3Darmv8.2-a+sve -O1 -fno-tree-ccp -fno-tree-forwprop: during GIMPLE pass: fre pr107920.c: In function =E2=80=98test_s8=E2=80=99: pr107920.c:7:1: internal compiler error: in execute_todo, at passes.cc:2140 7 | } | ^ 0x7b03d0 execute_todo ../../gcc/gcc/passes.cc:2140 because of incorrect handling of virtual operands in svld1rq_impl::fold: # VUSE <.MEM> _5 =3D MEM [(signed char * {ref-all})x_3(D)]; _4 =3D VEC_PERM_EXPR <_5, _5, { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, ... }>; # VUSE <.MEM_2(D)> return _4; The attached patch tries to fix the issue by building the replacement statements in gimple_seq, and passing it to gsi_replace_with_seq_vops, which resolves the ICE, and results in: : # VUSE <.MEM_2(D)> _5 =3D MEM [(signed char * {ref-all})x_3(D)]; _4 =3D VEC_PERM_EXPR <_5, _5, { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, ... }>; # VUSE <.MEM_2(D)> return _4; Bootstrapped+tested on aarch64-linux-gnu. OK to commit ? Thanks, Prathamesh --00000000000062a5d205eed33206 Content-Type: text/plain; charset="US-ASCII"; name="pr107920-4.txt" Content-Disposition: attachment; filename="pr107920-4.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lb66dc8q0 ZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYWFyY2g2NC9hYXJjaDY0LXN2ZS1idWlsdGlucy1iYXNl LmNjIGIvZ2NjL2NvbmZpZy9hYXJjaDY0L2FhcmNoNjQtc3ZlLWJ1aWx0aW5zLWJhc2UuY2MKaW5k ZXggNjM0NzQwNzU1NWYuLmY1NTQ2YTY1ZDIyIDEwMDY0NAotLS0gYS9nY2MvY29uZmlnL2FhcmNo NjQvYWFyY2g2NC1zdmUtYnVpbHRpbnMtYmFzZS5jYworKysgYi9nY2MvY29uZmlnL2FhcmNoNjQv YWFyY2g2NC1zdmUtYnVpbHRpbnMtYmFzZS5jYwpAQCAtNDUsNiArNDUsNyBAQAogI2luY2x1ZGUg ImFhcmNoNjQtc3ZlLWJ1aWx0aW5zLWJhc2UuaCIKICNpbmNsdWRlICJhYXJjaDY0LXN2ZS1idWls dGlucy1mdW5jdGlvbnMuaCIKICNpbmNsdWRlICJzc2EuaCIKKyNpbmNsdWRlICJnaW1wbGUtZm9s ZC5oIgogCiB1c2luZyBuYW1lc3BhY2UgYWFyY2g2NF9zdmU7CiAKQEAgLTEyMzIsNyArMTIzMyw5 IEBAIHB1YmxpYzoKIAl0cmVlIG1lbV9yZWZfb3AgPSBmb2xkX2J1aWxkMiAoTUVNX1JFRiwgYWNj ZXNzX3R5cGUsIGFyZzEsIHplcm8pOwogCWdpbXBsZSAqbWVtX3JlZl9zdG10CiAJICA9IGdpbXBs ZV9idWlsZF9hc3NpZ24gKG1lbV9yZWZfbGhzLCBtZW1fcmVmX29wKTsKLQlnc2lfaW5zZXJ0X2Jl Zm9yZSAoZi5nc2ksIG1lbV9yZWZfc3RtdCwgR1NJX1NBTUVfU1RNVCk7CisKKwlnaW1wbGVfc2Vx IHN0bXRzID0gTlVMTDsKKwlnaW1wbGVfc2VxX2FkZF9zdG10X3dpdGhvdXRfdXBkYXRlICgmc3Rt dHMsIG1lbV9yZWZfc3RtdCk7CiAKIAlpbnQgc291cmNlX25lbHRzID0gVFlQRV9WRUNUT1JfU1VC UEFSVFMgKGFjY2Vzc190eXBlKS50b19jb25zdGFudCAoKTsKIAl2ZWNfcGVybV9idWlsZGVyIHNl bCAobGhzX2xlbiwgc291cmNlX25lbHRzLCAxKTsKQEAgLTEyNDUsOCArMTI0OCwxMSBAQCBwdWJs aWM6CiAJCQkJCQkgICBpbmRpY2VzKSk7CiAJdHJlZSBtYXNrX3R5cGUgPSBidWlsZF92ZWN0b3Jf dHlwZSAoc3NpemV0eXBlLCBsaHNfbGVuKTsKIAl0cmVlIG1hc2sgPSB2ZWNfcGVybV9pbmRpY2Vz X3RvX3RyZWUgKG1hc2tfdHlwZSwgaW5kaWNlcyk7Ci0JcmV0dXJuIGdpbXBsZV9idWlsZF9hc3Np Z24gKGxocywgVkVDX1BFUk1fRVhQUiwKLQkJCQkgICAgbWVtX3JlZl9saHMsIG1lbV9yZWZfbGhz LCBtYXNrKTsKKwlnaW1wbGUgKmcyID0gZ2ltcGxlX2J1aWxkX2Fzc2lnbiAobGhzLCBWRUNfUEVS TV9FWFBSLAorCQkJCQkgIG1lbV9yZWZfbGhzLCBtZW1fcmVmX2xocywgbWFzayk7CisJZ2ltcGxl X3NlcV9hZGRfc3RtdF93aXRob3V0X3VwZGF0ZSAoJnN0bXRzLCBnMik7CisJZ3NpX3JlcGxhY2Vf d2l0aF9zZXFfdm9wcyAoZi5nc2ksIHN0bXRzKTsKKwlyZXR1cm4gZzI7CiAgICAgICB9CiAKICAg ICByZXR1cm4gTlVMTDsKZGlmZiAtLWdpdCBhL2djYy9naW1wbGUtZm9sZC5jYyBiL2djYy9naW1w bGUtZm9sZC5jYwppbmRleCBjMmQ5YzgwNmFlZS4uMDNjZGIyZjlmNDkgMTAwNjQ0Ci0tLSBhL2dj Yy9naW1wbGUtZm9sZC5jYworKysgYi9nY2MvZ2ltcGxlLWZvbGQuY2MKQEAgLTU5MSw3ICs1OTEs NyBAQCBmb2xkX2dpbXBsZV9hc3NpZ24gKGdpbXBsZV9zdG10X2l0ZXJhdG9yICpzaSkKICAgIElm IHRoZSBzdGF0ZW1lbnQgaGFzIGEgbGhzIHRoZSBsYXN0IHN0bXQgaW4gdGhlIHNlcXVlbmNlIGlz IGV4cGVjdGVkCiAgICB0byBhc3NpZ24gdG8gdGhhdCBsaHMuICAqLwogCi1zdGF0aWMgdm9pZAor dm9pZAogZ3NpX3JlcGxhY2Vfd2l0aF9zZXFfdm9wcyAoZ2ltcGxlX3N0bXRfaXRlcmF0b3IgKnNp X3AsIGdpbXBsZV9zZXEgc3RtdHMpCiB7CiAgIGdpbXBsZSAqc3RtdCA9IGdzaV9zdG10ICgqc2lf cCk7CmRpZmYgLS1naXQgYS9nY2MvZ2ltcGxlLWZvbGQuaCBiL2djYy9naW1wbGUtZm9sZC5oCmlu ZGV4IDdkMjllZTlhOWE0Li44N2VkNGU1NmQyNSAxMDA2NDQKLS0tIGEvZ2NjL2dpbXBsZS1mb2xk LmgKKysrIGIvZ2NjL2dpbXBsZS1mb2xkLmgKQEAgLTYzLDYgKzYzLDcgQEAgZXh0ZXJuIGJvb2wg YXJpdGhfY29kZV93aXRoX3VuZGVmaW5lZF9zaWduZWRfb3ZlcmZsb3cgKHRyZWVfY29kZSk7CiBl eHRlcm4gZ2ltcGxlX3NlcSByZXdyaXRlX3RvX2RlZmluZWRfb3ZlcmZsb3cgKGdpbXBsZSAqLCBi b29sID0gZmFsc2UpOwogZXh0ZXJuIHZvaWQgcmVwbGFjZV9jYWxsX3dpdGhfdmFsdWUgKGdpbXBs ZV9zdG10X2l0ZXJhdG9yICosIHRyZWUpOwogZXh0ZXJuIHRyZWUgdHJlZV92ZWNfZXh0cmFjdCAo Z2ltcGxlX3N0bXRfaXRlcmF0b3IgKiwgdHJlZSwgdHJlZSwgdHJlZSwgdHJlZSk7CitleHRlcm4g dm9pZCBnc2lfcmVwbGFjZV93aXRoX3NlcV92b3BzIChnaW1wbGVfc3RtdF9pdGVyYXRvciAqLCBn aW1wbGVfc2VxKTsKIAogLyogZ2ltcGxlX2J1aWxkLCBmdW5jdGlvbmFsbHkgbWF0Y2hpbmcgZm9s ZF9idWlsZE4sIG91dHB1dHMgc3RtdHMKICAgIGludCB0aGUgcHJvdmlkZWQgc2VxdWVuY2UsIG1h dGNoaW5nIGFuZCBzaW1wbGlmeWluZyB0aGVtIG9uLXRoZS1mbHkuCmRpZmYgLS1naXQgYS9nY2Mv dGVzdHN1aXRlL2djYy50YXJnZXQvYWFyY2g2NC9zdmUvYWNsZS9nZW5lcmFsL3ByMTA3OTIwLmMg Yi9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvYWFyY2g2NC9zdmUvYWNsZS9nZW5lcmFsL3ByMTA3 OTIwLmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjExNDQ4ZWQ1ZTY4 Ci0tLSAvZGV2L251bGwKKysrIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L2FhcmNoNjQvc3Zl L2FjbGUvZ2VuZXJhbC9wcjEwNzkyMC5jCkBAIC0wLDAgKzEsMTAgQEAKKy8qIHsgZGctZG8gY29t cGlsZSB9ICovCisvKiB7IGRnLW9wdGlvbnMgIi1PMSAtZm5vLXRyZWUtY2NwIC1mbm8tdHJlZS1m b3J3cHJvcCIgfSAqLworCisjaW5jbHVkZSAiYXJtX3N2ZS5oIgorCitzdmludDhfdAordGVzdF9z OChpbnQ4X3QgKngpCit7CisgIHJldHVybiBzdmxkMXJxX3M4IChzdnB0cnVlX2I4ICgpLCAmeFsw XSk7Cit9Cg== --00000000000062a5d205eed33206--