From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 1BFC639B3C16 for ; Thu, 29 Jul 2021 14:45:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BFC639B3C16 Received: by mail-ed1-x532.google.com with SMTP id da26so8605365edb.1 for ; Thu, 29 Jul 2021 07:45:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EmnfIrriSTrWTM0ekmK1+ArXQfslAgN7EE5+nImgyZ0=; b=AWU16XI6vwDmcsgM/coP2ZXyasQswgFp4UM+5CoApJrMNtkhP6Lu7o4wa0If71Q+MC PeTIzjA08AvC7VgYMkRnpt7sBYjzzeiOf2Vil5IQpUiX73MyP5E7C69MTQfMh6doWGhi 7W1JWlbpw9YgDTLcmWhTYjeZ+2Y3BJ6lTJBWpacZqP5yc5GZ6Ajs4yASLQ5I3lZ060uj 67X1S4VS3TF5EPwYpglP5iLHUxr+g0Muspur5TxHKfYXQauaagx/+v8O0+vrNjKNU2EY 1XoIZiVFP/WfJam2d/7gqOAJ7kHDBILdoqOnw0txnMceSYcGC7qDyXC/qqxb6O63sQax GlXw== X-Gm-Message-State: AOAM533Dit3/7hkjlQncJi3FgaNWduJbOhwcVljX+i5mofXD8sgZ1xDG lIjdlpFjCom5aEiGg3c3J6I+qR78aIT7CH9uDcU/zg== X-Google-Smtp-Source: ABdhPJwwzdJDpo65kXf1EXepVdUL99RN+tfy6mFrEW0k8qmtq00KbW5AErcLGPRhOdeGQZjzUv/wOWNNPQ8aB0P740Q= X-Received: by 2002:a05:6402:941:: with SMTP id h1mr2609544edz.371.1627569953033; Thu, 29 Jul 2021 07:45:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Prathamesh Kulkarni Date: Thu, 29 Jul 2021 20:15:16 +0530 Message-ID: Subject: Re: [ARM] PR66791: Replace builtins in vld1 To: Kyrylo Tkachov Cc: gcc Patches , Richard Earnshaw Content-Type: multipart/mixed; boundary="000000000000e6160505c84428bc" X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2021 14:45:58 -0000 --000000000000e6160505c84428bc Content-Type: text/plain; charset="UTF-8" On Thu, 29 Jul 2021 at 14:57, Kyrylo Tkachov wrote: > > Hi Prathamesh, > > > -----Original Message----- > > From: Prathamesh Kulkarni > > Sent: 26 July 2021 22:24 > > To: gcc Patches ; Kyrylo Tkachov > > ; Richard Earnshaw > > > > Subject: [ARM] PR66791: Replace builtins in vld1 > > > > Hi, > > Similar to aarch64, this patch replaces call to builtin by > > dereferencing __a in vld1_p64, vld1_s64 and vld1_u64. > > > > The patch changes code-gen for the intrinsic as follows: > > Before patch: > > vld1.64 {d16}, [r0:64] > > vmov r0, r1, d16 @ int > > bx lr > > > > After patch: > > ldrd r0, [r0] > > bx lr > > > > I assume the code-gen after patch is correct, since it loads two > > consecutive words from [r0] into r0 and r1 ? > > Yes, this looks correct. > > > > > Bootstrapped+tested on arm-linux-gnueabihf. > > OK to commit ? > > Ok. Can we now remove the vld1 builtin definition? Does the attached patch look OK ? I suppose we can only remove entry for di since the patch replaces calls to only __builtin_neon_vld1di ? Thanks, Prathamesh > Thanks, > Kyrill > > > > > Thanks, > > Prathamesh --000000000000e6160505c84428bc Content-Type: text/plain; charset="US-ASCII"; name="vld1-2.txt" Content-Disposition: attachment; filename="vld1-2.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_krp124ap0 Z2NjL0NoYW5nZUxvZzoKCglQUiB0YXJnZXQvNjY3OTEKCSogY29uZmlnL2FybS9hcm1fbmVvbi5o ICh2bGQxX3A2NCk6IFJlcGxhY2UgY2FsbCB0byBidWlsdGluIGJ5CglleHBsaWNpdGx5IGRlcmVm ZXJlbmNpbmcgX19hLgoJKHZsZDFfczY0KTogTGlrZXdpc2UuCgkodmxkMV91NjQpOiBMaWtld2lz ZS4KCSogY29uZmlnL2FybS9hcm1fbmVvbl9idWlsdGlucy5kZWYgKHZsZDEpOiBSZW1vdmUgZW50 cnkgZm9yIGRpCglhbmQgY2hhbmdlIHRvIFZBUjEzLgoKZGlmZiAtLWdpdCBhL2djYy9jb25maWcv YXJtL2FybV9uZW9uLmggYi9nY2MvY29uZmlnL2FybS9hcm1fbmVvbi5oCmluZGV4IDQxYjU5NmI1 ZmM2Li41YTkxZDE1YmY3NSAxMDA2NDQKLS0tIGEvZ2NjL2NvbmZpZy9hcm0vYXJtX25lb24uaAor KysgYi9nY2MvY29uZmlnL2FybS9hcm1fbmVvbi5oCkBAIC0xMDMwMSw3ICsxMDMwMSw3IEBAIF9f ZXh0ZW5zaW9uX18gZXh0ZXJuIF9faW5saW5lIHBvbHk2NHgxX3QKIF9fYXR0cmlidXRlX18gICgo X19hbHdheXNfaW5saW5lX18sIF9fZ251X2lubGluZV9fLCBfX2FydGlmaWNpYWxfXykpCiB2bGQx X3A2NCAoY29uc3QgcG9seTY0X3QgKiBfX2EpCiB7Ci0gIHJldHVybiAocG9seTY0eDFfdClfX2J1 aWx0aW5fbmVvbl92bGQxZGkgKChjb25zdCBfX2J1aWx0aW5fbmVvbl9kaSAqKSBfX2EpOworICBy ZXR1cm4gKHBvbHk2NHgxX3QpIHsgKl9fYSB9OwogfQogCiAjcHJhZ21hIEdDQyBwb3Bfb3B0aW9u cwpAQCAtMTAzMzAsNyArMTAzMzAsNyBAQCBfX2V4dGVuc2lvbl9fIGV4dGVybiBfX2lubGluZSBp bnQ2NHgxX3QKIF9fYXR0cmlidXRlX18gICgoX19hbHdheXNfaW5saW5lX18sIF9fZ251X2lubGlu ZV9fLCBfX2FydGlmaWNpYWxfXykpCiB2bGQxX3M2NCAoY29uc3QgaW50NjRfdCAqIF9fYSkKIHsK LSAgcmV0dXJuIChpbnQ2NHgxX3QpX19idWlsdGluX25lb25fdmxkMWRpICgoY29uc3QgX19idWls dGluX25lb25fZGkgKikgX19hKTsKKyAgcmV0dXJuIChpbnQ2NHgxX3QpIHsgKl9fYSB9OwogfQog CiAjaWYgZGVmaW5lZCAoX19BUk1fRlAxNl9GT1JNQVRfSUVFRSkgfHwgZGVmaW5lZCAoX19BUk1f RlAxNl9GT1JNQVRfQUxURVJOQVRJVkUpCkBAIC0xMDM3NCw3ICsxMDM3NCw3IEBAIF9fZXh0ZW5z aW9uX18gZXh0ZXJuIF9faW5saW5lIHVpbnQ2NHgxX3QKIF9fYXR0cmlidXRlX18gICgoX19hbHdh eXNfaW5saW5lX18sIF9fZ251X2lubGluZV9fLCBfX2FydGlmaWNpYWxfXykpCiB2bGQxX3U2NCAo Y29uc3QgdWludDY0X3QgKiBfX2EpCiB7Ci0gIHJldHVybiAodWludDY0eDFfdClfX2J1aWx0aW5f bmVvbl92bGQxZGkgKChjb25zdCBfX2J1aWx0aW5fbmVvbl9kaSAqKSBfX2EpOworICByZXR1cm4g KHVpbnQ2NHgxX3QpIHsgKl9fYSB9OwogfQogCiBfX2V4dGVuc2lvbl9fIGV4dGVybiBfX2lubGlu ZSBwb2x5OHg4X3QKZGlmZiAtLWdpdCBhL2djYy9jb25maWcvYXJtL2FybV9uZW9uX2J1aWx0aW5z LmRlZiBiL2djYy9jb25maWcvYXJtL2FybV9uZW9uX2J1aWx0aW5zLmRlZgppbmRleCA3MDQzOGFj MTg0OC4uZmI2ZDY2ZTU5NGEgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvYXJtL2FybV9uZW9uX2J1 aWx0aW5zLmRlZgorKysgYi9nY2MvY29uZmlnL2FybS9hcm1fbmVvbl9idWlsdGlucy5kZWYKQEAg LTMwMiw4ICszMDIsOCBAQCBWQVIxIChURVJOT1AsIHZ0YngxLCB2OHFpKQogVkFSMSAoVEVSTk9Q LCB2dGJ4MiwgdjhxaSkKIFZBUjEgKFRFUk5PUCwgdnRieDMsIHY4cWkpCiBWQVIxIChURVJOT1As IHZ0Yng0LCB2OHFpKQotVkFSMTQgKExPQUQxLCB2bGQxLAotICAgICAgICB2OHFpLCB2NGhpLCB2 NGhmLCB2MnNpLCB2MnNmLCBkaSwgdjE2cWksIHY4aGksIHY4aGYsIHY0c2ksIHY0c2YsIHYyZGks CitWQVIxMyAoTE9BRDEsIHZsZDEsCisgICAgICAgIHY4cWksIHY0aGksIHY0aGYsIHYyc2ksIHYy c2YsIHYxNnFpLCB2OGhpLCB2OGhmLCB2NHNpLCB2NHNmLCB2MmRpLAogICAgICAgICB2NGJmLCB2 OGJmKQogVkFSMTIgKExPQUQxTEFORSwgdmxkMV9sYW5lLAogCXY4cWksIHY0aGksIHYyc2ksIHYy c2YsIGRpLCB2MTZxaSwgdjhoaSwgdjRzaSwgdjRzZiwgdjJkaSwgdjRiZiwgdjhiZikK --000000000000e6160505c84428bc--