From: Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
To: gcc Patches <gcc-patches@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@arm.com>
Subject: [PING] set libfunc entry for sdivmod_optab to NULL in optabs.def
Date: Fri, 09 Sep 2016 22:05:00 -0000 [thread overview]
Message-ID: <CAAgBjMnw4qN=LgN1fSHtDp-boih1vSgzsxF8TYtXQQH=O3RijQ@mail.gmail.com> (raw)
Hi,
I would like to ping the following patch:
https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01015.html
While implementing divmod transform:
https://gcc.gnu.org/ml/gcc-patches/2016-05/msg01757.html
I ran into an issue with optab_libfunc().
It appears optab_libfunc (sdivmod_optab, mode) returns
bogus libfunc for unsupported modes, for instance
on x86_64, optab_libfunc (sdivmod_optab, DImode) returns
a libfunc with name "__divmoddi4", even though such a libfunc
does not exist in libgcc. This happens because in optabs.def
the libfunc entry for sdivmod_optab has gen_int_libfunc,
and call to optab_libfunc (sdivmo_optab, DImode) lazily
creates a bogus libfunc "__divmoddi4" by calling gen_int_libfunc().
To work around this issue I set libfunc entry for sdivmod_optab to NULL
and verified that optab_libfunc (sdivmod_optab, DImode) returns NULL_RTX
instead of a bogus libfunc if it's not overriden by the target.
Bootstrapped and tested on ppc64le-linux-gnu, x86_64-linux-gnu.
Cross tested on arm*-*-*, aarch64*-*-*.
OK for trunk ?
Thanks,
Prathamesh
next reply other threads:[~2016-09-09 22:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 22:05 Prathamesh Kulkarni [this message]
2016-09-15 0:21 ` Richard Sandiford
2016-09-15 3:08 ` Richard Sandiford
2016-09-15 10:53 ` Prathamesh Kulkarni
2016-09-15 12:12 ` Richard Sandiford
2016-09-15 12:16 ` Prathamesh Kulkarni
2016-09-15 12:42 ` Richard Biener
2016-09-16 11:31 ` Prathamesh Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAgBjMnw4qN=LgN1fSHtDp-boih1vSgzsxF8TYtXQQH=O3RijQ@mail.gmail.com' \
--to=prathamesh.kulkarni@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).