From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-316577-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22848 invoked by alias); 11 Apr 2012 13:36:05 -0000
Received: (qmail 22763 invoked by uid 22791); 11 Apr 2012 13:36:04 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Apr 2012 13:35:41 +0000
Received: by obbuo13 with SMTP id uo13so1405525obb.20        for <gcc-patches@gcc.gnu.org>; Wed, 11 Apr 2012 06:35:40 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.60.12.162 with SMTP id z2mr21767482oeb.47.1334151340666; Wed, 11 Apr 2012 06:35:40 -0700 (PDT)
Received: by 10.182.92.168 with HTTP; Wed, 11 Apr 2012 06:35:40 -0700 (PDT)
In-Reply-To: <m3aa2i3api.fsf@redhat.com>
References: <m3hawr8wpz.fsf@redhat.com>	<m3aa2i3api.fsf@redhat.com>
Date: Wed, 11 Apr 2012 13:36:00 -0000
Message-ID: <CAAiZkiBoqBceV6nRogOYBp2OO5ODiQWinsAjtpxPC2PW2nXUfg@mail.gmail.com>
Subject: Re: [PATCH 09/11] Fix va_arg type location
From: Gabriel Dos Reis <gdr@integrable-solutions.net>
To: Dodji Seketeli <dodji@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Tom Tromey <tromey@redhat.com>, 	Jason Merrill <jason@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-04/txt/msg00639.txt.bz2

On Wed, Apr 11, 2012 at 3:59 AM, Dodji Seketeli <dodji@redhat.com> wrote:
> Now that diagnostics first point to the spelling location of tokens
> coming from macro expansion, the test case
> gcc/testsuite/g++.old-deja/g++.other/vaarg3.C shows that when I write
> va_args (args, some_type), the location that is recorded for
> "some_type" is not correct. =A0We wrongly record a location that is in
> the system header where the va_args macro is defined.
>
> This patch changes that to correctly record the location for the type
> operand of the va_arg expression.
>
> With this patch applied, the
> gcc/testsuite/g++.old-deja/g++.other/vaarg3.C test PASSes with and
> without -ftrack-macro-expansion.
>
> Tested on x86_64-unknown-linux-gnu against trunk.
>
> Note that the bootstrap with -ftrack-macro-expansion exhibits other
> separate issues that are addressed in subsequent patches. =A0This patch
> just fixes one class of problems.
>
> The patch does pass bootstrap with -ftrack-macro-expansion turned off,
> though.

OK.