From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17802 invoked by alias); 26 Apr 2013 02:18:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17779 invoked by uid 89); 26 Apr 2013 02:18:00 -0000 X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ee0-f41.google.com (HELO mail-ee0-f41.google.com) (74.125.83.41) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 26 Apr 2013 02:17:59 +0000 Received: by mail-ee0-f41.google.com with SMTP id c50so1163489eek.14 for ; Thu, 25 Apr 2013 19:17:57 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.14.149.141 with SMTP id x13mr82380524eej.31.1366942677320; Thu, 25 Apr 2013 19:17:57 -0700 (PDT) Received: by 10.14.210.199 with HTTP; Thu, 25 Apr 2013 19:17:57 -0700 (PDT) In-Reply-To: <20130425222248.GN28963@tucnak.redhat.com> References: <20130425222248.GN28963@tucnak.redhat.com> Date: Fri, 26 Apr 2013 11:01:00 -0000 Message-ID: Subject: Re: Patch ping From: Gabriel Dos Reis To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-04/txt/msg01586.txt.bz2 On Thu, Apr 25, 2013 at 5:22 PM, Jakub Jelinek wrote: > Hi! > > I'd like to ping 2 color diagnostics patches: > > - http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00787.html > colorize filename using locus color even when printed > without :line:column you should declare the variables locus_cs and locus_ce with initializers, instead of declaration followed by assignments. OK with those changes. > > - http://gcc.gnu.org/ml/gcc-patches/2013-04/msg00923.html > make -fdiagnostics-color=auto the default if GCC_COLORS > env var is in environment This patch is OK. Thanks! > > Jakub