* [PING] [C++ Patch] Remove finish_stmt
@ 2013-08-01 9:51 Paolo Carlini
2013-08-01 23:42 ` Gabriel Dos Reis
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Carlini @ 2013-08-01 9:51 UTC (permalink / raw)
To: gcc-patches; +Cc: Jason Merrill
Hi,
gently pinging this small clean-up:
http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00905.html
Thanks!
Paolo.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PING] [C++ Patch] Remove finish_stmt
2013-08-01 9:51 [PING] [C++ Patch] Remove finish_stmt Paolo Carlini
@ 2013-08-01 23:42 ` Gabriel Dos Reis
2013-08-02 7:37 ` Paolo Carlini
0 siblings, 1 reply; 4+ messages in thread
From: Gabriel Dos Reis @ 2013-08-01 23:42 UTC (permalink / raw)
To: Paolo Carlini; +Cc: gcc-patches, Jason Merrill
2013/8/1 Paolo Carlini <paolo.carlini@oracle.com>:
> Hi,
>
> gently pinging this small clean-up:
>
> http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00905.html
>
> Thanks!
> Paolo.
It was supposed to provide symmetry and a good place to
put any "cleanup" code we might want to run, but that
never materialized, and now that we are using C++, we
are better abstraction tools. So, it can go.
Patch OK.
-- Gaby
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PING] [C++ Patch] Remove finish_stmt
2013-08-01 23:42 ` Gabriel Dos Reis
@ 2013-08-02 7:37 ` Paolo Carlini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Carlini @ 2013-08-02 7:37 UTC (permalink / raw)
To: Gabriel Dos Reis; +Cc: gcc-patches, Jason Merrill
On 08/02/2013 01:42 AM, Gabriel Dos Reis wrote:
> 2013/8/1 Paolo Carlini <paolo.carlini@oracle.com>:
>> Hi,
>>
>> gently pinging this small clean-up:
>>
>> http://gcc.gnu.org/ml/gcc-patches/2013-06/msg00905.html
>>
>> Thanks!
>> Paolo.
> It was supposed to provide symmetry and a good place to
> put any "cleanup" code we might want to run, but that
> never materialized, and now that we are using C++, we
> are better abstraction tools. So, it can go.
Ah now I see, thanks. I'm going to apply the patch then.
Thanks again,
Paolo.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [C++ Patch] Remove finish_stmt
@ 2013-06-16 17:21 Paolo Carlini
2013-06-27 10:04 ` [PING] " Paolo Carlini
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Carlini @ 2013-06-16 17:21 UTC (permalink / raw)
To: gcc-patches; +Cc: Jason Merrill
[-- Attachment #1: Type: text/plain, Size: 110 bytes --]
Hi,
lately doesn't appear to accomplish much. Tested x86_64-linux.
Thanks,
Paolo.
////////////////////////
[-- Attachment #2: CL_fs --]
[-- Type: text/plain, Size: 477 bytes --]
2013-06-17 Paolo Carlini <paolo.carlini@oracle.com>
* cp-tree.h (finish_stmt): Do not declare.
* decl.c (finish_stmt): Do not define.
* parser.c (cp_parser_expression_statement,
cp_parser_declaration_statement,
cp_parser_transaction_cancel): Don't call finish_stmt.
* semantics.c (finish_expr_stmt, finish_if_stmt,
finish_while_stmt, finish_do_stmt, finish_return_stmt,
finish_for_stmt, finish_switch_stmt, finish_compound_stmt,
finish_transaction_stmt): Likewise.
[-- Attachment #3: patch_fs --]
[-- Type: text/plain, Size: 4051 bytes --]
Index: cp-tree.h
===================================================================
--- cp-tree.h (revision 200134)
+++ cp-tree.h (working copy)
@@ -5212,7 +5212,6 @@ extern tree grokmethod (cp_decl_specifier_seq *
extern void maybe_register_incomplete_var (tree);
extern void maybe_commonize_var (tree);
extern void complete_vars (tree);
-extern void finish_stmt (void);
extern tree static_fn_type (tree);
extern void revert_static_member_fn (tree);
extern void fixup_anonymous_aggr (tree);
Index: decl.c
===================================================================
--- decl.c (revision 200134)
+++ decl.c (working copy)
@@ -14273,13 +14273,6 @@ cxx_maybe_build_cleanup (tree decl, tsubst_flags_t
}
\f
-/* When a stmt has been parsed, this function is called. */
-
-void
-finish_stmt (void)
-{
-}
-
/* Return the FUNCTION_TYPE that corresponds to MEMFNTYPE, which can be a
FUNCTION_DECL, METHOD_TYPE, FUNCTION_TYPE, pointer or reference to
METHOD_TYPE or FUNCTION_TYPE, or pointer to member function. */
Index: parser.c
===================================================================
--- parser.c (revision 200134)
+++ parser.c (working copy)
@@ -9295,8 +9295,6 @@ cp_parser_expression_statement (cp_parser* parser,
statement = finish_stmt_expr_expr (statement, in_statement_expr);
else if (statement)
statement = finish_expr_stmt (statement);
- else
- finish_stmt ();
return statement;
}
@@ -10351,9 +10349,6 @@ cp_parser_declaration_statement (cp_parser* parser
/* Free any declarators allocated. */
obstack_free (&declarator_obstack, p);
-
- /* Finish off the statement. */
- finish_stmt ();
}
/* Some dependent statements (like `if (cond) statement'), are
@@ -28410,7 +28405,6 @@ cp_parser_transaction_cancel (cp_parser *parser)
stmt = build_tm_abort_call (token->location, is_outer);
add_stmt (stmt);
- finish_stmt ();
return stmt;
}
Index: semantics.c
===================================================================
--- semantics.c (revision 200134)
+++ semantics.c (working copy)
@@ -630,8 +630,6 @@ finish_expr_stmt (tree expr)
r = add_stmt (expr);
}
- finish_stmt ();
-
return r;
}
@@ -696,7 +694,6 @@ finish_if_stmt (tree if_stmt)
tree scope = IF_SCOPE (if_stmt);
IF_SCOPE (if_stmt) = NULL;
add_stmt (do_poplevel (scope));
- finish_stmt ();
}
/* Begin a while-statement. Returns a newly created WHILE_STMT if
@@ -729,7 +726,6 @@ void
finish_while_stmt (tree while_stmt)
{
WHILE_BODY (while_stmt) = do_poplevel (WHILE_BODY (while_stmt));
- finish_stmt ();
}
/* Begin a do-statement. Returns a newly created DO_STMT if
@@ -767,7 +763,6 @@ finish_do_stmt (tree cond, tree do_stmt)
{
cond = maybe_convert_cond (cond);
DO_COND (do_stmt) = cond;
- finish_stmt ();
}
/* Finish a return-statement. The EXPRESSION returned, if any, is as
@@ -804,7 +799,6 @@ finish_return_stmt (tree expr)
TREE_NO_WARNING (r) |= no_warning;
r = maybe_cleanup_point_expr_void (r);
r = add_stmt (r);
- finish_stmt ();
return r;
}
@@ -930,8 +924,6 @@ finish_for_stmt (tree for_stmt)
*scope_ptr = NULL;
add_stmt (do_poplevel (scope));
}
-
- finish_stmt ();
}
/* Begin a range-for-statement. Returns a new RANGE_FOR_STMT.
@@ -1065,7 +1057,6 @@ finish_switch_stmt (tree switch_stmt)
SWITCH_STMT_BODY (switch_stmt) =
pop_stmt_list (SWITCH_STMT_BODY (switch_stmt));
pop_switch ();
- finish_stmt ();
scope = SWITCH_STMT_SCOPE (switch_stmt);
SWITCH_STMT_SCOPE (switch_stmt) = NULL;
@@ -1287,7 +1278,6 @@ finish_compound_stmt (tree stmt)
/* ??? See c_end_compound_stmt wrt statement expressions. */
add_stmt (stmt);
- finish_stmt ();
}
/* Finish an asm-statement, whose components are a STRING, some
@@ -5197,7 +5187,6 @@ finish_transaction_stmt (tree stmt, tree compound_
if (compound_stmt)
finish_compound_stmt (compound_stmt);
- finish_stmt ();
}
/* Build a __transaction_atomic or __transaction_relaxed expression. If
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PING] [C++ Patch] Remove finish_stmt
2013-06-16 17:21 Paolo Carlini
@ 2013-06-27 10:04 ` Paolo Carlini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Carlini @ 2013-06-27 10:04 UTC (permalink / raw)
To: Paolo Carlini; +Cc: gcc-patches, Jason Merrill
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
Hi,
On 06/16/2013 07:21 PM, Paolo Carlini wrote:
> Hi,
>
> lately doesn't appear to accomplish much. Tested x86_64-linux.
pinging this clean-up (before I forget ;)
Thanks!
Paolo.
/////////////////////
[-- Attachment #2: CL_fs --]
[-- Type: text/plain, Size: 477 bytes --]
2013-06-17 Paolo Carlini <paolo.carlini@oracle.com>
* cp-tree.h (finish_stmt): Do not declare.
* decl.c (finish_stmt): Do not define.
* parser.c (cp_parser_expression_statement,
cp_parser_declaration_statement,
cp_parser_transaction_cancel): Don't call finish_stmt.
* semantics.c (finish_expr_stmt, finish_if_stmt,
finish_while_stmt, finish_do_stmt, finish_return_stmt,
finish_for_stmt, finish_switch_stmt, finish_compound_stmt,
finish_transaction_stmt): Likewise.
[-- Attachment #3: patch_fs --]
[-- Type: text/plain, Size: 4051 bytes --]
Index: cp-tree.h
===================================================================
--- cp-tree.h (revision 200134)
+++ cp-tree.h (working copy)
@@ -5212,7 +5212,6 @@ extern tree grokmethod (cp_decl_specifier_seq *
extern void maybe_register_incomplete_var (tree);
extern void maybe_commonize_var (tree);
extern void complete_vars (tree);
-extern void finish_stmt (void);
extern tree static_fn_type (tree);
extern void revert_static_member_fn (tree);
extern void fixup_anonymous_aggr (tree);
Index: decl.c
===================================================================
--- decl.c (revision 200134)
+++ decl.c (working copy)
@@ -14273,13 +14273,6 @@ cxx_maybe_build_cleanup (tree decl, tsubst_flags_t
}
\f
-/* When a stmt has been parsed, this function is called. */
-
-void
-finish_stmt (void)
-{
-}
-
/* Return the FUNCTION_TYPE that corresponds to MEMFNTYPE, which can be a
FUNCTION_DECL, METHOD_TYPE, FUNCTION_TYPE, pointer or reference to
METHOD_TYPE or FUNCTION_TYPE, or pointer to member function. */
Index: parser.c
===================================================================
--- parser.c (revision 200134)
+++ parser.c (working copy)
@@ -9295,8 +9295,6 @@ cp_parser_expression_statement (cp_parser* parser,
statement = finish_stmt_expr_expr (statement, in_statement_expr);
else if (statement)
statement = finish_expr_stmt (statement);
- else
- finish_stmt ();
return statement;
}
@@ -10351,9 +10349,6 @@ cp_parser_declaration_statement (cp_parser* parser
/* Free any declarators allocated. */
obstack_free (&declarator_obstack, p);
-
- /* Finish off the statement. */
- finish_stmt ();
}
/* Some dependent statements (like `if (cond) statement'), are
@@ -28410,7 +28405,6 @@ cp_parser_transaction_cancel (cp_parser *parser)
stmt = build_tm_abort_call (token->location, is_outer);
add_stmt (stmt);
- finish_stmt ();
return stmt;
}
Index: semantics.c
===================================================================
--- semantics.c (revision 200134)
+++ semantics.c (working copy)
@@ -630,8 +630,6 @@ finish_expr_stmt (tree expr)
r = add_stmt (expr);
}
- finish_stmt ();
-
return r;
}
@@ -696,7 +694,6 @@ finish_if_stmt (tree if_stmt)
tree scope = IF_SCOPE (if_stmt);
IF_SCOPE (if_stmt) = NULL;
add_stmt (do_poplevel (scope));
- finish_stmt ();
}
/* Begin a while-statement. Returns a newly created WHILE_STMT if
@@ -729,7 +726,6 @@ void
finish_while_stmt (tree while_stmt)
{
WHILE_BODY (while_stmt) = do_poplevel (WHILE_BODY (while_stmt));
- finish_stmt ();
}
/* Begin a do-statement. Returns a newly created DO_STMT if
@@ -767,7 +763,6 @@ finish_do_stmt (tree cond, tree do_stmt)
{
cond = maybe_convert_cond (cond);
DO_COND (do_stmt) = cond;
- finish_stmt ();
}
/* Finish a return-statement. The EXPRESSION returned, if any, is as
@@ -804,7 +799,6 @@ finish_return_stmt (tree expr)
TREE_NO_WARNING (r) |= no_warning;
r = maybe_cleanup_point_expr_void (r);
r = add_stmt (r);
- finish_stmt ();
return r;
}
@@ -930,8 +924,6 @@ finish_for_stmt (tree for_stmt)
*scope_ptr = NULL;
add_stmt (do_poplevel (scope));
}
-
- finish_stmt ();
}
/* Begin a range-for-statement. Returns a new RANGE_FOR_STMT.
@@ -1065,7 +1057,6 @@ finish_switch_stmt (tree switch_stmt)
SWITCH_STMT_BODY (switch_stmt) =
pop_stmt_list (SWITCH_STMT_BODY (switch_stmt));
pop_switch ();
- finish_stmt ();
scope = SWITCH_STMT_SCOPE (switch_stmt);
SWITCH_STMT_SCOPE (switch_stmt) = NULL;
@@ -1287,7 +1278,6 @@ finish_compound_stmt (tree stmt)
/* ??? See c_end_compound_stmt wrt statement expressions. */
add_stmt (stmt);
- finish_stmt ();
}
/* Finish an asm-statement, whose components are a STRING, some
@@ -5197,7 +5187,6 @@ finish_transaction_stmt (tree stmt, tree compound_
if (compound_stmt)
finish_compound_stmt (compound_stmt);
- finish_stmt ();
}
/* Build a __transaction_atomic or __transaction_relaxed expression. If
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-02 7:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-01 9:51 [PING] [C++ Patch] Remove finish_stmt Paolo Carlini
2013-08-01 23:42 ` Gabriel Dos Reis
2013-08-02 7:37 ` Paolo Carlini
-- strict thread matches above, loose matches on Subject: below --
2013-06-16 17:21 Paolo Carlini
2013-06-27 10:04 ` [PING] " Paolo Carlini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).