From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30313 invoked by alias); 20 Jun 2013 05:30:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30300 invoked by uid 89); 20 Jun 2013 05:30:36 -0000 X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ee0-f44.google.com (HELO mail-ee0-f44.google.com) (74.125.83.44) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 20 Jun 2013 05:30:35 +0000 Received: by mail-ee0-f44.google.com with SMTP id c13so3672570eek.31 for ; Wed, 19 Jun 2013 22:30:33 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.14.32.197 with SMTP id o45mr5776013eea.9.1371706233239; Wed, 19 Jun 2013 22:30:33 -0700 (PDT) Received: by 10.15.36.71 with HTTP; Wed, 19 Jun 2013 22:30:32 -0700 (PDT) In-Reply-To: <51C1BE59.6040400@redhat.com> References: <51B0B0ED.5090508@redhat.com> <51B0F122.6020301@redhat.com> <51B62961.1080409@redhat.com> <51B8A36C.1080005@redhat.com> <51BBC613.5040708@redhat.com> <51BF617D.3080101@redhat.com> <51C1BE59.6040400@redhat.com> Date: Thu, 20 Jun 2013 05:30:00 -0000 Message-ID: Subject: Re: [c++-concepts] code review From: Gabriel Dos Reis To: Jason Merrill , Gabriel Dos Reis Cc: Andrew Sutton , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-06/txt/msg01182.txt.bz2 On Wed, Jun 19, 2013 at 9:21 AM, Jason Merrill wrote: > On 06/18/2013 12:27 PM, Andrew Sutton wrote: >> >> There was a bug in instantiation_dependent_expr_r that would cause >> trait expressions like __is_class(int) to be marked as type dependent. >> It was always testing the 2nd operand, even for unary traits >> (NULL_TREE turns out to be type dependent). > > > I fixed that last month: > > 2013-05-20 Jason Merrill > > PR c++/57016 > * pt.c (instantiation_dependent_r) [TRAIT_EXPR]: Only check > type2 if there is one. The last merge to c++-concepts was a little bit before that (2013-06-16), so the fix wasn't on the branch. As I discussed with Andrew a couple of weeks ago, I have been holding back the merge from trunk because he has these patch series in the queue. That also means we don't get these sort of fixes before a while. Maybe I should just go ahead with the merge so that we have conflicts, and potentially less duplication of work in terms of fixing the compiler. -- Gaby