From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13313 invoked by alias); 12 Jun 2013 15:53:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13304 invoked by uid 89); 12 Jun 2013 15:53:03 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=ham version=3.3.1 Received: from mail-ea0-f171.google.com (HELO mail-ea0-f171.google.com) (209.85.215.171) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 12 Jun 2013 15:53:02 +0000 Received: by mail-ea0-f171.google.com with SMTP id m14so7199810eaj.30 for ; Wed, 12 Jun 2013 08:53:00 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.14.32.197 with SMTP id o45mr22472795eea.9.1371052380208; Wed, 12 Jun 2013 08:53:00 -0700 (PDT) Received: by 10.15.36.71 with HTTP; Wed, 12 Jun 2013 08:53:00 -0700 (PDT) In-Reply-To: <51B62961.1080409@redhat.com> References: <51B0B0ED.5090508@redhat.com> <51B0F122.6020301@redhat.com> <51B62961.1080409@redhat.com> Date: Wed, 12 Jun 2013 15:53:00 -0000 Message-ID: Subject: Re: [c++-concepts] code review From: Gabriel Dos Reis To: Jason Merrill Cc: Andrew Sutton , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-SW-Source: 2013-06/txt/msg00698.txt.bz2 On Mon, Jun 10, 2013 at 2:30 PM, Jason Merrill wrote: > On 06/08/2013 09:34 AM, Andrew Sutton wrote: >> >> I think I previously put constraint_info in lang_decl_min, right next >> to template_info no less. It was easy to manage there, and initialized >> as part of build_template_decl. But this obviously doesn't work for >> partial specializations unless they get template_decls. > > > Right. And we would want it to be specific to template_decls, not all decls > that use lang_decl_min. yes, exactly my feedback on the original implementation. I am still surprised though that we don't generate TEMPLATE_DECLs for partial instantiations (since they are still morally templates.) -- Gaby