From: Xinliang David Li <davidxl@google.com>
To: Rong Xu <xur@google.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
reply@codereview-hr.appspotmail.com
Subject: Re: [google 4.7] fdo build for linux kernel (issue 6968046)
Date: Thu, 20 Dec 2012 19:55:00 -0000 [thread overview]
Message-ID: <CAAkRFZ+5hctrEye0tJd0QES6KX5MV6a8a-GTyi1GhfqdWFowbA@mail.gmail.com> (raw)
In-Reply-To: <CAF1bQ=Qrs_y6FMpw4gaeNBiiywxzUhfedcn12bjM5J_4ufM5rg@mail.gmail.com>
It depends on the value distribution .
David
On Thu, Dec 20, 2012 at 11:30 AM, Rong Xu <xur@google.com> wrote:
> On Wed, Dec 19, 2012 at 5:22 PM, Rong Xu <xur@google.com> wrote:
>> On Wed, Dec 19, 2012 at 5:04 PM, <davidxl@google.com> wrote:
>>> The change in gcov-io.h is from a different patch.
>>
>> sorry. here is the patch for gcov-io.h:
>>
>> Index: gcov-io.h
>> ===================================================================
>> --- gcov-io.h (revision 194562)
>> +++ gcov-io.h (working copy)
>> @@ -781,8 +781,8 @@
>> unused) */
>>
>> unsigned n_functions; /* number of functions */
>> - const struct gcov_fn_info *const *functions; /* pointer to pointers
>> - to function information */
>> + const struct gcov_fn_info **functions; /* pointer to pointers
>> + to function information */
>> };
>>
>> /* Information about a single imported module. */
>> @@ -988,8 +988,7 @@
>> GCOV_LINKAGE void gcov_seek (gcov_position_t /*position*/) ATTRIBUTE_HIDDEN;
>> GCOV_LINKAGE void gcov_truncate (void) ATTRIBUTE_HIDDEN;
>> GCOV_LINKAGE gcov_unsigned_t gcov_string_length (const char *)
>> ATTRIBUTE_HIDDEN;
>> -GCOV_LINKAGE unsigned gcov_gcda_file_size (struct gcov_info *,
>> - struct gcov_summary *);
>> +GCOV_LINKAGE unsigned gcov_gcda_file_size (struct gcov_info *);
>> #else
>> /* Available outside libgcov */
>> GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/,
>>
>>>
>>> David
>>>
>>>
>>> https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c
>>> File gcc/gcov-io.c (right):
>>>
>>> https://codereview.appspot.com/6968046/diff/1/gcc/gcov-io.c#newcode688
>>> gcc/gcov-io.c:688:
>>> Have you compared this with this impl:
>>>
>>> while (x)
>>> {
>>> c++;
>>> x&=(x-1)
>>> }
>>> return c;
>>>
>>
>> I did not try this pimplier version. I can do a test on the dump speed
>> and report back.
>
> This simpler version is about 2% slow in dumping the profiles (average
> of 10 dumps). But this is not a big deal.
> I'll use this this version.
>
> -Rong
>
>>
>>> https://codereview.appspot.com/6968046/
next prev parent reply other threads:[~2012-12-20 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-20 1:04 davidxl
2012-12-20 1:22 ` Rong Xu
2012-12-20 19:30 ` Rong Xu
2012-12-20 19:55 ` Xinliang David Li [this message]
2012-12-20 22:01 ` Rong Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAkRFZ+5hctrEye0tJd0QES6KX5MV6a8a-GTyi1GhfqdWFowbA@mail.gmail.com \
--to=davidxl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview-hr.appspotmail.com \
--cc=xur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).