* [google gcc-4_8] Force cmd-line match for option -ansi in LIPO use
@ 2013-07-30 21:16 Rong Xu
2013-07-30 21:24 ` Xinliang David Li
0 siblings, 1 reply; 2+ messages in thread
From: Rong Xu @ 2013-07-30 21:16 UTC (permalink / raw)
To: David Li, GCC Patches
The following patch forces the command line match for -ansi option
in LIPO use build. Otherwise, it gets various undefined symbol errors.
This is exposed in LIPO random grouping test.
Tested with google internal benchmarks and gcc regression test.
2013-07-30 Rong Xu <xur@google.com>
* gcc/coverage.c (force_matching_cg_opts): require
cmd line match on -ansi option in LIPO use build.
Index: gcc/coverage.c
===================================================================
--- gcc/coverage.c (revision 201219)
+++ gcc/coverage.c (working copy)
@@ -263,6 +263,7 @@ static struct opt_desc force_matching_cg_opts[] =
{ "-fsized-delete", "-fno-sized-delete", false },
{ "-frtti", "-fno-rtti", true },
{ "-fstrict-aliasing", "-fno-strict-aliasing", true },
+ { "-ansi", "", false },
{ NULL, NULL, false }
};
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [google gcc-4_8] Force cmd-line match for option -ansi in LIPO use
2013-07-30 21:16 [google gcc-4_8] Force cmd-line match for option -ansi in LIPO use Rong Xu
@ 2013-07-30 21:24 ` Xinliang David Li
0 siblings, 0 replies; 2+ messages in thread
From: Xinliang David Li @ 2013-07-30 21:24 UTC (permalink / raw)
To: Rong Xu; +Cc: GCC Patches
On Tue, Jul 30, 2013 at 1:44 PM, Rong Xu <xur@google.com> wrote:
> The following patch forces the command line match for -ansi option
> in LIPO use build. Otherwise, it gets various undefined symbol errors.
Parsing error as you have clarified.
> This is exposed in LIPO random grouping test.
>
> Tested with google internal benchmarks and gcc regression test.
>
> 2013-07-30 Rong Xu <xur@google.com>
>
> * gcc/coverage.c (force_matching_cg_opts): require
> cmd line match on -ansi option in LIPO use build.
>
> Index: gcc/coverage.c
> ===================================================================
> --- gcc/coverage.c (revision 201219)
> +++ gcc/coverage.c (working copy)
> @@ -263,6 +263,7 @@ static struct opt_desc force_matching_cg_opts[] =
> { "-fsized-delete", "-fno-sized-delete", false },
> { "-frtti", "-fno-rtti", true },
> { "-fstrict-aliasing", "-fno-strict-aliasing", true },
> + { "-ansi", "", false },
> { NULL, NULL, false }
> };
Ok for google branch.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-30 21:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-30 21:16 [google gcc-4_8] Force cmd-line match for option -ansi in LIPO use Rong Xu
2013-07-30 21:24 ` Xinliang David Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).