From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6128 invoked by alias); 13 May 2014 15:19:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6114 invoked by uid 89); 13 May 2014 15:19:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f173.google.com Received: from mail-we0-f173.google.com (HELO mail-we0-f173.google.com) (74.125.82.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 13 May 2014 15:19:56 +0000 Received: by mail-we0-f173.google.com with SMTP id u57so553815wes.32 for ; Tue, 13 May 2014 08:19:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=DK79Q831Lbgks1VkIAWo56n+8KdfZfG4gXavlRdWbEw=; b=C5QgHrxNbMggPrVlpvJHTSr1vxyuBWi/qs+uLmsJk1eoiEY2fSGGuG1g5Xdc2BHFdU /6EZ4m4Pst8A0bSpsL6d9LcaF12UWbmfTBEyeIG3S+UzSWy5PNWa7Pi+KfoQXMo+wP88 ay/+xs8QwJEvpBCHTGLn6lRfQSiHN5w1fcgJqXl9nCUb/RGpb9FoXMDkI//XTEOV24EK NtnS0jyQNIPn7Ormu15LMdSPtwkjaE3fOtPdpYrY8jbqfHo5XB3cC+vGdRBGyLT2EneZ dOJwkjoFggaYZcJ4B/BfZL0p9Y/X/wKkTlwKMn9e7n87+ykD/khi9qWfG1qItUxe2Cxv WVjA== X-Gm-Message-State: ALoCoQki0PyFj0nnszGQdeaImYEcfcJFIb4fd4xKupvkicHoK2aWwhb2Kz+W/beZwB38joJ57BCM MIME-Version: 1.0 X-Received: by 10.194.88.106 with SMTP id bf10mr27781610wjb.26.1399994393073; Tue, 13 May 2014 08:19:53 -0700 (PDT) Received: by 10.180.86.1 with HTTP; Tue, 13 May 2014 08:19:52 -0700 (PDT) In-Reply-To: References: Date: Tue, 13 May 2014 15:19:00 -0000 Message-ID: Subject: Re: [PATCH] Add missing -fdump-* options From: Xinliang David Li To: Richard Biener Cc: Teresa Johnson , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00979.txt.bz2 On Tue, May 13, 2014 at 1:39 AM, Richard Biener wrote: > On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson wrote: >> I discovered that the support for the documented -fdump-* options >> "optimized", "missed", "note" and "optall" was missing. Added that and >> fixed a minor typo in the documentation. >> >> Bootstrapped and tested on x86-64-unknown-linux-gnu. Ok for trunk? > > I'm not sure they were intented for user-consumption. ISTR they > are just an implementation detail exposed by -fopt-info-X (which is > where they are documented). > > The typo fix is ok, also adding a comment before the dump flags > definition to the above fact. > > David, do I remember correctly? I remember we talked about content filtering dump flags. Things like -fdump-xxx-ir <-- dump IR only -fdump-xxx-transformation <-- optimization note -fdump-xxx-debug <-- other debug traces Other than that, now I think 'details' and 'all' seem redundant. 'verbose' flag/modifier can achieve the same effect depending on the context. -fdump-xxx-ir-verbose <-- dump IR, and turn on IR modifiers such as vops, lineno, etc -fdump-xxx-transforamtion-verbose <-- dump transformations + missed optimizations + notes -fdump-xxx-debug-verbose <-- turn on detailed trace. thanks, David > > Thanks, > Richard. > >> Thanks, >> Teresa >> >> 2014-05-09 Teresa Johnson >> >> * doc/invoke.texi: Fix typo. >> * dumpfile.c: Add support for documented -fdump-* options >> optimized/missed/note/optall. >> >> Index: doc/invoke.texi >> =================================================================== >> --- doc/invoke.texi (revision 210157) >> +++ doc/invoke.texi (working copy) >> @@ -6278,7 +6278,7 @@ passes). >> @item missed >> Enable showing missed optimization information (only available in certain >> passes). >> -@item notes >> +@item note >> Enable other detailed optimization information (only available in >> certain passes). >> @item =@var{filename} >> Index: dumpfile.c >> =================================================================== >> --- dumpfile.c (revision 210157) >> +++ dumpfile.c (working copy) >> @@ -107,6 +107,10 @@ static const struct dump_option_value_info dump_op >> {"nouid", TDF_NOUID}, >> {"enumerate_locals", TDF_ENUMERATE_LOCALS}, >> {"scev", TDF_SCEV}, >> + {"optimized", MSG_OPTIMIZED_LOCATIONS}, >> + {"missed", MSG_MISSED_OPTIMIZATION}, >> + {"note", MSG_NOTE}, >> + {"optall", MSG_ALL}, >> {"all", ~(TDF_RAW | TDF_SLIM | TDF_LINENO | TDF_TREE | TDF_RTL | TDF_IPA >> | TDF_STMTADDR | TDF_GRAPH | TDF_DIAGNOSTIC | TDF_VERBOSE >> | TDF_RHS_ONLY | TDF_NOUID | TDF_ENUMERATE_LOCALS | TDF_SCEV)}, >> >> >> -- >> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413