From: Xinliang David Li <davidxl@google.com>
To: Sriraman Tallam <tmsriram@google.com>
Cc: Rong Xu <xur@google.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [google][4.7] Allow function reordering linker plugin to separate hot and cold code into different ELF segments
Date: Fri, 04 Jan 2013 22:32:00 -0000 [thread overview]
Message-ID: <CAAkRFZKNqngZDVRO5xkFw7KBeejK6+0AYWCJp6UvUaPfpQZ4uQ@mail.gmail.com> (raw)
In-Reply-To: <CAAs8HmwrSWdY=ZHYKVT2oe0-6n_-Zw3qXufXT6Ph-w2nEAm4DA@mail.gmail.com>
Looks good -- but better with followup :
1) give a warning when the parameter to the option is not allowed;
2) add test cases if possible.
David
On Fri, Jan 4, 2013 at 2:19 PM, Sriraman Tallam <tmsriram@google.com> wrote:
> Attached new patch.
>
> Thanks,
> -Sri.
>
> On Fri, Jan 4, 2013 at 9:12 AM, Rong Xu <xur@google.com> wrote:
>> The code looks fine to me. Please consider David's comments about the
>> option name.
>>
>> -Rong
>>
>> On Thu, Jan 3, 2013 at 9:14 PM, Xinliang David Li <davidxl@google.com> wrote:
>>> Is it better to change the option to something like:
>>>
>>> split_segment|nosplit-segment
>>> or split_segment=yes|no
>>>
>>>
>>> David
>>>
>>> On Thu, Jan 3, 2013 at 5:41 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>>>> Hi Rong,
>>>>
>>>> The following patch modifies the behaviour of the linker plugin to
>>>> not create a separate segment for cold sections by default. Separate
>>>> segments can be created with the plugin option "segment=cold". Is this
>>>> alright to commit?
>>>>
>>>> Thanks,
>>>> -Sri.
>>>>
>>>> On Mon, Dec 17, 2012 at 11:14 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>>>>> I have committed this patch.
>>>>>
>>>>> Thanks,
>>>>> -Sri.
>>>>>
>>>>> On Fri, Dec 14, 2012 at 4:16 PM, Rong Xu <xur@google.com> wrote:
>>>>>> Looks good to me for google/gcc-4_7 branch.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> -Rong
>>>>>>
>>>>>>
>>>>>> On Fri, Dec 14, 2012 at 3:42 PM, Sriraman Tallam <tmsriram@google.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> Hi Rong,
>>>>>>>
>>>>>>> Please review this code. This code allows the function reordering
>>>>>>> plugin to separate hot and cold code into different ELF segments.
>>>>>>> This would allow optimizations like mapping the hot code alone to huge
>>>>>>> pages.
>>>>>>>
>>>>>>> With this patch, by default, the plugin maps .text.unlikely
>>>>>>> sections into a separate ELF segment. This can be turned off with
>>>>>>> plugin option "--segment=none".
>>>>>>>
>>>>>>> The include/plugin-api.h changes are a backport from trunk.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> -Sri.
>>>>>>
>>>>>>
next prev parent reply other threads:[~2013-01-04 22:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 23:42 Sriraman Tallam
[not found] ` <CAF1bQ=TFVjwdkhiNAfD3=jSNPu2M3zRZ_OajGNWbmACS=sA82Q@mail.gmail.com>
2012-12-17 19:14 ` Sriraman Tallam
2013-01-04 1:41 ` Sriraman Tallam
2013-01-04 5:14 ` Xinliang David Li
2013-01-04 17:13 ` Rong Xu
2013-01-04 22:19 ` Sriraman Tallam
2013-01-04 22:32 ` Xinliang David Li [this message]
2013-01-05 2:32 ` Sriraman Tallam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAkRFZKNqngZDVRO5xkFw7KBeejK6+0AYWCJp6UvUaPfpQZ4uQ@mail.gmail.com \
--to=davidxl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tmsriram@google.com \
--cc=xur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).