From: Xinliang David Li <davidxl@google.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <richard.guenther@gmail.com>,
Rong Xu <xur@google.com>, Jan Hubicka <hubicka@ucw.cz>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Xinliang David Li <xinliangli@gmail.com>,
Teresa Johnson <tejohnson@google.com>,
Dehao Chen <dehao@google.com>
Subject: Re: [PATCH] offline gcda profile processing tool
Date: Fri, 11 Jul 2014 16:13:00 -0000 [thread overview]
Message-ID: <CAAkRFZKRqFCbLyJzPvwkPRgoZCS2aGCqiAxbT0zZejXZhkw6iw@mail.gmail.com> (raw)
In-Reply-To: <20140711154426.GX31640@tucnak.redhat.com>
right.
Rong, the fix would be just change ctr array size to 1. For each
function, there should be at least one kind of counters -- see the
assertion in build_fn_info_type. There are some code that do
'sizeof(gcov_fn_info)' when computing heap size -- they can be
adjusted or leave it as it is (if not doing memcpy for the whole
array).
David
On Fri, Jul 11, 2014 at 8:44 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Fri, Jul 11, 2014 at 08:42:27AM -0700, Xinliang David Li wrote:
>> I wonder why. The struct definition for gcov_fn_info has not changed
>> in this patch.
>
> Perhaps it has been used only in C until now?
>
> Jakub
next prev parent reply other threads:[~2014-07-11 16:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-13 20:43 Rong Xu
2014-01-16 17:30 ` Rong Xu
2014-03-03 22:02 ` Rong Xu
2014-04-15 22:05 ` Jan Hubicka
2014-04-16 17:28 ` Rong Xu
2014-04-17 5:19 ` Jan Hubicka
2014-05-01 22:37 ` Rong Xu
2014-05-05 17:17 ` Rong Xu
2014-07-11 8:07 ` Richard Biener
2014-07-11 8:12 ` Christophe Lyon
2014-07-11 15:50 ` Xinliang David Li
2014-07-11 16:44 ` Rong Xu
2014-07-11 15:42 ` Xinliang David Li
2014-07-11 16:03 ` Jakub Jelinek
2014-07-11 16:13 ` Xinliang David Li [this message]
2014-07-11 16:48 ` Rong Xu
2014-07-11 18:30 ` Rong Xu
2014-07-11 18:46 ` Jan Hubicka
2014-07-11 18:53 ` Rong Xu
2014-07-13 7:49 ` Andreas Schwab
2014-05-15 20:37 ` Jan Hubicka
2014-05-20 22:59 ` Rong Xu
2014-05-25 23:43 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAkRFZKRqFCbLyJzPvwkPRgoZCS2aGCqiAxbT0zZejXZhkw6iw@mail.gmail.com \
--to=davidxl@google.com \
--cc=dehao@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jakub@redhat.com \
--cc=richard.guenther@gmail.com \
--cc=tejohnson@google.com \
--cc=xinliangli@gmail.com \
--cc=xur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).