public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [google/google-main] Fix for unused variable warning in libgcov.c (issue6052049)
@ 2012-04-17 18:40 Teresa Johnson
  2012-04-17 18:57 ` Xinliang David Li
  0 siblings, 1 reply; 2+ messages in thread
From: Teresa Johnson @ 2012-04-17 18:40 UTC (permalink / raw)
  To: reply, gcc-patches

I have a patch to fix a compile time warning about an unused variable due
to the use being guarded by #ifndef __GCOV_KERNEL__.

Tested with bootstrap. Ok for google-main?

Teresa

2012-04-17   Teresa Johnson  <tejohnson@google.com>

	Google ref b/5910724.
	* libgcc/libgcov.c (gcov_cur_module_id): Guard definition under
	#ifndef __GCOV_KERNEL__.

Index: libgcov.c
===================================================================
--- libgcov.c	(revision 186282)
+++ libgcov.c	(working copy)
@@ -153,10 +153,10 @@ static gcov_unsigned_t gcov_crc32;
 
 /* Size of the longest file name. */
 static size_t gcov_max_filename = 0;
-#endif /* __GCOV_KERNEL__ */
 
 /* Unique identifier assigned to each module (object file).  */
 static gcov_unsigned_t gcov_cur_module_id = 0;
+#endif /* __GCOV_KERNEL__ */
 
 /* Pointer to the direct-call counters (per call-site counters).
    Initialized by the caller.  */

--
This patch is available for review at http://codereview.appspot.com/6052049

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [google/google-main] Fix for unused variable warning in libgcov.c (issue6052049)
  2012-04-17 18:40 [google/google-main] Fix for unused variable warning in libgcov.c (issue6052049) Teresa Johnson
@ 2012-04-17 18:57 ` Xinliang David Li
  0 siblings, 0 replies; 2+ messages in thread
From: Xinliang David Li @ 2012-04-17 18:57 UTC (permalink / raw)
  To: Teresa Johnson; +Cc: reply, gcc-patches

ok.

David

On Tue, Apr 17, 2012 at 11:40 AM, Teresa Johnson <tejohnson@google.com> wrote:
> I have a patch to fix a compile time warning about an unused variable due
> to the use being guarded by #ifndef __GCOV_KERNEL__.
>
> Tested with bootstrap. Ok for google-main?
>
> Teresa
>
> 2012-04-17   Teresa Johnson  <tejohnson@google.com>
>
>        Google ref b/5910724.
>        * libgcc/libgcov.c (gcov_cur_module_id): Guard definition under
>        #ifndef __GCOV_KERNEL__.
>
> Index: libgcov.c
> ===================================================================
> --- libgcov.c   (revision 186282)
> +++ libgcov.c   (working copy)
> @@ -153,10 +153,10 @@ static gcov_unsigned_t gcov_crc32;
>
>  /* Size of the longest file name. */
>  static size_t gcov_max_filename = 0;
> -#endif /* __GCOV_KERNEL__ */
>
>  /* Unique identifier assigned to each module (object file).  */
>  static gcov_unsigned_t gcov_cur_module_id = 0;
> +#endif /* __GCOV_KERNEL__ */
>
>  /* Pointer to the direct-call counters (per call-site counters).
>    Initialized by the caller.  */
>
> --
> This patch is available for review at http://codereview.appspot.com/6052049

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-04-17 18:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-17 18:40 [google/google-main] Fix for unused variable warning in libgcov.c (issue6052049) Teresa Johnson
2012-04-17 18:57 ` Xinliang David Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).