From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28222 invoked by alias); 10 Jul 2012 16:09:06 -0000 Received: (qmail 28204 invoked by uid 22791); 10 Jul 2012 16:09:05 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jul 2012 16:08:50 +0000 Received: by lbol5 with SMTP id l5so483419lbo.20 for ; Tue, 10 Jul 2012 09:08:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=/7MXw8Ru7NEUZ927ukKs5+olpbWB+OaEhExW3wjNOks=; b=dl95+YBiXsul+Qj9D0crjYIE9IpVEU5hvCV6ndJireVgnPahzc9MFu0YbjFvzrgU5n S/upnw95TE70MMVZXaxgfgxOskC2IP5WnejaMwKqNxA0nbQCbaNWns1u+sFFhljSf9zz 7vGdY3ypCgfRvQGX2m9e/Wo/ES30mbR/RiMijxGIdFoKnQGWvaP6sVC99jxYjzWuYw+h +BkvPkkCBPYEXIS/Ic37WN3T38hGHc1ZCds/5r0iZGK2au7FaSy79W1iIDHK5T4GqSg/ YtavoLT6Zgdu6o9oBuqIZgNeeCEqnvmUjmd/D80Gp8xZImzdq/L/lQgTXYngXnPhunkF Szfg== Received: by 10.112.41.2 with SMTP id b2mr20849612lbl.58.1341936528883; Tue, 10 Jul 2012 09:08:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.41.2 with SMTP id b2mr20849591lbl.58.1341936528697; Tue, 10 Jul 2012 09:08:48 -0700 (PDT) Received: by 10.152.130.102 with HTTP; Tue, 10 Jul 2012 09:08:48 -0700 (PDT) In-Reply-To: <4FFBF9F5.6020306@redhat.com> References: <20120307004630.A503DB21B6@azwildcat.mtv.corp.google.com> <4FF7D1C6.90407@redhat.com> <4FF96D0C.5060406@redhat.com> <4FFBF9F5.6020306@redhat.com> Date: Tue, 10 Jul 2012 16:09:00 -0000 Message-ID: Subject: Re: User directed Function Multiversioning via Function Overloading (issue5752064) From: Xinliang David Li To: Jason Merrill Cc: Sriraman Tallam , mark@codesourcery.com, nathan@codesourcery.com, "H.J. Lu" , Richard Guenther , Jan Hubicka , Uros Bizjak , reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-Gm-Message-State: ALoCoQl8Rp3MKivcIdcBN1/oQeAorxY12J7WwiqSMDlQmyJCddtII7nZn+sK1KHxfyOGi7NH5djHvFK9Q41CsBExWoDxlM7ocYXI8/CCpC8GVgq8uUvmVAkiGlxj4sps+s5jrNVfj2OlloEqffl6jAZgpwsyFOFLUrw7srLeLX4jR+0fe3fA8RVWQhejFJJvVefXS3baLI2s X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-07/txt/msg00385.txt.bz2 On Tue, Jul 10, 2012 at 2:46 AM, Jason Merrill wrote: > On 07/09/2012 11:27 PM, Xinliang David Li wrote: >> >> Ok. Do you have specific comments on the patch? > > > My comment is "Perhaps we want to implement this using a more generic > mechanism." I was thinking to defer a detailed code review until that > question is settled. We all like more generic solutions :) Sri, can you provide more descriptions on FE changes -- this will help reviewers get started. By the way, there are a couple of files with bad contents and needs re-upload -- e.g, cp/decl.c. thanks, David > > Jason