From: Xinliang David Li <davidxl@google.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Wei Mi <wmi@google.com>, GCC Patches <gcc-patches@gcc.gnu.org>,
Dmitry Vyukov <dvyukov@google.com>,
Diego Novillo <dnovillo@google.com>,
Dodji Seketeli <dodji@redhat.com>
Subject: Re: [tsan] ThreadSanitizer instrumentation part
Date: Thu, 01 Nov 2012 15:47:00 -0000 [thread overview]
Message-ID: <CAAkRFZKh+vCLvxv_fyPfxB7E6zyH_DqfaTSoX+6HZEMsC80-9g@mail.gmail.com> (raw)
In-Reply-To: <20121101062736.GB1891@tucnak.redhat.com>
On Wed, Oct 31, 2012 at 11:27 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Oct 31, 2012 at 11:00:17PM -0700, Xinliang David Li wrote:
>> > + /* Below are things we do not instrument
>> > + (no possibility of races or not implemented yet). */
>> > + if (/* Compiler-emitted artificial variables. */
>> > + (DECL_P (expr) && DECL_ARTIFICIAL (expr))
>> > + /* The var does not live in memory -> no possibility of races. */
>> > + || (tcode == VAR_DECL
>> > + && TREE_ADDRESSABLE (expr) == 0
>>
>> ==> !TREE_ADDRESSABLE (expr)
>>
>> > + && TREE_STATIC (expr) == 0)
>>
>>
>> To detect stack varaible, TREE_STATIC can not be used. Use
>> !DECL_EXTERNAL instead.
>
> TREE_STATIC is right for that.
Hmm, what does this condition try to capture then?
David
>
> Jakub
next prev parent reply other threads:[~2012-11-01 15:47 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 6:00 Xinliang David Li
2012-11-01 6:27 ` Jakub Jelinek
2012-11-01 15:47 ` Xinliang David Li [this message]
[not found] ` <CA+4CFy4uuCtFuiqai0b_VXib1te=DeBv1_EWDFjf8UP6MYMJPg@mail.gmail.com>
[not found] ` <CAAkRFZKWhxJP=0p-6JCgMrMGPTj4Vv3m9yNhRgioOKxzTsss1Q@mail.gmail.com>
[not found] ` <CA+4CFy7ecGOkmXsdkC=LbSK5KMdBSR6eT0oLmfn2nbyr0S2bMA@mail.gmail.com>
2012-11-03 1:31 ` Wei Mi
2012-11-03 17:05 ` Wei Mi
2012-11-03 18:39 ` Jakub Jelinek
2012-11-06 0:37 ` Wei Mi
2012-11-12 18:58 ` Wei Mi
2012-11-13 16:41 ` Jakub Jelinek
2012-11-13 17:25 ` Xinliang David Li
2012-11-13 17:36 ` Jakub Jelinek
2012-11-13 17:55 ` Xinliang David Li
2012-11-14 0:08 ` Wei Mi
2012-11-14 0:54 ` Richard Henderson
2012-11-14 1:06 ` Wei Mi
2012-11-16 23:13 ` Wei Mi
2012-11-18 18:52 ` Konstantin Serebryany
2012-11-22 7:23 ` Wei Mi
[not found] ` <CACT4Y+aR5vizMRb7VCXK7w=bnEz29g9WjQkjvu=8=kds610D1Q@mail.gmail.com>
[not found] ` <CACT4Y+YrUg13dqtUTD23qEWnySNgQ1T_H06R2=ytpXKZeG8UUQ@mail.gmail.com>
2012-11-22 7:45 ` Xinliang David Li
[not found] ` <CACT4Y+a07z9-VtGKQ7gGCyHWb_XH4sVWFtPG=qpkk_gJXfc40A@mail.gmail.com>
2012-11-22 22:06 ` Wei Mi
2012-11-22 8:08 ` Jakub Jelinek
2012-11-22 15:13 ` [PATCH] Convert asan to use sanitizer.def builtins, initialize them if the FE didn't Jakub Jelinek
2012-12-03 16:58 ` Dodji Seketeli
2012-11-22 9:54 ` [tsan] ThreadSanitizer instrumentation part Jakub Jelinek
2012-11-22 13:21 ` [tsan] libsanitizer tweaks Jakub Jelinek
2012-11-22 23:22 ` Diego Novillo
2012-11-22 22:08 ` [tsan] ThreadSanitizer instrumentation part Wei Mi
2012-11-22 23:04 ` H.J. Lu
2012-11-22 23:06 ` Jakub Jelinek
2012-11-22 23:18 ` Jack Howarth
2012-11-23 0:53 ` Wei Mi
-- strict thread matches above, loose matches on Subject: below --
2012-11-01 19:35 Xinliang David Li
2012-11-01 20:54 ` Jakub Jelinek
2012-11-01 20:57 ` Xinliang David Li
2012-11-01 21:07 ` Jakub Jelinek
2012-11-01 21:19 ` Xinliang David Li
2012-11-01 21:24 ` Jakub Jelinek
2012-11-01 21:43 ` Xinliang David Li
2012-11-01 18:11 Xinliang David Li
[not found] ` <CACT4Y+azNYV+8ieRthd-SkQqGO82dj2+JOdL5c15DyBc9LwyfA@mail.gmail.com>
[not found] ` <CACT4Y+YQDBVxL2GdK9o-8kn===1XzX9JaBJUpM5N4MYCJAeo=Q@mail.gmail.com>
2012-11-01 18:20 ` Xinliang David Li
2012-11-01 18:22 ` Diego Novillo
2012-11-01 18:24 ` Jakub Jelinek
2012-11-01 18:32 ` Xinliang David Li
2012-11-01 18:49 ` Jakub Jelinek
2012-11-01 18:57 ` Xinliang David Li
2012-11-01 19:16 ` Jakub Jelinek
[not found] ` <CACT4Y+bbG3MOBX0vmP-Dvf=oPDp6GBDodJ+FbHrXEmjHjWn-qw@mail.gmail.com>
2012-11-01 20:53 ` Jakub Jelinek
2012-11-02 13:31 ` Martin Jambor
2012-11-02 15:54 ` Xinliang David Li
2012-11-02 15:58 ` Jakub Jelinek
2012-11-02 16:14 ` Xinliang David Li
2012-10-31 18:56 Wei Mi
2012-10-31 23:17 ` Jakub Jelinek
2012-11-01 6:02 ` Xinliang David Li
[not found] ` <CACT4Y+Z77tgge+k4+DOMkCLOWL4-xhate5Ccmav3Vox3_8Pqcw@mail.gmail.com>
2012-11-01 7:22 ` Jakub Jelinek
2012-11-01 6:58 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAkRFZKh+vCLvxv_fyPfxB7E6zyH_DqfaTSoX+6HZEMsC80-9g@mail.gmail.com \
--to=davidxl@google.com \
--cc=dnovillo@google.com \
--cc=dodji@redhat.com \
--cc=dvyukov@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=wmi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).