From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84556 invoked by alias); 2 Dec 2015 01:12:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84542 invoked by uid 89); 2 Dec 2015 01:12:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-yk0-f172.google.com Received: from mail-yk0-f172.google.com (HELO mail-yk0-f172.google.com) (209.85.160.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 02 Dec 2015 01:12:48 +0000 Received: by ykba77 with SMTP id a77so29676930ykb.2 for ; Tue, 01 Dec 2015 17:12:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Cooegoxt6cBS+GL284amacPpxQc0rO2By148qgc7bzo=; b=GdzRUB7qmn7bbRYgU9aMqZm/pvSicR6SMbgK+kX14w7mF4axG+paHHLwrsiXNdQOqX 4m2Jgu7jOWCWhEmh9nRewKMXUrFtQlR1fmw7xtjqfxOPdmMoz034ZePzv6tnmwFVDTtc M0kx0TbraEdTBi9qI1m6HWDbrHjlFFXOjEO8y+gMl+CeDIoFBfWdmxzdFxcE0nGNsr9U r9BW/iQD/CGgL/saMEc/dC84F3WdiB1IGmvd1e3+4RDbeieFpPaP3hPv7OsdwrGVMXc5 8i3d1lMdLJzWCHY7GBiOPMkL/J/ozc6Fjmg0gb1AR5QmWLVPczMUom57RSwdsPR1IKwU dbPQ== X-Gm-Message-State: ALoCoQnYwcLeqzelTFPobIM++X6PyiM+KfJAndthbvihfDnIBUXrY8dUhMPbr4/oA8v6iQaRwoM4 MIME-Version: 1.0 X-Received: by 10.129.54.16 with SMTP id d16mr287861ywa.41.1449018766476; Tue, 01 Dec 2015 17:12:46 -0800 (PST) Received: by 10.37.5.17 with HTTP; Tue, 1 Dec 2015 17:12:46 -0800 (PST) In-Reply-To: References: Date: Wed, 02 Dec 2015 01:12:00 -0000 Message-ID: Subject: Re: [google gcc-4_9] Fix bad LIPO profile produced by gcov-tool From: Xinliang David Li To: Rong Xu Cc: GCC Patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00184.txt.bz2 So that field was never inited/used before? Also saved_compressed_len = (unsigned long) gcov_read_unsigned (); should use unsigned not unsigned long type. On Tue, Dec 1, 2015 at 4:53 PM, Rong Xu wrote: > This is only needed for gcov-tool as we need to rewrite the > moduel-info to the profile (this is only used in decompress) > > The transitional compiler path does not need it because the string is > already decompressed. It only needs to use the strings. > > gcov-dump in theory does not need it either if it only dumps the > strings. But now I added the printing of both lengths. So now it is > also needed. > > On Tue, Dec 1, 2015 at 4:46 PM, Xinliang David Li wrote: >> Not sure about this line: >> >> mod_info->combined_strlen = saved_compressed_len; >> >> This did not exist for the compiler path before. >> >> On Tue, Dec 1, 2015 at 4:34 PM, Rong Xu wrote: >>> >>> Hi, >>> >>> This patch fixes the issue when using gcov-tool to merge LIPO profiles >>> after we compressing the module infomration . We should not decompress >>> the string as the compressed string should be written directly to the >>> profile later. Tested with some LIPO profiles. >>> >>> Thanks, >>> >>> -Rong >> >>