From: Xinliang David Li <davidxl@google.com>
To: Teresa Johnson <tejohnson@google.com>
Cc: Dinar Temirbulatov <dinar@kugelworks.com>,
GCC Patches <gcc-patches@gcc.gnu.org>, Rong Xu <xur@google.com>
Subject: Re: [Google] Fix profiledbootstrap failure
Date: Tue, 30 Jul 2013 19:13:00 -0000 [thread overview]
Message-ID: <CAAkRFZLYWYBeToCgnZPxV-Sg1MQATF_o-29TWZVdbsMcJmYXjw@mail.gmail.com> (raw)
In-Reply-To: <CAAe5K+W6wJLPUbJSmrZbAp+Og6kc6dcWuHiwh-WONFq4voogHw@mail.gmail.com>
I need to understand why this affects profile bootstrap -- is this due
to file name conflict?
The fix is wrong -- please do not remove the parameter. If it is a
problem, a better fix is to change the default parameter value to 0.
David
On Tue, Jul 30, 2013 at 11:56 AM, Teresa Johnson <tejohnson@google.com> wrote:
> cc'ing Rong and David since this came from LIPO support.
>
> The patch as-is removes the one use of PARAM_GCOV_DEBUG (which is on
> by default) without removing the parameter itself. What is the failure
> mode you see from this code?
>
> Thanks,
> Teresa
>
> On Tue, Jul 30, 2013 at 11:50 AM, Dinar Temirbulatov
> <dinar@kugelworks.com> wrote:
>> Hello
>>
>> This change allows to complete profiledbootstrap on the google gcc-4.8
>> branch, tested with make bootstrap with no new regressions. OK for
>> google 4.8?
>> thanks, Dinar.
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
next prev parent reply other threads:[~2013-07-30 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 18:51 Dinar Temirbulatov
2013-07-30 19:02 ` Teresa Johnson
2013-07-30 19:13 ` Xinliang David Li [this message]
2013-07-30 19:50 ` Rong Xu
2013-07-30 20:01 ` Xinliang David Li
2013-07-30 20:18 ` Rong Xu
2013-07-31 17:09 ` Dinar Temirbulatov
2013-07-30 19:58 ` Dinar Temirbulatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAkRFZLYWYBeToCgnZPxV-Sg1MQATF_o-29TWZVdbsMcJmYXjw@mail.gmail.com \
--to=davidxl@google.com \
--cc=dinar@kugelworks.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tejohnson@google.com \
--cc=xur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).