From: Xinliang David Li <davidxl@google.com>
To: Teresa Johnson <tejohnson@google.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [GOOGLE] Remove overly-aggressive LIPO assert
Date: Tue, 08 Dec 2015 19:45:00 -0000 [thread overview]
Message-ID: <CAAkRFZLhfnu3a-aMPrX2TYEinFvTotHeq0nA24MRWrhA7NGgzA@mail.gmail.com> (raw)
In-Reply-To: <CAAe5K+WzzEPfa4t9H+F5y0kaeRRH7s3p_paN4VW8wZg6V0j+MQ@mail.gmail.com>
ok.
David
On Fri, Dec 4, 2015 at 11:29 AM, Teresa Johnson <tejohnson@google.com> wrote:
> Ping.
> Thanks, Teresa
>
> On Wed, Dec 2, 2015 at 12:46 PM, Teresa Johnson <tejohnson@google.com> wrote:
>> Remove an assert that was overly-strict and already partially redundant
>> with an immediately prior assert. In this case we had a hidden visibility
>> function clone that was created after the LIPO link due to indirect call
>> promotion. It is a cgraph_is_aux_decl_external node.
>>
>> Fixes failures and passes regression tests. Ok for Google branch?
>>
>> 2015-12-02 Teresa Johnson <tejohnson@google.com>
>>
>> Google ref b/25925223.
>> * l-ipo.c (cgraph_lipo_get_resolved_node_1): Remove overly-strict
>> assert.
>>
>> Index: l-ipo.c
>> ===================================================================
>> --- l-ipo.c (revision 231131)
>> +++ l-ipo.c (working copy)
>> @@ -1457,9 +1457,6 @@ cgraph_lipo_get_resolved_node_1 (tree decl, bool d
>> gcc_assert (DECL_EXTERNAL (decl)
>> || cgraph_is_aux_decl_external (n)
>> || DECL_VIRTUAL_P (decl));
>> - gcc_assert (/* This is the case for explicit extern
>> instantiation,
>> - when cgraph node is not created before link. */
>> - DECL_EXTERNAL (decl));
>> cgraph_link_node (n);
>> return n;
>> }
>>
>>
>> --
>> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
>
>
>
> --
> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413
prev parent reply other threads:[~2015-12-08 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 20:46 Teresa Johnson
2015-12-04 19:29 ` Teresa Johnson
2015-12-08 19:45 ` Xinliang David Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAkRFZLhfnu3a-aMPrX2TYEinFvTotHeq0nA24MRWrhA7NGgzA@mail.gmail.com \
--to=davidxl@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tejohnson@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).