From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33651 invoked by alias); 8 Dec 2015 19:45:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33630 invoked by uid 89); 8 Dec 2015 19:45:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vk0-f54.google.com Received: from mail-vk0-f54.google.com (HELO mail-vk0-f54.google.com) (209.85.213.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 08 Dec 2015 19:45:04 +0000 Received: by vkay187 with SMTP id y187so26640757vka.3 for ; Tue, 08 Dec 2015 11:45:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=dBcT+C1SL/99Mofq4aRs5q6Qtffbc8ELAyhcLcllGjI=; b=JVArRBnpuWc+3lG5tvsyX8tdQAcb3KJn2eL7RTSJJ5LOkF5CmC3GiX5Rxm17vH2I9G kEixAmVKSb42toTxqBUu7DSiwsqyMVlh7MKXjO5WKMh/b7wx915DtCU/ja1dBzZ5Rpne qxRFnnYvX8W43G66bMwd5bBFcDpYS0IxSSGeD/OiaSg6d5of7fPea4z73qwISVJt+e0U lI7sTLGab9XNOVmaFUvGsUI0P7GYk5l9cjLDoDfOB5k1m2z8m5j/R2bunFLNtsLtulog bEsCK35i1xPJ8gnDeXfxPrJvHS5OQKgnwamN0rk5NbwKFbE8DBnoYR35XfBXV3Trb8C/ PP4A== X-Gm-Message-State: ALoCoQm1rWVONH3myDldc61pIEKXQUUdY0ZxfeiAggT4uehcgS1q3xtg/7yQGthK2lapaIIVk86WPjbPKG0ua1Ax4DV/23361kEgvpJ3QlGXlE340gSIxxk= MIME-Version: 1.0 X-Received: by 10.129.157.5 with SMTP id u5mr3206791ywg.270.1449603900567; Tue, 08 Dec 2015 11:45:00 -0800 (PST) Received: by 10.37.5.17 with HTTP; Tue, 8 Dec 2015 11:45:00 -0800 (PST) In-Reply-To: References: Date: Tue, 08 Dec 2015 19:45:00 -0000 Message-ID: Subject: Re: [GOOGLE] Remove overly-aggressive LIPO assert From: Xinliang David Li To: Teresa Johnson Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00911.txt.bz2 ok. David On Fri, Dec 4, 2015 at 11:29 AM, Teresa Johnson wrote: > Ping. > Thanks, Teresa > > On Wed, Dec 2, 2015 at 12:46 PM, Teresa Johnson wrote: >> Remove an assert that was overly-strict and already partially redundant >> with an immediately prior assert. In this case we had a hidden visibility >> function clone that was created after the LIPO link due to indirect call >> promotion. It is a cgraph_is_aux_decl_external node. >> >> Fixes failures and passes regression tests. Ok for Google branch? >> >> 2015-12-02 Teresa Johnson >> >> Google ref b/25925223. >> * l-ipo.c (cgraph_lipo_get_resolved_node_1): Remove overly-strict >> assert. >> >> Index: l-ipo.c >> =================================================================== >> --- l-ipo.c (revision 231131) >> +++ l-ipo.c (working copy) >> @@ -1457,9 +1457,6 @@ cgraph_lipo_get_resolved_node_1 (tree decl, bool d >> gcc_assert (DECL_EXTERNAL (decl) >> || cgraph_is_aux_decl_external (n) >> || DECL_VIRTUAL_P (decl)); >> - gcc_assert (/* This is the case for explicit extern >> instantiation, >> - when cgraph node is not created before link. */ >> - DECL_EXTERNAL (decl)); >> cgraph_link_node (n); >> return n; >> } >> >> >> -- >> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413 > > > > -- > Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413