From: Xinliang David Li <davidxl@google.com>
To: Wei Mi <wmi@google.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
Andrew Pinski <pinskia@gmail.com>,
gcc-patches@gcc.gnu.org, Diego Novillo <dnovillo@google.com>
Subject: Re: [asan] migrate runtime from llvm
Date: Fri, 19 Oct 2012 20:28:00 -0000 [thread overview]
Message-ID: <CAAkRFZLzaTHTuP_vzbfDuY54Pq09JoPr_hSE-NEMJ51rdN-4Pw@mail.gmail.com> (raw)
In-Reply-To: <CA+4CFy587vjy4oYOL3tjyQ6pMhhstCOfzgnqwy1OGhn-OSHGJg@mail.gmail.com>
The library builds fine with the following diff. The file acinclude.m4
is cloned from libmudflap.
David
index 485d169..3e847f1 100644
--- a/libasan/aclocal.m4
+++ b/libasan/aclocal.m4
@@ -1037,8 +1037,8 @@ AC_SUBST([am__tar])
AC_SUBST([am__untar])
]) # _AM_PROG_TAR
-m4_include([m4/libtool.m4])
-m4_include([m4/ltoptions.m4])
-m4_include([m4/ltsugar.m4])
-m4_include([m4/ltversion.m4])
-m4_include([m4/lt~obsolete.m4])
+m4_include([../config/ltoptions.m4])
+m4_include([../config/ltsugar.m4])
+m4_include([../config/ltversion.m4])
+#m4_include([../config/lt~obsolete.m4])
+m4_include([acinclude.m4])
On Fri, Oct 19, 2012 at 11:02 AM, Wei Mi <wmi@google.com> wrote:
> David, I put the m4 subdir under libasan because once I use the .m4
> files (libtool.m4 lt~obsolete.m4 ltoptions.m4 ltsugar.m4
> ltversion.m4) and ltmain.sh under $topsrcdir, the problem that a bad
> libtool was generated under
> $topbuilddir/x86_64-unknown-linux-gnu/libasan you met yesterday
> appeared. That is why I had to generate the new libtool m4 files and
> ltmain.sh using libtoolize.
>
> Thanks,
> Wei.
>
> On Fri, Oct 19, 2012 at 10:16 AM, Xinliang David Li <davidxl@google.com> wrote:
>> I tried it, and this version works for me.
>>
>> Your probably do not need to add the m4 subdir under libasan. The
>> required m4 files are either in .. or ../config dir. See how
>> libmudflap does it.
>>
>> Other than that, if there are no other comments, the change is good to
>> check into the branch. Remaining bugs can always be found and fixed
>> later.
>>
>> thanks,
>>
>> David
>>
>>
>>
>> On Thu, Oct 18, 2012 at 8:04 PM, Wei Mi <wmi@google.com> wrote:
>>> Hi,
>>>
>>> David cought a problem in the last patch when he tries to built
>>> libasan. The problem was that an incomplete libtool under libasan
>>> build directory was generated. The cause is that the old patch used an
>>> old ltmain.sh to generate libtool. I fix it and attach a new patch.
>>> And the new patch move -lpthread and -ldl to libasan LDFLAGS.
>>>
>>> Thanks,
>>> Wei.
next prev parent reply other threads:[~2012-10-19 19:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 6:40 Wei Mi
2012-10-16 6:40 ` Andrew Pinski
2012-10-16 6:45 ` Wei Mi
2012-10-16 7:47 ` Andrew Pinski
2012-10-16 15:27 ` Jakub Jelinek
2012-10-18 17:00 ` Wei Mi
2012-10-18 18:28 ` Jakub Jelinek
2012-10-18 20:25 ` Wei Mi
2012-10-19 3:49 ` Wei Mi
2012-10-19 17:43 ` Xinliang David Li
2012-10-19 18:52 ` Diego Novillo
2012-10-19 19:02 ` Wei Mi
2012-10-19 20:28 ` Xinliang David Li [this message]
2012-10-19 20:41 ` Diego Novillo
2012-10-20 2:08 ` Wei Mi
2012-10-20 2:33 ` Wei Mi
2012-10-25 16:49 ` Xinliang David Li
2012-10-25 16:51 ` Jakub Jelinek
2012-10-25 16:53 ` Xinliang David Li
2012-10-25 16:55 ` Diego Novillo
2012-10-25 16:56 ` Xinliang David Li
2012-10-25 17:00 ` Jakub Jelinek
2012-10-25 17:13 ` Xinliang David Li
2012-10-25 17:27 ` Jakub Jelinek
2012-10-25 18:08 ` Xinliang David Li
2012-10-25 18:11 ` Diego Novillo
2012-10-18 18:22 ` Xinliang David Li
2012-10-18 18:32 ` Jakub Jelinek
2012-10-18 19:29 ` Xinliang David Li
2012-10-18 19:45 ` Xinliang David Li
[not found] ` <CAN=P9piGAbcEmLLVF+77jJvOHAh3dFpEWMgrYqAHqKynrfFNeQ@mail.gmail.com>
2012-10-19 5:14 ` Xinliang David Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAkRFZLzaTHTuP_vzbfDuY54Pq09JoPr_hSE-NEMJ51rdN-4Pw@mail.gmail.com \
--to=davidxl@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=pinskia@gmail.com \
--cc=wmi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).