From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-391286-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 12546 invoked by alias); 4 Feb 2015 21:53:22 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 12533 invoked by uid 89); 4 Feb 2015 21:53:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mail-vc0-f182.google.com
Received: from mail-vc0-f182.google.com (HELO mail-vc0-f182.google.com) (209.85.220.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 04 Feb 2015 21:53:15 +0000
Received: by mail-vc0-f182.google.com with SMTP id kv19so1505579vcb.13        for <gcc-patches@gcc.gnu.org>; Wed, 04 Feb 2015 13:53:12 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=CxuuvXAfPVvT2GVDgQ9B5M5H37Vvwi7oWVQbNop9yq8=;        b=gj4DBQvwEdEAAH7AveGBQDK8JpQb75HdM/B+7EEw5MhOA5H//TiyKIvJDoGkrBPVmg         s31+8UnRin97VyM15WQXsyZxbCGjDR2mirMsLKIE+VKsg9qOXVc0nFk+GqLr6fqRBBLe         CjOQf4AP/GDNmuuWv4pJDlZ7HwEf62+dk6DrOQNAFiFb44G8ZytAevXChdBx6qykWtXS         /6FsZdph/qiX6nT2OHp+kiHdNkllD0bEROD+OMkCEJzywe5gvJbfY46EHh4y0/vVoBDp         KUJfBhvL09nahBMUC2zxzIRHGz/mC7Eu/64osecJrWScA1zDe8STeXuS+VtEBLpme5rn         29gg==
X-Gm-Message-State: ALoCoQnM25LtBarsaTh9f4Su6Z29R5PF9c5VyGBDDPipWib3nRPFAT1qdGsSgey0W3Zi7WzZim9k
MIME-Version: 1.0
X-Received: by 10.52.146.115 with SMTP id tb19mr291673vdb.69.1423086792670; Wed, 04 Feb 2015 13:53:12 -0800 (PST)
Received: by 10.52.37.114 with HTTP; Wed, 4 Feb 2015 13:53:12 -0800 (PST)
In-Reply-To: <CAMe9rOpFiaRuauCqFwUxYPEo46jPiQf8=W9+7Cf8q=1QCm0sEA@mail.gmail.com>
References: <20150203193615.GZ1746@tucnak.redhat.com>	<CAAs8HmwAx0GWcEsDYQhO-dNtage5=j=z47anoFPTz324WTvZPw@mail.gmail.com>	<CAMe9rOrLwHdtsH2z_7dBpVKiJRtfT7iHaHO7wQ23o25TL7cTMw@mail.gmail.com>	<CAAs8Hmw=Z9VeLz+MAY0X-POfkwXLFEsRFy8wEPDdyzVPV8ee=g@mail.gmail.com>	<CAMe9rOouVu9Ndgf231iOt=ry0jWiw573H+y1KxycWkqSw=unOA@mail.gmail.com>	<20150203221935.GA1746@tucnak.redhat.com>	<CAMe9rOq-A3YebgJ_xRnQDekYuvRw6C9GD9DYbhUizvr3OPad_Q@mail.gmail.com>	<CAAs8Hmxdx1n+hgJ0oTAufPauz=S67oM2F_NAmyTzzUSh-ic=4Q@mail.gmail.com>	<20150204183127.GU1746@tucnak.redhat.com>	<CAMe9rOpWUnex45v3hM9=tDNfnC6ipJ-hMEkiY1714Km15bL=bg@mail.gmail.com>	<20150204184205.GW1746@tucnak.redhat.com>	<CAMe9rOoWkw==PQZt1hR1xjKaVxwkFh39vNbFb1WFbaxgxofJMA@mail.gmail.com>	<CAAs8HmzByYULg8y0F2DnVo0YBnh__Jx2xSrvAoMYuWPJJb2q6A@mail.gmail.com>	<CAMe9rOpFiaRuauCqFwUxYPEo46jPiQf8=W9+7Cf8q=1QCm0sEA@mail.gmail.com>
Date: Wed, 04 Feb 2015 21:53:00 -0000
Message-ID: <CAAs8HmwHY-vNEBdULByHYU__xKcKOarMqr-+69VRxo_kBkzwxw@mail.gmail.com>
Subject: Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations
From: Sriraman Tallam <tmsriram@google.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>, Uros Bizjak <ubizjak@gmail.com>, 	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, David Li <davidxl@google.com>, 	Cary Coutant <ccoutant@google.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-02/txt/msg00289.txt.bz2

On Wed, Feb 4, 2015 at 10:57 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Feb 4, 2015 at 10:51 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>> On Wed, Feb 4, 2015 at 10:45 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Wed, Feb 4, 2015 at 10:42 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>>>> On Wed, Feb 04, 2015 at 10:38:48AM -0800, H.J. Lu wrote:
>>>>> Common symbol should be resolved locally for PIE.
>>>>
>>>> binds_local_p yes, binds_to_current_def_p no.
>>>>
>>>
>>> Is SYMBOL_REF_LOCAL_P set to binds_local_p or
>>> binds_to_current_def_p?
>>
>> Looks like binds_local_p:
>>
>> varasm.c:
>> void
>> default_encode_section_info (tree decl, rtx rtl, int first ATTRIBUTE_UNUSED)
>> {
>>   ...
>>   if (targetm.binds_local_p (decl))
>>     flags |= SYMBOL_FLAG_LOCAL;
>>
>
> Why is SYMBOL_REF_LOCAL_P false?

In varasm.c, default_binds_local_p_1


 /* Default visibility weak data can be overridden by a strong symbol
     in another module and so are not local.  */
  else if (DECL_WEAK (exp)
  && !resolved_locally)
    local_p = false;

For weak definition, it is set to false here.

Sri


>
>
> --
> H.J.