From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-399904-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 50334 invoked by alias); 4 Jun 2015 21:17:10 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 50307 invoked by uid 89); 4 Jun 2015 21:17:10 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_50,KAM_STOCKGEN,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mail-vn0-f51.google.com
Received: from mail-vn0-f51.google.com (HELO mail-vn0-f51.google.com) (209.85.216.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 04 Jun 2015 21:17:09 +0000
Received: by vnbf1 with SMTP id f1so6762171vnb.6        for <gcc-patches@gcc.gnu.org>; Thu, 04 Jun 2015 14:17:07 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20130820;        h=x-gm-message-state:mime-version:in-reply-to:references:date         :message-id:subject:from:to:cc:content-type;        bh=0f1ne9RbHpGCU2VHnaB+7uhD1thDvwEP1jg7bHmRHWQ=;        b=iHKED8PQFX1J7jqhCy79EMLMwu0Yux9+GgHyURMdSK1hGjE1QfDojfFLHzqZJkzU0o         qn0UyA+eBO13THOEy03w41AzKTSbi+8VCg9G/0EfwhBstZAzsLk6iQhuDHpHWLRm/65G         q0k4YnkyVZR8u1xuiW/ovW0snhPyi6Ok3wY4JCv5bXNggnkzJVoJk4VbTgh6HKrZpLzx         1OALw0DhpF07Iofxg2b+GzCSgbr20ulLBJJ/F3cf1r+Rcw6sevwxbK1utmoTQMmOkyto         Io9usUG/zUU0vZVtq/KO7GzdMXUuRMt77nkHk2IQtJJ0CLp2b0T3ZNjsDe3hHrNamvDc         4Rsw==
X-Gm-Message-State: ALoCoQn0U8BiQygk3lHV3SM/t5ZBrqFED4922jJoy2WZQd4He1gi5MG4rcSuiFYxXCqNporUFgfr
MIME-Version: 1.0
X-Received: by 10.52.240.198 with SMTP id wc6mr92118vdc.34.1433452626813; Thu, 04 Jun 2015 14:17:06 -0700 (PDT)
Received: by 10.52.231.35 with HTTP; Thu, 4 Jun 2015 14:17:06 -0700 (PDT)
In-Reply-To: <55708543.70904@redhat.com>
References: <CAMe9rOrCh++A=jLOcDVXGM+UOyn31kuJ+R5ZmZkw8E_eHmCTHQ@mail.gmail.com>	<CAJA7tRYsMiq7rx34c=z6KwRdwYxxaeP6Z6qzA4XEwnJSMT7z=Q@mail.gmail.com>	<CAAs8HmxB9NyJQHRxTLj4gKntDgwFfri0VvwSR6vfA1HDTpFHaQ@mail.gmail.com>	<556C16B1.5080606@arm.com>	<CAAs8Hmy3jZDkE1hNmojx9rBBAZ9tjCYHXHevojMTAYHZ5kp8hA@mail.gmail.com>	<CAJA7tRbHAHi7i1xboTZadrJLE_Ry628pwLot6f3wdK4KzawqCQ@mail.gmail.com>	<CAAs8Hmy6gFfoKrVWJ2tCWQZ6Lkez2DCikWozVgwFcY-peDtOhw@mail.gmail.com>	<CAJA7tRYUMvHt04m-+uM9irXRXC57iV9pP0jqQKoj9AJ+rwuo2g@mail.gmail.com>	<CAAs8HmzcD4-t2bbxVL93PSU-1Mp-AZ=Qd-JN8mmjw6pC1Q+h9g@mail.gmail.com>	<CAJA7tRYJxSGNyrrVw4JCBaUF2bgM0UaJ_+Md-DNLDdKZHUxAYg@mail.gmail.com>	<CAAs8HmxdA5Fa7Lu4UzQS_nkFuQNW=4zvv21ucAS3iMQp=OM+8w@mail.gmail.com>	<CAAs8Hmy5RXk89ea=uxHip-t0-2J2-2PTo_y0uGqrvyCFb1oqnw@mail.gmail.com>	<556F5F04.80603@redhat.com>	<CAAs8HmyQ+emX+kzq+ciCyE-03C_aNXRF==Y21Y6nGBYEogfjzw@mail.gmail.com>	<CAAs8HmxAmAZQ2hJnV0WiKFJq7o9OAG8BEikUr-JcX71J9+xkoA@mail.gmail.com>	<55708543.70904@redhat.com>
Date: Thu, 04 Jun 2015 21:34:00 -0000
Message-ID: <CAAs8HmxZPx+Lnk_YB5HyaN7bSFGvzVg6gYfCQEr2U96ZVwf0AA@mail.gmail.com>
Subject: Re: [RFC][PATCH][X86_64] Eliminate PLT stubs for specified external functions via -fno-plt=
From: Sriraman Tallam <tmsriram@google.com>
To: Richard Henderson <rth@redhat.com>
Cc: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>, Jan Hubicka <hubicka@ucw.cz>, 	"H.J. Lu" <hjl.tools@gmail.com>, Pedro Alves <palves@redhat.com>, Michael Matz <matz@suse.de>, 	David Li <davidxl@google.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-06/txt/msg00439.txt.bz2

On Thu, Jun 4, 2015 at 10:05 AM, Richard Henderson <rth@redhat.com> wrote:
> On 06/04/2015 09:54 AM, Sriraman Tallam wrote:
>> +              DECL_ATTRIBUTES (SYMBOL_REF_DECL (XEXP(fnaddr, 0)))))
>
> Spacing.
>
>>       {
>>         use_reg (&use, gen_rtx_REG (Pmode, REAL_PIC_OFFSET_TABLE_REGNUM));
>>         if (ix86_use_pseudo_pic_reg ())
>> @@ -25598,7 +25603,31 @@ ix86_expand_call (rtx retval, rtx fnaddr, rtx call
>>
>>    return call;
>>  }
>> +/* Return true if the function being called was marked with attribute "noplt"
>
> Vertical spacing.
>
>> +      || !TARGET_64BIT || TARGET_MACHO|| TARGET_SEH || TARGET_PECOFF
>
> Spacing.
>
> Otherwise ok.

Made these changes and committed the patch.  I had to add one more
check here to check if decl is not null before looking at its
attributes.  It was causing a seg fault during boot-strap with libgcc
build.

+  && (SYMBOL_REF_DECL ((XEXP (fnaddr, 0))) == NULL_TREE     // This
line was added after the patch was approved.
+      || !lookup_attribute ("noplt",
+     DECL_ATTRIBUTES (SYMBOL_REF_DECL (XEXP (fnaddr, 0))))))

Thanks
Sri

>
>
> r~