From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18770 invoked by alias); 13 Nov 2012 21:57:16 -0000 Received: (qmail 18762 invoked by uid 22791); 13 Nov 2012 21:57:15 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-oa0-f47.google.com (HELO mail-oa0-f47.google.com) (209.85.219.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Nov 2012 21:57:10 +0000 Received: by mail-oa0-f47.google.com with SMTP id h1so8083078oag.20 for ; Tue, 13 Nov 2012 13:57:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=6uOmQYgywjnbR/BHdRjEfoQrapxgPWlqdWSVOq2RQ+w=; b=COeD8kuY17aL1EWpeoMVd5a5fZVMjKA00NwxBKIGc6hbUpo/ttgYgM/tCylOp3D8H1 Yiz0nHFpCVrteW90kdDLDO2G341nn2o9t5q1smfIJGsM9f9XS2N6SW7Tile9T9ZW5cNo grlrVajG/BdIfeMErAtijEfdpLumuxSU7Uul3jyk2aBmf2dTr5lD4HoRwqijEc5BqJJX PT6TrpZorbLkHaKsdCMyj24yLPWMQqR7a0ZD6WMPtmv44hU+UtyRRGx1Fw2QcDOUg12t MXl4SkqW6SSrimWEHDaxBfjbK7HP/kMkd/9DxrMa02qhcUmd6x3kAgzPbbvIpFtzDvDz iW0w== MIME-Version: 1.0 Received: by 10.60.14.165 with SMTP id q5mr19017684oec.28.1352843829968; Tue, 13 Nov 2012 13:57:09 -0800 (PST) Received: by 10.182.176.106 with HTTP; Tue, 13 Nov 2012 13:57:09 -0800 (PST) In-Reply-To: <50A1B2CC.10902@redhat.com> References: <50816D63.3020908@google.com> <20121026155447.GA4348@atrey.karlin.mff.cuni.cz> <50902624.3020705@redhat.com> <50912F66.3030707@redhat.com> <50993222.3010609@redhat.com> <50A08349.4070101@redhat.com> <50A1B2CC.10902@redhat.com> Date: Tue, 13 Nov 2012 21:57:00 -0000 Message-ID: Subject: Re: User directed Function Multiversioning via Function Overloading (issue5752064) From: Sriraman Tallam To: Jason Merrill Cc: David Li , "H.J. Lu" , gcc-patches List , Jan Hubicka , Diego Novillo Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmbalWUbtt06cWO/TlFYbX5Dy93atX8RPCfGsiDEYXZPlGh5MStt30XZU6zPhiKT7lmcRqgL6yny2nD5lbG6P9YI7YwqHvdM4h8cf4zDLqMrJy1OP6qpjkh2mM9EEkfNpZmQgnPbEE2jii5226/2FYEOsz/pZAPVAKOFf29BccpyN5IPOk+OXGzzabJOTbhJVfnh11g X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg01042.txt.bz2 Patch committed now after making the changes. Thanks, -Sri. On Mon, Nov 12, 2012 at 6:39 PM, Jason Merrill wrote: > On 11/12/2012 08:11 PM, Sriraman Tallam wrote: >> >> + && !targetm.target_option.function_versions (fn, >> + TREE_PURPOSE (match))) > > > The second argument should be lined up with the left paren if it's on a > different line. Perhaps formatting this as > > && !(targetm.target_option.function_versions > (fn, TREE_PURPOSE (match)))) > > would be better. > >> + error_at (input_location, "Use of multiversioned function " >> + "Multiversioning needs ifunc which is not supported " > > > We don't capitalize the first letter of a diagnostic. > > OK with those changes. > > Jason >