From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11142 invoked by alias); 26 May 2012 00:16:42 -0000 Received: (qmail 11130 invoked by uid 22791); 26 May 2012 00:16:39 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qa0-f47.google.com (HELO mail-qa0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 26 May 2012 00:16:26 +0000 Received: by qabg1 with SMTP id g1so12844qab.20 for ; Fri, 25 May 2012 17:16:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding:x-system-of-record :x-gm-message-state; bh=h6PGlSagM7lh2TNRu6gHs+TqVGnEhG9Vbb2FuHJ5lDk=; b=MMYu2D+yVPa9lIClAX713WpdOJi2o1VUBh4mGAmwpefxhjOQwaUkSKq6jD0bq9yS1K LoRDRcLIRw9kRMyVwUwyeKGwAzvRVqSaeIHE+sfdWLiz+pQHSu7I88Jnzf0V//B8Gh2z jQs7ciB9Lpjn11LRqt6JZ/YlSJN6LWWMbWwKmFm71UtaEpn/fb0d5pCGoFZOTQVUnABK TB0OghCUKIdltl5XI3LXzsY4DUPjdEaKu+SxE+ZC3e67FuCGo2SyvL8tXB81FMWUN2eu HALCcvugYHIfg6afku0qetQ414mJjy6L2ADRS1ug+lYz7D5GC1hRJi+1EQ3L4on2JIN9 /1sw== Received: by 10.224.174.79 with SMTP id s15mr822904qaz.37.1337991383838; Fri, 25 May 2012 17:16:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.174.79 with SMTP id s15mr822883qaz.37.1337991383700; Fri, 25 May 2012 17:16:23 -0700 (PDT) Received: by 10.229.62.158 with HTTP; Fri, 25 May 2012 17:16:23 -0700 (PDT) In-Reply-To: References: <20120307004630.A503DB21B6@azwildcat.mtv.corp.google.com> Date: Sat, 26 May 2012 00:16:00 -0000 Message-ID: Subject: Re: User directed Function Multiversioning via Function Overloading (issue5752064) From: Sriraman Tallam To: "H.J. Lu" Cc: Richard Guenther , Jan Hubicka , Uros Bizjak , reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org, David Li Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-Gm-Message-State: ALoCoQntuMmIGblvvfjX9c1N0XkMc4iOnMI4xksA7P5abp/JZ9YowxOgTek5orNmTyjvLRF5NpawldAbKZ0CDtaK0ryRmmP37JoKC5U2bDLqro+p4Iz6vYMztHYG8K8A0dolHjjBemomD9pkBbeOxCFTysE5n2yDiA== X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-05/txt/msg01786.txt.bz2 Hi H.J., On Fri, May 25, 2012 at 5:07 PM, H.J. Lu wrote: > On Mon, May 14, 2012 at 11:28 AM, Sriraman Tallam w= rote: >> Hi H.J, >> >> =A0 Attaching new patch with 2 test cases, mv2.C checks ISAs only and >> mv1.C checks ISAs and arches mixed. Right now, checking only arches is >> not needed as they are mutually exclusive, any order should be fine. >> >> Patch also available for review here: =A0http://codereview.appspot.com/5= 752064 > > Sorry for the delay. =A0It looks OK except for the function order in tesc= ases. > I think you should rearrange them so that they are not in the same order > as the priority. I am not sure I understand. The function order is mixed up in the declarations, I have explicitly commented about this. I only do the checking in order which I must, right? Thanks, -Sri. > > Thanks. > > H.J. >> Thanks, >> -Sri. >> >> On Sat, May 12, 2012 at 6:37 AM, H.J. Lu wrote: >>> On Fri, May 11, 2012 at 7:04 PM, Sriraman Tallam = wrote: >>>> Hi H.J., >>>> >>>> =A0 I have updated the patch to improve the dispatching method like we >>>> discussed. Each feature gets a priority now, and the dispatching is >>>> done in priority order. Please see i386.c for the changes. >>>> >>>> Patch also available for review here: =A0http://codereview.appspot.com= /5752064 >>>> >>> >>> I think you need 3 tests: >>> >>> 1. =A0Only with ISA. >>> 2. =A0Only with arch >>> 3. =A0Mixed with ISA and arch >>> >>> since test mixed ISA and arch may hide issues with ISA only or arch onl= y. >>> >>> --