* Re: PR57548 - Call to multiversioned function from global namespace
@ 2013-06-08 23:03 David Edelsohn
2013-06-10 17:50 ` Sriraman Tallam
0 siblings, 1 reply; 5+ messages in thread
From: David Edelsohn @ 2013-06-08 23:03 UTC (permalink / raw)
To: Sriraman Tallam; +Cc: GCC Patches
FYI, gcc/cp has it's own ChangeLog file. Yes, it is confusing that
some directories have their own and others do not.
- David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PR57548 - Call to multiversioned function from global namespace
2013-06-08 23:03 PR57548 - Call to multiversioned function from global namespace David Edelsohn
@ 2013-06-10 17:50 ` Sriraman Tallam
0 siblings, 0 replies; 5+ messages in thread
From: Sriraman Tallam @ 2013-06-10 17:50 UTC (permalink / raw)
To: David Edelsohn; +Cc: GCC Patches
On Sat, Jun 8, 2013 at 4:03 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
> FYI, gcc/cp has it's own ChangeLog file. Yes, it is confusing that
> some directories have their own and others do not.
Fixed now.
Sri.
>
> - David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PR57548 - Call to multiversioned function from global namespace
2013-06-07 18:16 Sriraman Tallam
2013-06-07 19:42 ` Jason Merrill
@ 2013-06-08 15:24 ` Eric Botcazou
1 sibling, 0 replies; 5+ messages in thread
From: Eric Botcazou @ 2013-06-08 15:24 UTC (permalink / raw)
To: Sriraman Tallam; +Cc: gcc-patches, Jason Merrill, Richard Guenther
> The ICE here is because of a multi-versioned function called from
> global namespace and has no caller. This ICEs in target hook
> ix86_can_inline_p as caller is 0x0. The following simple patch
> attached fixes this problem.
>
> * cp/call.c (build_over_call): Check if current_function_decl is
> NULL.
> * testsuite/g++.dg/ext/pr57548.C: New test.
ChangeLogs for cp/ must go into cp/ChangeLog without the cp/ prefix.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PR57548 - Call to multiversioned function from global namespace
2013-06-07 18:16 Sriraman Tallam
@ 2013-06-07 19:42 ` Jason Merrill
2013-06-08 15:24 ` Eric Botcazou
1 sibling, 0 replies; 5+ messages in thread
From: Jason Merrill @ 2013-06-07 19:42 UTC (permalink / raw)
To: Sriraman Tallam, GCC Patches, Richard Guenther
OK.
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* PR57548 - Call to multiversioned function from global namespace
@ 2013-06-07 18:16 Sriraman Tallam
2013-06-07 19:42 ` Jason Merrill
2013-06-08 15:24 ` Eric Botcazou
0 siblings, 2 replies; 5+ messages in thread
From: Sriraman Tallam @ 2013-06-07 18:16 UTC (permalink / raw)
To: GCC Patches, Jason Merrill, Richard Guenther
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
Hi,
See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57548
The ICE here is because of a multi-versioned function called from
global namespace and has no caller. This ICEs in target hook
ix86_can_inline_p as caller is 0x0. The following simple patch
attached fixes this problem.
* cp/call.c (build_over_call): Check if current_function_decl is
NULL.
* testsuite/g++.dg/ext/pr57548.C: New test.
Ok to submit?
Thanks
Sri
[-- Attachment #2: pr57548_patch.txt --]
[-- Type: text/plain, Size: 2051 bytes --]
This patch fixes PR 57548. The problem here is that the caller to fum
not from a function and current_function_decl is NULL when processing the
call. The simple fix in call.c to check current_function_decl before
calling can_inline_p target hook.
* cp/call.c (build_over_call): Check if current_function_decl is
NULL.
* testsuite/g++.dg/ext/pr57548.C: New test.
Index: cp/call.c
===================================================================
--- cp/call.c (revision 199662)
+++ cp/call.c (working copy)
@@ -7053,7 +7053,8 @@ build_over_call (struct z_candidate *cand, int fla
otherwise the call should go through the dispatcher. */
if (DECL_FUNCTION_VERSIONED (fn)
- && !targetm.target_option.can_inline_p (current_function_decl, fn))
+ && (current_function_decl == NULL
+ || !targetm.target_option.can_inline_p (current_function_decl, fn)))
{
fn = get_function_version_dispatcher (fn);
if (fn == NULL)
Index: testsuite/g++.dg/ext/pr57548.C
===================================================================
--- testsuite/g++.dg/ext/pr57548.C (revision 0)
+++ testsuite/g++.dg/ext/pr57548.C (revision 0)
@@ -0,0 +1,25 @@
+/* { dg-do compile { target i?86-*-* x86_64-*-* } } */
+/* { dg-require-ifunc "" } */
+
+int fum (); // Extra declaration that is merged with the second one.
+int fum () __attribute__ ((target("default")));
+
+
+int fum () __attribute__((target( "mmx")));
+int fum () __attribute__((target( "popcnt")));
+int fum () __attribute__((target( "sse")));
+int fum () __attribute__((target( "sse2")));
+int fum () __attribute__((target( "sse3")));
+int fum () __attribute__((target( "ssse3")));
+int fum () __attribute__((target( "sse4.1")));
+int fum () __attribute__((target( "sse4.2")));
+int fum () __attribute__((target( "avx")));
+int fum () __attribute__((target( "avx2")));
+
+int fum () __attribute__((target("arch=core2")));
+int fum () __attribute__((target("arch=corei7")));
+int fum () __attribute__((target("arch=atom")));
+
+int (*p)() = &fum;
+
+int j = fum();
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-10 17:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-08 23:03 PR57548 - Call to multiversioned function from global namespace David Edelsohn
2013-06-10 17:50 ` Sriraman Tallam
-- strict thread matches above, loose matches on Subject: below --
2013-06-07 18:16 Sriraman Tallam
2013-06-07 19:42 ` Jason Merrill
2013-06-08 15:24 ` Eric Botcazou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).