* [PATCH] libstdc++ Add cstdarg to freestanding @ 2023-07-21 21:22 Paul M. Bendixen 2023-08-16 11:21 ` Jonathan Wakely 0 siblings, 1 reply; 9+ messages in thread From: Paul M. Bendixen @ 2023-07-21 21:22 UTC (permalink / raw) To: libstdc++, gcc-patches [-- Attachment #1.1: Type: text/plain, Size: 629 bytes --] P1642 includes the header cstdarg to the freestanding implementation. This was probably left out by accident, this patch puts it in. Since this is one of the headers that go in whole cloth, there should be no further actions needed. This might be related to PR106953, but since that one touches the partial headers I'm not sure /Paul M. Bendixen -- • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// [-- Attachment #2: 0001-libstdc-Include-cstdarg-in-freestanding.patch --] [-- Type: text/x-patch, Size: 1283 bytes --] From 5584c194927678067e412aeb19f10b9662e398a6 Mon Sep 17 00:00:00 2001 From: "Paul M. Bendixen" <paulbendixen@gmail.com> Date: Fri, 21 Jul 2023 22:04:23 +0200 Subject: [PATCH] libstdc++: Include cstdarg in freestanding P1642 includes cstdarg in the full headers to include. Include it. Signed-off-by: Paul M. Bendixen <paulbendixen@gmail.com> --- libstdc++-v3/include/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/include/Makefile.in b/libstdc++-v3/include/Makefile.in index 0ff875b280b..f09f97e2f6b 100644 --- a/libstdc++-v3/include/Makefile.in +++ b/libstdc++-v3/include/Makefile.in @@ -1194,6 +1194,7 @@ c_base_builddir = . c_base_freestanding = \ ${c_base_srcdir}/cfloat \ ${c_base_srcdir}/climits \ + ${c_base_srcdir}/cstdarg \ ${c_base_srcdir}/cstddef \ ${c_base_srcdir}/cstdint \ ${c_base_srcdir}/cstdlib @@ -1213,7 +1214,6 @@ c_base_freestanding = \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/csetjmp \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/csignal \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdalign \ -@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdarg \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdbool \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdio \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstring \ -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] libstdc++ Add cstdarg to freestanding 2023-07-21 21:22 [PATCH] libstdc++ Add cstdarg to freestanding Paul M. Bendixen @ 2023-08-16 11:21 ` Jonathan Wakely 2023-08-16 13:27 ` Arsen Arsenović 0 siblings, 1 reply; 9+ messages in thread From: Jonathan Wakely @ 2023-08-16 11:21 UTC (permalink / raw) To: Paul M. Bendixen; +Cc: libstdc++, gcc-patches, Arsen Arsenović On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ <libstdc++@gcc.gnu.org> wrote: > > P1642 includes the header cstdarg to the freestanding implementation. > This was probably left out by accident, this patch puts it in. > Since this is one of the headers that go in whole cloth, there should be no > further actions needed. Thanks for the patch. I agree that <cstdarg> should be freestanding, but I think <cstdalign> and <cstdbool> were also missed from the change. Arsen? Also, the patch should change include/Makefile.am as well (the .in file is autogenerated from that one). > This might be related to PR106953, but since that one touches the partial > headers I'm not sure > > /Paul M. Bendixen > > -- > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− > •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] libstdc++ Add cstdarg to freestanding 2023-08-16 11:21 ` Jonathan Wakely @ 2023-08-16 13:27 ` Arsen Arsenović 2023-08-16 16:50 ` Paul M. Bendixen 0 siblings, 1 reply; 9+ messages in thread From: Arsen Arsenović @ 2023-08-16 13:27 UTC (permalink / raw) To: Jonathan Wakely; +Cc: Paul M. Bendixen, libstdc++, gcc-patches [-- Attachment #1: Type: text/plain, Size: 1799 bytes --] Jonathan Wakely <jwakely@redhat.com> writes: > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ > <libstdc++@gcc.gnu.org> wrote: >> >> P1642 includes the header cstdarg to the freestanding implementation. >> This was probably left out by accident, this patch puts it in. >> Since this is one of the headers that go in whole cloth, there should be no >> further actions needed. > > Thanks for the patch. I agree that <cstdarg> should be freestanding, > but I think <cstdalign> and <cstdbool> were also missed from the > change. Arsen? Indeed, we should include all three, and according to [compliance], there's a couple more headers that we should provide (cwchar, cstring, cerrno, and cmath, but these are probably significantly more involved, so we can handle them separately). As guessed, the omission was not intentional. If you could, add those two to the patch as well, edit Makefile.am and regenerate using automake 1.15.1, and see https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. Thank you! Have a lovely day :-) [compliance]: https://eel.is/c++draft/compliance > Also, the patch should change include/Makefile.am as well (the .in > file is autogenerated from that one). > > >> This might be related to PR106953, but since that one touches the partial >> headers I'm not sure The headers mentioned in this PR are provided in freestanding, partially, in 13 already, indeed. >> /Paul M. Bendixen >> >> -- >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// -- Arsen Arsenović [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 381 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] libstdc++ Add cstdarg to freestanding 2023-08-16 13:27 ` Arsen Arsenović @ 2023-08-16 16:50 ` Paul M. Bendixen 2023-08-18 19:14 ` Paul M. Bendixen 0 siblings, 1 reply; 9+ messages in thread From: Paul M. Bendixen @ 2023-08-16 16:50 UTC (permalink / raw) To: Arsen Arsenović; +Cc: Jonathan Wakely, libstdc++, gcc-patches [-- Attachment #1: Type: text/plain, Size: 2423 bytes --] Yes, the other files are in another committee proposal, and I'm working my way through the proposals one by one. Thank you for the feedback, I'll update and resend /Paul Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović <arsen@aarsen.me>: > > Jonathan Wakely <jwakely@redhat.com> writes: > > > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ > > <libstdc++@gcc.gnu.org> wrote: > >> > >> P1642 includes the header cstdarg to the freestanding implementation. > >> This was probably left out by accident, this patch puts it in. > >> Since this is one of the headers that go in whole cloth, there should > be no > >> further actions needed. > > > > Thanks for the patch. I agree that <cstdarg> should be freestanding, > > but I think <cstdalign> and <cstdbool> were also missed from the > > change. Arsen? > > Indeed, we should include all three, and according to [compliance], > there's a couple more headers that we should provide (cwchar, cstring, > cerrno, and cmath, but these are probably significantly more involved, > so we can handle them separately). > > As guessed, the omission was not intentional. > > If you could, add those two to the patch as well, edit Makefile.am and > regenerate using automake 1.15.1, and see > https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. > > Thank you! Have a lovely day :-) > > [compliance]: https://eel.is/c++draft/compliance > > > Also, the patch should change include/Makefile.am as well (the .in > > file is autogenerated from that one). > > > > > >> This might be related to PR106953, but since that one touches the > partial > >> headers I'm not sure > > The headers mentioned in this PR are provided in freestanding, > partially, in 13 already, indeed. > > >> /Paul M. Bendixen > >> > >> -- > >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− > >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > > > -- > Arsen Arsenović > -- • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] libstdc++ Add cstdarg to freestanding 2023-08-16 16:50 ` Paul M. Bendixen @ 2023-08-18 19:14 ` Paul M. Bendixen 2023-09-07 16:28 ` Jonathan Wakely 0 siblings, 1 reply; 9+ messages in thread From: Paul M. Bendixen @ 2023-08-18 19:14 UTC (permalink / raw) To: Arsen Arsenović; +Cc: Jonathan Wakely, libstdc++, gcc-patches [-- Attachment #1: Type: text/plain, Size: 3197 bytes --] Hi Jonathan, I just went over the proposal again as well as [compliance], which Arsen mentioned ( https://wg21.link/compliance ) don't seem to mention either <cstdbool> or <cstdalign>. Shouldn't I just stick to the ones we know are in? (Still working on figuring out how to do the change log thing) Best regards Paul Den ons. 16. aug. 2023 kl. 18.50 skrev Paul M. Bendixen < paulbendixen@gmail.com>: > Yes, the other files are in another committee proposal, and I'm working my > way through the proposals one by one. > Thank you for the feedback, I'll update and resend > /Paul > > Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović <arsen@aarsen.me>: > >> >> Jonathan Wakely <jwakely@redhat.com> writes: >> >> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ >> > <libstdc++@gcc.gnu.org> wrote: >> >> >> >> P1642 includes the header cstdarg to the freestanding implementation. >> >> This was probably left out by accident, this patch puts it in. >> >> Since this is one of the headers that go in whole cloth, there should >> be no >> >> further actions needed. >> > >> > Thanks for the patch. I agree that <cstdarg> should be freestanding, >> > but I think <cstdalign> and <cstdbool> were also missed from the >> > change. Arsen? >> >> Indeed, we should include all three, and according to [compliance], >> there's a couple more headers that we should provide (cwchar, cstring, >> cerrno, and cmath, but these are probably significantly more involved, >> so we can handle them separately). >> >> As guessed, the omission was not intentional. >> >> If you could, add those two to the patch as well, edit Makefile.am and >> regenerate using automake 1.15.1, and see >> https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. >> >> Thank you! Have a lovely day :-) >> >> [compliance]: https://eel.is/c++draft/compliance >> >> > Also, the patch should change include/Makefile.am as well (the .in >> > file is autogenerated from that one). >> > >> > >> >> This might be related to PR106953, but since that one touches the >> partial >> >> headers I'm not sure >> >> The headers mentioned in this PR are provided in freestanding, >> partially, in 13 already, indeed. >> >> >> /Paul M. Bendixen >> >> >> >> -- >> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − >> •− >> >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// >> >> >> -- >> Arsen Arsenović >> > > > -- > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− > •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > -- • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] libstdc++ Add cstdarg to freestanding 2023-08-18 19:14 ` Paul M. Bendixen @ 2023-09-07 16:28 ` Jonathan Wakely 2023-10-20 20:55 ` Paul M. Bendixen 0 siblings, 1 reply; 9+ messages in thread From: Jonathan Wakely @ 2023-09-07 16:28 UTC (permalink / raw) To: Paul M. Bendixen; +Cc: Arsen Arsenović, libstdc++, gcc-patches On Fri, 18 Aug 2023 at 20:14, Paul M. Bendixen <paulbendixen@gmail.com> wrote: > > Hi > Jonathan, I just went over the proposal again as well as [compliance], which Arsen mentioned ( https://wg21.link/compliance ) don't seem to mention either <cstdbool> or <cstdalign>. Those headers were freestanding in C++17. They're not present in C++20 and C++23, but we support C++17 and earlier standards. In GCC 12 <cstdalign> and <cstdbool> were both installed when you built the library with --disable-hosted-libstdcxx, so the fact they're no longer installed for a freestanding build in GC 13 is a regression. Please do include them. > > Shouldn't I just stick to the ones we know are in? > > (Still working on figuring out how to do the change log thing) > > Best regards > Paul > > Den ons. 16. aug. 2023 kl. 18.50 skrev Paul M. Bendixen <paulbendixen@gmail.com>: >> >> Yes, the other files are in another committee proposal, and I'm working my way through the proposals one by one. >> Thank you for the feedback, I'll update and resend >> /Paul >> >> Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović <arsen@aarsen.me>: >>> >>> >>> Jonathan Wakely <jwakely@redhat.com> writes: >>> >>> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ >>> > <libstdc++@gcc.gnu.org> wrote: >>> >> >>> >> P1642 includes the header cstdarg to the freestanding implementation. >>> >> This was probably left out by accident, this patch puts it in. >>> >> Since this is one of the headers that go in whole cloth, there should be no >>> >> further actions needed. >>> > >>> > Thanks for the patch. I agree that <cstdarg> should be freestanding, >>> > but I think <cstdalign> and <cstdbool> were also missed from the >>> > change. Arsen? >>> >>> Indeed, we should include all three, and according to [compliance], >>> there's a couple more headers that we should provide (cwchar, cstring, >>> cerrno, and cmath, but these are probably significantly more involved, >>> so we can handle them separately). >>> >>> As guessed, the omission was not intentional. >>> >>> If you could, add those two to the patch as well, edit Makefile.am and >>> regenerate using automake 1.15.1, and see >>> https://gcc.gnu.org/contribute.html wrt. changelogs in commit messages. >>> >>> Thank you! Have a lovely day :-) >>> >>> [compliance]: https://eel.is/c++draft/compliance >>> >>> > Also, the patch should change include/Makefile.am as well (the .in >>> > file is autogenerated from that one). >>> > >>> > >>> >> This might be related to PR106953, but since that one touches the partial >>> >> headers I'm not sure >>> >>> The headers mentioned in this PR are provided in freestanding, >>> partially, in 13 already, indeed. >>> >>> >> /Paul M. Bendixen >>> >> >>> >> -- >>> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− >>> >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// >>> >>> >>> -- >>> Arsen Arsenović >> >> >> >> -- >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > > > > -- > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] libstdc++ Add cstdarg to freestanding 2023-09-07 16:28 ` Jonathan Wakely @ 2023-10-20 20:55 ` Paul M. Bendixen 2023-10-22 20:06 ` Arsen Arsenović 0 siblings, 1 reply; 9+ messages in thread From: Paul M. Bendixen @ 2023-10-20 20:55 UTC (permalink / raw) To: Jonathan Wakely; +Cc: Arsen Arsenović, libstdc++, gcc-patches [-- Attachment #1.1: Type: text/plain, Size: 4373 bytes --] Updated patch, added the requested files, hopefully wrote the commit better. Den tors. 7. sep. 2023 kl. 18.28 skrev Jonathan Wakely <jwakely@redhat.com>: > On Fri, 18 Aug 2023 at 20:14, Paul M. Bendixen <paulbendixen@gmail.com> > wrote: > > > > Hi > > Jonathan, I just went over the proposal again as well as [compliance], > which Arsen mentioned ( https://wg21.link/compliance ) don't seem to > mention either <cstdbool> or <cstdalign>. > > Those headers were freestanding in C++17. They're not present in C++20 > and C++23, but we support C++17 and earlier standards. > > In GCC 12 <cstdalign> and <cstdbool> were both installed when you > built the library with --disable-hosted-libstdcxx, so the fact they're > no longer installed for a freestanding build in GC 13 is a regression. > Please do include them. > > > > > > Shouldn't I just stick to the ones we know are in? > > > > (Still working on figuring out how to do the change log thing) > > > > Best regards > > Paul > > > > Den ons. 16. aug. 2023 kl. 18.50 skrev Paul M. Bendixen < > paulbendixen@gmail.com>: > >> > >> Yes, the other files are in another committee proposal, and I'm working > my way through the proposals one by one. > >> Thank you for the feedback, I'll update and resend > >> /Paul > >> > >> Den ons. 16. aug. 2023 kl. 15.51 skrev Arsen Arsenović <arsen@aarsen.me > >: > >>> > >>> > >>> Jonathan Wakely <jwakely@redhat.com> writes: > >>> > >>> > On Fri, 21 Jul 2023 at 22:23, Paul M. Bendixen via Libstdc++ > >>> > <libstdc++@gcc.gnu.org> wrote: > >>> >> > >>> >> P1642 includes the header cstdarg to the freestanding > implementation. > >>> >> This was probably left out by accident, this patch puts it in. > >>> >> Since this is one of the headers that go in whole cloth, there > should be no > >>> >> further actions needed. > >>> > > >>> > Thanks for the patch. I agree that <cstdarg> should be freestanding, > >>> > but I think <cstdalign> and <cstdbool> were also missed from the > >>> > change. Arsen? > >>> > >>> Indeed, we should include all three, and according to [compliance], > >>> there's a couple more headers that we should provide (cwchar, cstring, > >>> cerrno, and cmath, but these are probably significantly more involved, > >>> so we can handle them separately). > >>> > >>> As guessed, the omission was not intentional. > >>> > >>> If you could, add those two to the patch as well, edit Makefile.am and > >>> regenerate using automake 1.15.1, and see > >>> https://gcc.gnu.org/contribute.html wrt. changelogs in commit > messages. > >>> > >>> Thank you! Have a lovely day :-) > >>> > >>> [compliance]: https://eel.is/c++draft/compliance > >>> > >>> > Also, the patch should change include/Makefile.am as well (the .in > >>> > file is autogenerated from that one). > >>> > > >>> > > >>> >> This might be related to PR106953, but since that one touches the > partial > >>> >> headers I'm not sure > >>> > >>> The headers mentioned in this PR are provided in freestanding, > >>> partially, in 13 already, indeed. > >>> > >>> >> /Paul M. Bendixen > >>> >> > >>> >> -- > >>> >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − > − •− > >>> >> •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > >>> > >>> > >>> -- > >>> Arsen Arsenović > >> > >> > >> > >> -- > >> • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − > •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > > > > > > > > -- > > • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− > •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// > > -- • − − •/• −/• • −/• − • •/− • • •/•/− •/− • •/• •/− • • −/•/− •/• − − •− •/− − •/− −/• −/• •/• − • •/• − • − • −/− • − •/− − −/− −// [-- Attachment #2: 0001-libstdc-Include-cstdarg-in-freestanding.patch --] [-- Type: text/x-patch, Size: 2494 bytes --] From db59c3e2e54744a490e146c208dd4013c5c581f5 Mon Sep 17 00:00:00 2001 From: "Paul M. Bendixen" <paulbendixen@gmail.com> Date: Fri, 21 Jul 2023 23:35:25 +0200 Subject: [PATCH] libstdc++: Include cstdarg in freestanding P1642 includes cstdarg in the full headers to include. This commit includes it along with cstdaling andcstdbool that were left out when updating in an earlier commit. Signed-off-by: Paul M. Bendixen <paulbendixen@gmail.com> libstdc++/Changelog * include/Makefile.(in|am): move cstdarg, cstdalign and cstdbool to freestanding --- libstdc++-v3/include/Makefile.am | 6 +++--- libstdc++-v3/include/Makefile.in | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libstdc++-v3/include/Makefile.am b/libstdc++-v3/include/Makefile.am index a880e8ee227..2a42ac04436 100644 --- a/libstdc++-v3/include/Makefile.am +++ b/libstdc++-v3/include/Makefile.am @@ -849,6 +849,9 @@ c_base_builddir = . c_base_freestanding = \ ${c_base_srcdir}/cfloat \ ${c_base_srcdir}/climits \ + ${c_base_srcdir}/cstdalign \ + ${c_base_srcdir}/cstdarg \ + ${c_base_srcdir}/cstdbool \ ${c_base_srcdir}/cstddef \ ${c_base_srcdir}/cstdint \ ${c_base_srcdir}/cstdlib @@ -869,9 +872,6 @@ c_base_headers = \ ${c_base_srcdir}/cmath \ ${c_base_srcdir}/csetjmp \ ${c_base_srcdir}/csignal \ - ${c_base_srcdir}/cstdalign \ - ${c_base_srcdir}/cstdarg \ - ${c_base_srcdir}/cstdbool \ ${c_base_srcdir}/cstdio \ ${c_base_srcdir}/cstring \ ${c_base_srcdir}/ctgmath \ diff --git a/libstdc++-v3/include/Makefile.in b/libstdc++-v3/include/Makefile.in index 0ff875b280b..bdbf015e544 100644 --- a/libstdc++-v3/include/Makefile.in +++ b/libstdc++-v3/include/Makefile.in @@ -1194,6 +1194,9 @@ c_base_builddir = . c_base_freestanding = \ ${c_base_srcdir}/cfloat \ ${c_base_srcdir}/climits \ + ${c_base_srcdir}/cstdalign \ + ${c_base_srcdir}/cstdarg \ + ${c_base_srcdir}/cstdbool \ ${c_base_srcdir}/cstddef \ ${c_base_srcdir}/cstdint \ ${c_base_srcdir}/cstdlib @@ -1212,9 +1215,6 @@ c_base_freestanding = \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cmath \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/csetjmp \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/csignal \ -@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdalign \ -@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdarg \ -@GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdbool \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstdio \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/cstring \ @GLIBCXX_HOSTED_TRUE@ ${c_base_srcdir}/ctgmath \ -- 2.34.1 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] libstdc++ Add cstdarg to freestanding 2023-10-20 20:55 ` Paul M. Bendixen @ 2023-10-22 20:06 ` Arsen Arsenović 2023-10-24 20:27 ` Jonathan Wakely 0 siblings, 1 reply; 9+ messages in thread From: Arsen Arsenović @ 2023-10-22 20:06 UTC (permalink / raw) To: Paul M. Bendixen; +Cc: Jonathan Wakely, libstdc++, gcc-patches [-- Attachment #1: Type: text/plain, Size: 180 bytes --] "Paul M. Bendixen" <paulbendixen@gmail.com> writes: > Updated patch, added the requested files, hopefully wrote the commit better. LGTM. Jonathan? -- Arsen Arsenović [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 381 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] libstdc++ Add cstdarg to freestanding 2023-10-22 20:06 ` Arsen Arsenović @ 2023-10-24 20:27 ` Jonathan Wakely 0 siblings, 0 replies; 9+ messages in thread From: Jonathan Wakely @ 2023-10-24 20:27 UTC (permalink / raw) To: Arsen Arsenović; +Cc: Paul M. Bendixen, libstdc++, gcc-patches [-- Attachment #1: Type: text/plain, Size: 378 bytes --] On Sun, 22 Oct 2023 at 21:06, Arsen Arsenović <arsen@aarsen.me> wrote: > > "Paul M. Bendixen" <paulbendixen@gmail.com> writes: > > > Updated patch, added the requested files, hopefully wrote the commit > better. > > LGTM. Jonathan? > Yup, looks good. I've pushed it to trunk with a tweaked changelog entry. I'll backport it to gcc-13 soon too. Thanks, Paul! ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-10-24 20:27 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-07-21 21:22 [PATCH] libstdc++ Add cstdarg to freestanding Paul M. Bendixen 2023-08-16 11:21 ` Jonathan Wakely 2023-08-16 13:27 ` Arsen Arsenović 2023-08-16 16:50 ` Paul M. Bendixen 2023-08-18 19:14 ` Paul M. Bendixen 2023-09-07 16:28 ` Jonathan Wakely 2023-10-20 20:55 ` Paul M. Bendixen 2023-10-22 20:06 ` Arsen Arsenović 2023-10-24 20:27 ` Jonathan Wakely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).